All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mmc: stm32_sdmmc2: change the displayed config name
@ 2020-04-30  7:52 Patrick Delaunay
  2020-05-11 14:00 ` Patrice CHOTARD
  2020-05-14  9:40 ` Patrick DELAUNAY
  0 siblings, 2 replies; 3+ messages in thread
From: Patrick Delaunay @ 2020-04-30  7:52 UTC (permalink / raw)
  To: u-boot

Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to
?STM32 SD/MMC?.

This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the
displayed name "STM32 SDMMC2" is confusing for user, between the
instance of SDMMC and the device identifier of MMC.

For example on EV1 board, we have:

STM32MP1> mmc list
 STM32 SDMMC2: 0 (SD)
 STM32 SDMMC2: 1 (eMMC)

Changed to more clear:

STM32MP1> mmc list
 STM32 SD/MMC: 0 (SD)
 STM32 SD/MMC: 1 (eMMC)

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---

 drivers/mmc/stm32_sdmmc2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c
index 6f3b2ad653..fa6fc94ad9 100644
--- a/drivers/mmc/stm32_sdmmc2.c
+++ b/drivers/mmc/stm32_sdmmc2.c
@@ -674,7 +674,7 @@ static int stm32_sdmmc2_probe(struct udevice *dev)
 	cfg->f_max = dev_read_u32_default(dev, "max-frequency", 52000000);
 	cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
 	cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
-	cfg->name = "STM32 SDMMC2";
+	cfg->name = "STM32 SD/MMC";
 
 	cfg->host_caps = 0;
 	if (cfg->f_max > 25000000)
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] mmc: stm32_sdmmc2: change the displayed config name
  2020-04-30  7:52 [PATCH] mmc: stm32_sdmmc2: change the displayed config name Patrick Delaunay
@ 2020-05-11 14:00 ` Patrice CHOTARD
  2020-05-14  9:40 ` Patrick DELAUNAY
  1 sibling, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2020-05-11 14:00 UTC (permalink / raw)
  To: u-boot


On 4/30/20 9:52 AM, Patrick Delaunay wrote:
> Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to
> ?STM32 SD/MMC?.
>
> This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the
> displayed name "STM32 SDMMC2" is confusing for user, between the
> instance of SDMMC and the device identifier of MMC.
>
> For example on EV1 board, we have:
>
> STM32MP1> mmc list
>  STM32 SDMMC2: 0 (SD)
>  STM32 SDMMC2: 1 (eMMC)
>
> Changed to more clear:
>
> STM32MP1> mmc list
>  STM32 SD/MMC: 0 (SD)
>  STM32 SD/MMC: 1 (eMMC)
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
>  drivers/mmc/stm32_sdmmc2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/stm32_sdmmc2.c b/drivers/mmc/stm32_sdmmc2.c
> index 6f3b2ad653..fa6fc94ad9 100644
> --- a/drivers/mmc/stm32_sdmmc2.c
> +++ b/drivers/mmc/stm32_sdmmc2.c
> @@ -674,7 +674,7 @@ static int stm32_sdmmc2_probe(struct udevice *dev)
>  	cfg->f_max = dev_read_u32_default(dev, "max-frequency", 52000000);
>  	cfg->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195;
>  	cfg->b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
> -	cfg->name = "STM32 SDMMC2";
> +	cfg->name = "STM32 SD/MMC";
>  
>  	cfg->host_caps = 0;
>  	if (cfg->f_max > 25000000)

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

Patrice

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] mmc: stm32_sdmmc2: change the displayed config name
  2020-04-30  7:52 [PATCH] mmc: stm32_sdmmc2: change the displayed config name Patrick Delaunay
  2020-05-11 14:00 ` Patrice CHOTARD
@ 2020-05-14  9:40 ` Patrick DELAUNAY
  1 sibling, 0 replies; 3+ messages in thread
From: Patrick DELAUNAY @ 2020-05-14  9:40 UTC (permalink / raw)
  To: u-boot

Hi,

> From: Patrick DELAUNAY <patrick.delaunay@st.com>
> Sent: jeudi 30 avril 2020 09:52
> 
> Change the mmc displayed name in U-Boot for stm32_sdmmc2 driver to
> ?STM32 SD/MMC?.
> 
> This stm32_sdmmc2 driver is for version 2 of the ST HW IP SDMMC but the
> displayed name "STM32 SDMMC2" is confusing for user, between the instance of
> SDMMC and the device identifier of MMC.
> 
> For example on EV1 board, we have:
> 
> STM32MP1> mmc list
>  STM32 SDMMC2: 0 (SD)
>  STM32 SDMMC2: 1 (eMMC)
> 
> Changed to more clear:
> 
> STM32MP1> mmc list
>  STM32 SD/MMC: 0 (SD)
>  STM32 SD/MMC: 1 (eMMC)
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> 
>  drivers/mmc/stm32_sdmmc2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied to u-boot-stm/master, thanks!

Regards

Patrick

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-14  9:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30  7:52 [PATCH] mmc: stm32_sdmmc2: change the displayed config name Patrick Delaunay
2020-05-11 14:00 ` Patrice CHOTARD
2020-05-14  9:40 ` Patrick DELAUNAY

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.