From: Robert Foley <robert.foley@linaro.org>
To: qemu-devel@nongnu.org
Cc: philmd@redhat.com, alex.bennee@linaro.org,
robert.foley@linaro.org, peter.puhov@linaro.org
Subject: [PATCH v5 4/9] tests/vm: Add ability to select QEMU from current build.
Date: Thu, 30 Apr 2020 11:57:13 -0400 [thread overview]
Message-ID: <20200430155718.212-5-robert.foley@linaro.org> (raw)
In-Reply-To: <20200430155718.212-1-robert.foley@linaro.org>
Added a new special variable QEMU_LOCAL=1, which
will indicate to take the QEMU binary from the current
build.
Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Peter Puhov <peter.puhov@linaro.org>
---
tests/vm/Makefile.include | 4 ++++
tests/vm/basevm.py | 30 +++++++++++++++++++++++++-----
2 files changed, 29 insertions(+), 5 deletions(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index d921ee14cf..667705a91a 100644
--- a/tests/vm/Makefile.include
+++ b/tests/vm/Makefile.include
@@ -42,6 +42,7 @@ endif
@echo " DEBUG=1 - Enable verbose output on host and interactive debugging"
@echo " BOOT_CONSOLE=1 - Show the console output at boot time. "
@echo " V=1 - Enable verbose ouput on host and guest commands"
+ @echo " QEMU_LOCAL=1 - Use QEMU binary local to this build."
@echo " QEMU=/path/to/qemu - Change path to QEMU binary"
@echo " QEMU_IMG=/path/to/qemu-img - Change path to qemu-img tool"
ifeq ($(PYTHON_YAML),yes)
@@ -64,6 +65,7 @@ $(IMAGES_DIR)/%.img: $(SRC_PATH)/tests/vm/% \
$(PYTHON) $< \
$(if $(V)$(DEBUG), --debug) \
$(if $(BOOT_CONSOLE),--boot-console) \
+ --build-path $(BUILD_DIR)\
--image "$@" \
--force \
--build-image $@, \
@@ -79,6 +81,7 @@ vm-build-%: $(IMAGES_DIR)/%.img
$(if $(J),--jobs $(J)) \
$(if $(V),--verbose) \
$(if $(BOOT_CONSOLE),--boot-console) \
+ --build-path $(BUILD_DIR)\
--image "$<" \
$(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
--snapshot \
@@ -100,6 +103,7 @@ vm-boot-ssh-%: $(IMAGES_DIR)/%.img
$(PYTHON) $(SRC_PATH)/tests/vm/$* \
$(if $(J),--jobs $(J)) \
$(if $(BOOT_CONSOLE),--boot-console) \
+ --build-path $(BUILD_DIR)\
--image "$<" \
--interactive \
false, \
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 983adbf6ff..7b86ccd018 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -87,8 +87,9 @@ class BaseVM(object):
# since we found we need to wait more than twice as long.
tcg_ssh_timeout_multiplier = 4
def __init__(self, debug=False, vcpus=None, config=None,
- boot_console=None):
+ boot_console=False, build_path=None):
self._guest = None
+ self._build_path = build_path
self._boot_console = boot_console
# Allow input config to override defaults.
self._config = DEFAULT_CONFIG.copy()
@@ -274,15 +275,15 @@ class BaseVM(object):
args = self._args + boot_params.split(' ')
args += self._data_args + extra_args + self._config['extra_args']
logging.debug("QEMU args: %s", " ".join(args))
- qemu_bin = os.environ.get("QEMU", "qemu-system-" + self.arch)
- guest = QEMUMachine(binary=qemu_bin, args=args)
+ qemu_path = get_qemu_path(self.arch, self._build_path)
+ guest = QEMUMachine(binary=qemu_path, args=args)
guest.set_machine(self._config['machine'])
guest.set_console()
try:
guest.launch()
except:
logging.error("Failed to launch QEMU, command line:")
- logging.error(" ".join([qemu_bin] + args))
+ logging.error(" ".join([qemu_path] + args))
logging.error("Log:")
logging.error(guest.get_log())
logging.error("QEMU version >= 2.10 is required")
@@ -481,6 +482,22 @@ class BaseVM(object):
stderr=self._stdout)
return os.path.join(cidir, "cloud-init.iso")
+def get_qemu_path(arch, build_path=None):
+ """Fetch the path to the qemu binary."""
+ qemu_local = os.environ.get("QEMU_LOCAL", 0)
+ # If QEMU environment variable set, it takes precedence
+ if "QEMU" in os.environ:
+ qemu_path = os.environ["QEMU"]
+ elif qemu_local:
+ if not build_path:
+ raise Exception("--build-path option required with QEMU_LOCAL")
+ qemu_path = os.path.join(build_path, arch + "-softmmu")
+ qemu_path = os.path.join(qemu_path, "qemu-system-" + arch)
+ else:
+ # Default is to use system path for qemu.
+ qemu_path = "qemu-system-" + arch
+ return qemu_path
+
def parse_config(config, args):
""" Parse yaml config and populate our config structure.
The yaml config allows the user to override the
@@ -555,6 +572,8 @@ def parse_args(vmcls):
"See config_example.yaml for example.")
parser.add_option("--boot-console", action="store_true",
help="Show console during boot. ")
+ parser.add_option("--build-path", default=None,
+ help="Path of build directory. ")
parser.disable_interspersed_args()
return parser.parse_args()
@@ -570,7 +589,8 @@ def main(vmcls, config=None):
logging.basicConfig(level=(logging.DEBUG if args.debug
else logging.WARN))
vm = vmcls(debug=args.debug, vcpus=args.jobs, config=config,
- boot_console=args.boot_console)
+ boot_console=args.boot_console,
+ build_path=args.build_path)
if args.build_image:
if os.path.exists(args.image) and not args.force:
sys.stderr.writelines(["Image file exists: %s\n" % args.image,
--
2.17.1
next prev parent reply other threads:[~2020-04-30 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 15:57 [PATCH v5 0/9] tests/vm: Add support for aarch64 VMs Robert Foley
2020-04-30 15:57 ` [PATCH v5 1/9] tests/vm: Add configuration to basevm.py Robert Foley
2020-04-30 15:57 ` [PATCH v5 2/9] tests/vm: Added configuration file support Robert Foley
2020-04-30 15:57 ` [PATCH v5 3/9] tests/vm: add --boot-console switch Robert Foley
2020-04-30 15:57 ` Robert Foley [this message]
2020-04-30 15:57 ` [PATCH v5 5/9] tests/vm: allow wait_ssh() to specify command Robert Foley
2020-04-30 15:57 ` [PATCH v5 6/9] tests/vm: Added a new script for ubuntu.aarch64 Robert Foley
2020-04-30 15:57 ` [PATCH v5 7/9] tests/vm: Added a new script for centos.aarch64 Robert Foley
2020-04-30 15:57 ` [PATCH v5 8/9] tests/vm: change scripts to use self._config Robert Foley
2020-04-30 15:57 ` [PATCH v5 9/9] tests/vm: Add workaround to consume console Robert Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430155718.212-5-robert.foley@linaro.org \
--to=robert.foley@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.puhov@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.