All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Foley <robert.foley@linaro.org>
To: qemu-devel@nongnu.org
Cc: philmd@redhat.com, alex.bennee@linaro.org,
	robert.foley@linaro.org, peter.puhov@linaro.org
Subject: [PATCH v5 5/9] tests/vm: allow wait_ssh() to specify command
Date: Thu, 30 Apr 2020 11:57:14 -0400	[thread overview]
Message-ID: <20200430155718.212-6-robert.foley@linaro.org> (raw)
In-Reply-To: <20200430155718.212-1-robert.foley@linaro.org>

This allows for waiting for completion of arbitrary commands.

Signed-off-by: Robert Foley <robert.foley@linaro.org>
Reviewed-by: Peter Puhov <peter.puhov@linaro.org>
---
 tests/vm/basevm.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 7b86ccd018..9f06f84974 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -410,24 +410,24 @@ class BaseVM(object):
     def print_step(self, text):
         sys.stderr.write("### %s ...\n" % text)
 
-    def wait_ssh(self, wait_root=False, seconds=300):
+    def wait_ssh(self, wait_root=False, seconds=300, cmd="exit 0"):
         # Allow more time for VM to boot under TCG.
         if not kvm_available(self.arch):
             seconds *= self.tcg_ssh_timeout_multiplier
         starttime = datetime.datetime.now()
         endtime = starttime + datetime.timedelta(seconds=seconds)
-        guest_up = False
+        cmd_success = False
         while datetime.datetime.now() < endtime:
-            if wait_root and self.ssh_root("exit 0") == 0:
-                guest_up = True
+            if wait_root and self.ssh_root(cmd) == 0:
+                cmd_success = True
                 break
-            elif self.ssh("exit 0") == 0:
-                guest_up = True
+            elif self.ssh(cmd) == 0:
+                cmd_success = True
                 break
             seconds = (endtime - datetime.datetime.now()).total_seconds()
             logging.debug("%ds before timeout", seconds)
             time.sleep(1)
-        if not guest_up:
+        if not cmd_success:
             raise Exception("Timeout while waiting for guest ssh")
 
     def shutdown(self):
-- 
2.17.1



  parent reply	other threads:[~2020-04-30 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 15:57 [PATCH v5 0/9] tests/vm: Add support for aarch64 VMs Robert Foley
2020-04-30 15:57 ` [PATCH v5 1/9] tests/vm: Add configuration to basevm.py Robert Foley
2020-04-30 15:57 ` [PATCH v5 2/9] tests/vm: Added configuration file support Robert Foley
2020-04-30 15:57 ` [PATCH v5 3/9] tests/vm: add --boot-console switch Robert Foley
2020-04-30 15:57 ` [PATCH v5 4/9] tests/vm: Add ability to select QEMU from current build Robert Foley
2020-04-30 15:57 ` Robert Foley [this message]
2020-04-30 15:57 ` [PATCH v5 6/9] tests/vm: Added a new script for ubuntu.aarch64 Robert Foley
2020-04-30 15:57 ` [PATCH v5 7/9] tests/vm: Added a new script for centos.aarch64 Robert Foley
2020-04-30 15:57 ` [PATCH v5 8/9] tests/vm: change scripts to use self._config Robert Foley
2020-04-30 15:57 ` [PATCH v5 9/9] tests/vm: Add workaround to consume console Robert Foley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430155718.212-6-robert.foley@linaro.org \
    --to=robert.foley@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=peter.puhov@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.