From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: hch@infradead.org, david@fromorbit.com, willy@infradead.org, Guoqing Jiang <guoqing.jiang@cloud.ionos.com>, Jaegeuk Kim <jaegeuk@kernel.org>, linux-f2fs-devel@lists.sourceforge.net Subject: [RFC PATCH V2 5/9] f2fs: use attach/clear_page_private Date: Thu, 30 Apr 2020 23:44:46 +0200 [thread overview] Message-ID: <20200430214450.10662-6-guoqing.jiang@cloud.ionos.com> (raw) In-Reply-To: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> Since the new pair function is introduced, we can call them to clean the code in f2fs.h. Cc: Jaegeuk Kim <jaegeuk@kernel.org> Cc: linux-f2fs-devel@lists.sourceforge.net Acked-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> --- RFC -> RFC V2 1. change the name of new functions to attach/clear_page_private. fs/f2fs/f2fs.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index ba470d5687fe..24d22bd7352d 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3051,19 +3051,12 @@ static inline void f2fs_set_page_private(struct page *page, if (PagePrivate(page)) return; - get_page(page); - SetPagePrivate(page); - set_page_private(page, data); + attach_page_private(page, (void *)data); } static inline void f2fs_clear_page_private(struct page *page) { - if (!PagePrivate(page)) - return; - - set_page_private(page, 0); - ClearPagePrivate(page); - f2fs_put_page(page, 0); + clear_page_private(page); } /* -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>, david@fromorbit.com, willy@infradead.org, linux-f2fs-devel@lists.sourceforge.net, hch@infradead.org, Jaegeuk Kim <jaegeuk@kernel.org> Subject: [f2fs-dev] [RFC PATCH V2 5/9] f2fs: use attach/clear_page_private Date: Thu, 30 Apr 2020 23:44:46 +0200 [thread overview] Message-ID: <20200430214450.10662-6-guoqing.jiang@cloud.ionos.com> (raw) In-Reply-To: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> Since the new pair function is introduced, we can call them to clean the code in f2fs.h. Cc: Jaegeuk Kim <jaegeuk@kernel.org> Cc: linux-f2fs-devel@lists.sourceforge.net Acked-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> --- RFC -> RFC V2 1. change the name of new functions to attach/clear_page_private. fs/f2fs/f2fs.h | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index ba470d5687fe..24d22bd7352d 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -3051,19 +3051,12 @@ static inline void f2fs_set_page_private(struct page *page, if (PagePrivate(page)) return; - get_page(page); - SetPagePrivate(page); - set_page_private(page, data); + attach_page_private(page, (void *)data); } static inline void f2fs_clear_page_private(struct page *page) { - if (!PagePrivate(page)) - return; - - set_page_private(page, 0); - ClearPagePrivate(page); - f2fs_put_page(page, 0); + clear_page_private(page); } /* -- 2.17.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-04-30 21:52 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-30 21:44 [RFC PATCH V2 0/9] Introduce attach/clear_page_private to cleanup code Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 1/9] include/linux/pagemap.h: introduce attach/clear_page_private Guoqing Jiang 2020-04-30 21:44 ` [f2fs-dev] " Guoqing Jiang 2020-04-30 21:44 ` Guoqing Jiang 2020-04-30 22:10 ` Andreas Grünbacher 2020-04-30 22:10 ` [f2fs-dev] " Andreas Grünbacher 2020-04-30 22:10 ` Andreas Grünbacher 2020-05-01 6:38 ` Guoqing Jiang 2020-05-01 6:38 ` [f2fs-dev] " Guoqing Jiang 2020-05-01 6:38 ` Guoqing Jiang 2020-04-30 22:13 ` Matthew Wilcox 2020-04-30 22:13 ` [f2fs-dev] " Matthew Wilcox 2020-04-30 22:13 ` Matthew Wilcox 2020-05-01 1:42 ` Al Viro 2020-05-01 1:42 ` [f2fs-dev] " Al Viro 2020-05-01 1:42 ` Al Viro 2020-05-01 1:49 ` Al Viro 2020-05-01 1:49 ` [f2fs-dev] " Al Viro 2020-05-01 1:49 ` Al Viro 2020-05-01 6:41 ` Guoqing Jiang 2020-05-01 6:41 ` [f2fs-dev] " Guoqing Jiang 2020-05-01 6:41 ` Guoqing Jiang 2020-05-01 6:39 ` Guoqing Jiang 2020-05-01 6:39 ` [f2fs-dev] " Guoqing Jiang 2020-05-01 6:39 ` Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 2/9] md: remove __clear_page_buffers and use attach/clear_page_private Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 3/9] btrfs: " Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 4/9] fs/buffer.c: " Guoqing Jiang 2020-04-30 21:44 ` Guoqing Jiang [this message] 2020-04-30 21:44 ` [f2fs-dev] [RFC PATCH V2 5/9] f2fs: " Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 6/9] iomap: " Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 7/9] ntfs: replace attach_page_buffers with attach_page_private Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 8/9] orangefs: use attach/clear_page_private Guoqing Jiang 2020-04-30 21:44 ` [RFC PATCH V2 9/9] buffer_head.h: remove attach_page_buffers Guoqing Jiang 2020-05-01 22:16 ` [RFC PATCH V2 0/9] Introduce attach/clear_page_private to cleanup code Matthew Wilcox 2020-05-01 22:42 ` Guoqing Jiang 2020-05-02 0:41 ` Matthew Wilcox 2020-05-02 8:56 ` Guoqing Jiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200430214450.10662-6-guoqing.jiang@cloud.ionos.com \ --to=guoqing.jiang@cloud.ionos.com \ --cc=david@fromorbit.com \ --cc=hch@infradead.org \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.