From: Peng Fan <peng.fan@nxp.com>
To: u-boot@lists.denx.de
Subject: [PATCH V2 4/9] common: board_f: Use cpu_get_current_dev in print_cpuinfo
Date: Fri, 1 May 2020 21:44:13 +0800 [thread overview]
Message-ID: <20200501134418.7319-4-peng.fan@nxp.com> (raw)
In-Reply-To: <20200501134418.7319-1-peng.fan@nxp.com>
From: Ye Li <ye.li@nxp.com>
Current print_cpuinfo gets the first udevice in CPU class to return
the cpu info. This has problem if the boot CPU is not fixed.
Changing to use new API cpu_get_current_dev to fix the issue.
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
Add R-b tag
common/board_f.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/common/board_f.c b/common/board_f.c
index 5c650f046c..5223453511 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -183,11 +183,11 @@ static int print_cpuinfo(void)
char desc[512];
int ret;
- ret = uclass_first_device_err(UCLASS_CPU, &dev);
- if (ret) {
- debug("%s: Could not get CPU device (err = %d)\n",
- __func__, ret);
- return ret;
+ dev = cpu_get_current_dev();
+ if (!dev) {
+ debug("%s: Could not get CPU device\n",
+ __func__);
+ return -ENODEV;
}
ret = cpu_get_desc(dev, desc, sizeof(desc));
--
2.16.4
next prev parent reply other threads:[~2020-05-01 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 13:44 [PATCH V2 1/9] uclass: cpu: Add new API to get udevice for current CPU Peng Fan
2020-05-01 13:44 ` [PATCH V2 2/9] cpu: sandbox: support is_current Peng Fan
2020-05-03 2:26 ` Simon Glass
2020-05-01 13:44 ` [PATCH V2 3/9] test: cpu: test current cpu Peng Fan
2020-05-03 2:26 ` Simon Glass
2020-05-01 13:44 ` Peng Fan [this message]
2020-05-01 13:44 ` [PATCH V2 5/9] cpu: imx8: reimplement get cpu count Peng Fan
2020-05-01 13:44 ` [PATCH V2 6/9] cpu: imx8: support a72 as boot cpu Peng Fan
2020-05-01 13:44 ` [PATCH V2 7/9] cpu: imx8: fix get core name and rate Peng Fan
2020-05-01 13:44 ` [PATCH V2 8/9] cpu: imx_cpu: Print the CPU temperature for iMX8QM A72 Peng Fan
2020-05-03 2:26 ` Simon Glass
2020-05-01 13:44 ` [PATCH V2 9/9] cpu: imx8: show RevC instead of Rev? at boot log Peng Fan
2020-05-03 2:26 ` [PATCH V2 1/9] uclass: cpu: Add new API to get udevice for current CPU Simon Glass
2020-05-03 13:14 ` Peng Fan
2020-05-04 12:53 ` Simon Glass
2020-05-04 12:56 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501134418.7319-4-peng.fan@nxp.com \
--to=peng.fan@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.