All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: u-boot@lists.denx.de
Subject: [PATCH V2 8/9] cpu: imx_cpu: Print the CPU temperature for iMX8QM A72
Date: Fri,  1 May 2020 21:44:17 +0800	[thread overview]
Message-ID: <20200501134418.7319-8-peng.fan@nxp.com> (raw)
In-Reply-To: <20200501134418.7319-1-peng.fan@nxp.com>

From: Ye Li <ye.li@nxp.com>

iMX8QM registers two thermal devices for CPUs, get the temperature
from "cpu-thermal1" device for A72

Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Per Simon's comments, use uclass_get_device

 drivers/cpu/imx8_cpu.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/cpu/imx8_cpu.c b/drivers/cpu/imx8_cpu.c
index c96a2d3563..817e0ffd01 100644
--- a/drivers/cpu/imx8_cpu.c
+++ b/drivers/cpu/imx8_cpu.c
@@ -61,13 +61,15 @@ const char *get_core_name(struct udevice *dev)
 }
 
 #if IS_ENABLED(CONFIG_IMX_SCU_THERMAL)
-static int cpu_imx_get_temp(void)
+static int cpu_imx_get_temp(struct cpu_imx_platdata *plat)
 {
 	struct udevice *thermal_dev;
 	int cpu_tmp, ret;
 
-	ret = uclass_get_device_by_name(UCLASS_THERMAL, "cpu-thermal0",
-					&thermal_dev);
+	if (!strcmp(plat->name, "A72"))
+		ret = uclass_get_device(UCLASS_THERMAL, 1, &thermal_dev);
+	else
+		ret = uclass_get_device(UCLASS_THERMAL, 0, &thermal_dev);
 
 	if (!ret) {
 		ret = thermal_get_temp(thermal_dev, &cpu_tmp);
@@ -80,7 +82,7 @@ static int cpu_imx_get_temp(void)
 	return cpu_tmp;
 }
 #else
-static int cpu_imx_get_temp(void)
+static int cpu_imx_get_temp(struct cpu_imx_platdata *plat)
 {
 	return 0;
 }
@@ -89,7 +91,7 @@ static int cpu_imx_get_temp(void)
 int cpu_imx_get_desc(struct udevice *dev, char *buf, int size)
 {
 	struct cpu_imx_platdata *plat = dev_get_platdata(dev);
-	int ret;
+	int ret, temp;
 
 	if (size < 100)
 		return -ENOSPC;
@@ -98,9 +100,13 @@ int cpu_imx_get_desc(struct udevice *dev, char *buf, int size)
 		       plat->type, plat->rev, plat->name, plat->freq_mhz);
 
 	if (IS_ENABLED(CONFIG_IMX_SCU_THERMAL)) {
+		temp = cpu_imx_get_temp(plat);
 		buf = buf + ret;
 		size = size - ret;
-		ret = snprintf(buf, size, " at %dC", cpu_imx_get_temp());
+		if (temp != 0xdeadbeef)
+			ret = snprintf(buf, size, " at %dC", temp);
+		else
+			ret = snprintf(buf, size, " - invalid sensor data");
 	}
 
 	snprintf(buf + ret, size - ret, "\n");
-- 
2.16.4

  parent reply	other threads:[~2020-05-01 13:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 13:44 [PATCH V2 1/9] uclass: cpu: Add new API to get udevice for current CPU Peng Fan
2020-05-01 13:44 ` [PATCH V2 2/9] cpu: sandbox: support is_current Peng Fan
2020-05-03  2:26   ` Simon Glass
2020-05-01 13:44 ` [PATCH V2 3/9] test: cpu: test current cpu Peng Fan
2020-05-03  2:26   ` Simon Glass
2020-05-01 13:44 ` [PATCH V2 4/9] common: board_f: Use cpu_get_current_dev in print_cpuinfo Peng Fan
2020-05-01 13:44 ` [PATCH V2 5/9] cpu: imx8: reimplement get cpu count Peng Fan
2020-05-01 13:44 ` [PATCH V2 6/9] cpu: imx8: support a72 as boot cpu Peng Fan
2020-05-01 13:44 ` [PATCH V2 7/9] cpu: imx8: fix get core name and rate Peng Fan
2020-05-01 13:44 ` Peng Fan [this message]
2020-05-03  2:26   ` [PATCH V2 8/9] cpu: imx_cpu: Print the CPU temperature for iMX8QM A72 Simon Glass
2020-05-01 13:44 ` [PATCH V2 9/9] cpu: imx8: show RevC instead of Rev? at boot log Peng Fan
2020-05-03  2:26 ` [PATCH V2 1/9] uclass: cpu: Add new API to get udevice for current CPU Simon Glass
2020-05-03 13:14   ` Peng Fan
2020-05-04 12:53     ` Simon Glass
2020-05-04 12:56       ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501134418.7319-8-peng.fan@nxp.com \
    --to=peng.fan@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.