* [PATCH] tests: dump generated use new nft tool
@ 2020-05-01 21:09 Michael Braun
2020-05-01 21:56 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Michael Braun @ 2020-05-01 21:09 UTC (permalink / raw)
To: netfilter-devel; +Cc: Michael Braun
Instead of using an (possibly outdated) system nft to generate dumps,
use the newly build tool.
This fixes the dump output being corrupted if the system tool does
not support parsing new features.
Signed-off-by: Michael Braun <michael-dev@fami-braun.de>
---
tests/shell/run-tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/shell/run-tests.sh b/tests/shell/run-tests.sh
index 2c415489..26f8f46d 100755
--- a/tests/shell/run-tests.sh
+++ b/tests/shell/run-tests.sh
@@ -122,7 +122,7 @@ do
if [ "$DUMPGEN" == "y" ] && [ "$rc_got" == 0 ] && [ ! -f "${dumpfile}" ]; then
mkdir -p "${dumppath}"
- nft list ruleset > "${dumpfile}"
+ $NFT list ruleset > "${dumpfile}"
fi
else
((failed++))
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests: dump generated use new nft tool
2020-05-01 21:09 [PATCH] tests: dump generated use new nft tool Michael Braun
@ 2020-05-01 21:56 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2020-05-01 21:56 UTC (permalink / raw)
To: Michael Braun; +Cc: netfilter-devel
On Fri, May 01, 2020 at 11:09:49PM +0200, Michael Braun wrote:
> Instead of using an (possibly outdated) system nft to generate dumps,
> use the newly build tool.
>
> This fixes the dump output being corrupted if the system tool does
> not support parsing new features.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-01 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-01 21:09 [PATCH] tests: dump generated use new nft tool Michael Braun
2020-05-01 21:56 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.