From: Peng Fan <peng.fan@nxp.com>
To: u-boot@lists.denx.de
Subject: [PATCH 3/4] sata: dwc_ahsata: Fix incorrect free
Date: Sun, 3 May 2020 22:27:02 +0800 [thread overview]
Message-ID: <20200503142703.14903-3-peng.fan@nxp.com> (raw)
In-Reply-To: <20200503142703.14903-1-peng.fan@nxp.com>
From: Ye Li <ye.li@nxp.com>
Fix coverity issue CID 43665: Free of address-of expression (BAD_FREE)
incorrect_free: free frees incorrect pointer pp.
pp points the port array field of struct ahci_uc_priv, should not free it.
Acked-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Ye Li <ye.li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/ata/dwc_ahsata.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/dwc_ahsata.c b/drivers/ata/dwc_ahsata.c
index 4b37a02338..82fbb50da6 100644
--- a/drivers/ata/dwc_ahsata.c
+++ b/drivers/ata/dwc_ahsata.c
@@ -450,7 +450,6 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, u8 port)
mem = (u32)malloc(AHCI_PORT_PRIV_DMA_SZ + 1024);
if (!mem) {
- free(pp);
printf("No mem for table!\n");
return -ENOMEM;
}
--
2.16.4
next prev parent reply other threads:[~2020-05-03 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 14:27 [PATCH 1/4] sata: ahsata: Fix resource leak Peng Fan
2020-05-03 14:27 ` [PATCH 2/4] sata: ahsata: Fix wrong operand for checking SERR DIAG_X Peng Fan
2020-05-04 14:17 ` Simon Glass
2020-05-08 22:59 ` Tom Rini
2020-05-03 14:27 ` Peng Fan [this message]
2020-05-04 14:17 ` [PATCH 3/4] sata: dwc_ahsata: Fix incorrect free Simon Glass
2020-05-08 22:59 ` Tom Rini
2020-05-03 14:27 ` [PATCH 4/4] sata: dwc_ahsata: Fix memory issue in reset_sata Peng Fan
2020-05-08 22:59 ` Tom Rini
2020-05-04 14:17 ` [PATCH 1/4] sata: ahsata: Fix resource leak Simon Glass
2020-05-04 14:28 ` Peng Fan
2020-05-08 22:59 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503142703.14903-3-peng.fan@nxp.com \
--to=peng.fan@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.