All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Subject: [PATCH 2/4] sata: ahsata: Fix wrong operand for checking SERR DIAG_X
Date: Mon, 4 May 2020 08:17:49 -0600	[thread overview]
Message-ID: <CAPnjgZ2ga0rToaoAtsJuVkdzd5VkGAhXugWGWd8yC=xSw-3-Mw@mail.gmail.com> (raw)
In-Reply-To: <20200503142703.14903-2-peng.fan@nxp.com>

On Sun, 3 May 2020 at 08:04, Peng Fan <peng.fan@nxp.com> wrote:
>
> From: Ye Li <ye.li@nxp.com>
>
> Fix coverity issue CID 3261683: Wrong operator used
> (CONSTANT_EXPRESSION_RESULT) operator_confusion:
> ({...; __v;}) | 67108864 is always 1/true regardless of the values
> of its operand. This occurs as the logical operand of !
>
> When DIAG_X is set, the PHY COMINIT signal is detected, so
> should use '&' to check whether it is set.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/ata/dwc_ahsata.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

  reply	other threads:[~2020-05-04 14:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03 14:27 [PATCH 1/4] sata: ahsata: Fix resource leak Peng Fan
2020-05-03 14:27 ` [PATCH 2/4] sata: ahsata: Fix wrong operand for checking SERR DIAG_X Peng Fan
2020-05-04 14:17   ` Simon Glass [this message]
2020-05-08 22:59   ` Tom Rini
2020-05-03 14:27 ` [PATCH 3/4] sata: dwc_ahsata: Fix incorrect free Peng Fan
2020-05-04 14:17   ` Simon Glass
2020-05-08 22:59   ` Tom Rini
2020-05-03 14:27 ` [PATCH 4/4] sata: dwc_ahsata: Fix memory issue in reset_sata Peng Fan
2020-05-08 22:59   ` Tom Rini
2020-05-04 14:17 ` [PATCH 1/4] sata: ahsata: Fix resource leak Simon Glass
2020-05-04 14:28   ` Peng Fan
2020-05-08 22:59 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPnjgZ2ga0rToaoAtsJuVkdzd5VkGAhXugWGWd8yC=xSw-3-Mw@mail.gmail.com' \
    --to=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.