All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alistair Francis" <Alistair.Francis@wdc.com>,
	qemu-riscv@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"David Hildenbrand" <david@redhat.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-s390x@nongnu.org, "Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v3 10/12] target/i386: Restrict CpuClass::get_crash_info() to system-mode
Date: Mon,  4 May 2020 17:29:20 +0200	[thread overview]
Message-ID: <20200504152922.21365-11-philmd@redhat.com> (raw)
In-Reply-To: <20200504152922.21365-1-philmd@redhat.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 target/i386/cpu.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 9c256ab159..eec1ac7cea 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6848,6 +6848,7 @@ static void x86_cpu_register_feature_bit_props(X86CPU *cpu,
     x86_cpu_register_bit_prop(cpu, name, w, bitnr);
 }
 
+#if !defined(CONFIG_USER_ONLY)
 static GuestPanicInformation *x86_cpu_get_crash_info(CPUState *cs)
 {
     X86CPU *cpu = X86_CPU(cs);
@@ -6891,6 +6892,7 @@ static void x86_cpu_get_crash_info_qom(Object *obj, Visitor *v,
                                      errp);
     qapi_free_GuestPanicInformation(panic_info);
 }
+#endif /* !CONFIG_USER_ONLY */
 
 static void x86_cpu_initfn(Object *obj)
 {
@@ -6937,8 +6939,10 @@ static void x86_cpu_initfn(Object *obj)
                         x86_cpu_get_unavailable_features,
                         NULL, NULL, NULL, &error_abort);
 
+#if !defined(CONFIG_USER_ONLY)
     object_property_add(obj, "crash-information", "GuestPanicInformation",
                         x86_cpu_get_crash_info_qom, NULL, NULL, NULL, NULL);
+#endif
 
     for (w = 0; w < FEATURE_WORDS; w++) {
         int bitnr;
@@ -7251,7 +7255,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
     cc->cpu_exec_interrupt = x86_cpu_exec_interrupt;
 #endif
     cc->dump_state = x86_cpu_dump_state;
-    cc->get_crash_info = x86_cpu_get_crash_info;
     cc->set_pc = x86_cpu_set_pc;
     cc->synchronize_from_tb = x86_cpu_synchronize_from_tb;
     cc->gdb_read_register = x86_cpu_gdb_read_register;
@@ -7262,6 +7265,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
     cc->asidx_from_attrs = x86_asidx_from_attrs;
     cc->get_memory_mapping = x86_cpu_get_memory_mapping;
     cc->get_phys_page_attrs_debug = x86_cpu_get_phys_page_attrs_debug;
+    cc->get_crash_info = x86_cpu_get_crash_info;
     cc->write_elf64_note = x86_cpu_write_elf64_note;
     cc->write_elf64_qemunote = x86_cpu_write_elf64_qemunote;
     cc->write_elf32_note = x86_cpu_write_elf32_note;
-- 
2.21.3



WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,
	"Richard Henderson" <rth@twiddle.net>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH v3 10/12] target/i386: Restrict CpuClass::get_crash_info() to system-mode
Date: Mon,  4 May 2020 17:29:20 +0200	[thread overview]
Message-ID: <20200504152922.21365-11-philmd@redhat.com> (raw)
In-Reply-To: <20200504152922.21365-1-philmd@redhat.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 target/i386/cpu.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 9c256ab159..eec1ac7cea 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6848,6 +6848,7 @@ static void x86_cpu_register_feature_bit_props(X86CPU *cpu,
     x86_cpu_register_bit_prop(cpu, name, w, bitnr);
 }
 
+#if !defined(CONFIG_USER_ONLY)
 static GuestPanicInformation *x86_cpu_get_crash_info(CPUState *cs)
 {
     X86CPU *cpu = X86_CPU(cs);
@@ -6891,6 +6892,7 @@ static void x86_cpu_get_crash_info_qom(Object *obj, Visitor *v,
                                      errp);
     qapi_free_GuestPanicInformation(panic_info);
 }
+#endif /* !CONFIG_USER_ONLY */
 
 static void x86_cpu_initfn(Object *obj)
 {
@@ -6937,8 +6939,10 @@ static void x86_cpu_initfn(Object *obj)
                         x86_cpu_get_unavailable_features,
                         NULL, NULL, NULL, &error_abort);
 
+#if !defined(CONFIG_USER_ONLY)
     object_property_add(obj, "crash-information", "GuestPanicInformation",
                         x86_cpu_get_crash_info_qom, NULL, NULL, NULL, NULL);
+#endif
 
     for (w = 0; w < FEATURE_WORDS; w++) {
         int bitnr;
@@ -7251,7 +7255,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
     cc->cpu_exec_interrupt = x86_cpu_exec_interrupt;
 #endif
     cc->dump_state = x86_cpu_dump_state;
-    cc->get_crash_info = x86_cpu_get_crash_info;
     cc->set_pc = x86_cpu_set_pc;
     cc->synchronize_from_tb = x86_cpu_synchronize_from_tb;
     cc->gdb_read_register = x86_cpu_gdb_read_register;
@@ -7262,6 +7265,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
     cc->asidx_from_attrs = x86_asidx_from_attrs;
     cc->get_memory_mapping = x86_cpu_get_memory_mapping;
     cc->get_phys_page_attrs_debug = x86_cpu_get_phys_page_attrs_debug;
+    cc->get_crash_info = x86_cpu_get_crash_info;
     cc->write_elf64_note = x86_cpu_write_elf64_note;
     cc->write_elf64_qemunote = x86_cpu_write_elf64_qemunote;
     cc->write_elf32_note = x86_cpu_write_elf32_note;
-- 
2.21.3



  parent reply	other threads:[~2020-05-04 15:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 15:29 [PATCH v3 00/12] user-mode: Prune build dependencies (part 1) Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 01/12] Makefile: Only build virtiofsd if system-mode is enabled Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-18 12:14   ` Dr. David Alan Gilbert
2020-05-18 12:14     ` Dr. David Alan Gilbert
2020-05-04 15:29 ` [PATCH v3 02/12] configure: Avoid building TCG when not needed Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:40   ` Alistair Francis
2020-05-04 15:40     ` Alistair Francis
2020-05-04 15:29 ` [PATCH v3 03/12] tests/Makefile: Only display TCG-related tests when TCG is available Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 04/12] tests/Makefile: Restrict some softmmu-only tests Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 05/12] util/Makefile: Reduce the user-mode object list Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 06/12] stubs/Makefile: " Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 07/12] target/riscv/cpu: Restrict CPU migration to system-mode Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 08/12] exec: Assert CPU migration is not used on user-only build Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:41   ` Alistair Francis
2020-05-04 15:41     ` Alistair Francis
2020-05-04 15:29 ` [PATCH v3 09/12] arch_init: Remove unused 'qapi-commands-misc.h' include Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-04 15:29 ` Philippe Mathieu-Daudé [this message]
2020-05-04 15:29   ` [PATCH v3 10/12] target/i386: Restrict CpuClass::get_crash_info() to system-mode Philippe Mathieu-Daudé
2020-05-04 15:29 ` [PATCH v3 11/12] target/s390x: " Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-05 12:05   ` Cornelia Huck
2020-05-05 12:05     ` Cornelia Huck
2020-05-04 15:29 ` [PATCH v3 12/12] hw/core: " Philippe Mathieu-Daudé
2020-05-04 15:29   ` Philippe Mathieu-Daudé
2020-05-05  8:32 ` [PATCH v3 00/12] user-mode: Prune build dependencies (part 1) no-reply
2020-05-05  8:32   ` no-reply
2020-05-05  8:33 ` Laurent Vivier
2020-05-05  8:33   ` Laurent Vivier
2020-05-08 16:24   ` Philippe Mathieu-Daudé
2020-05-08 16:24     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200504152922.21365-11-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=rth@twiddle.net \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.