* [PATCH] Add support for Vinga Twizzle J116 Silead touchscreen
@ 2020-05-04 16:45 Andrew Dunai
2020-05-04 18:20 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Dunai @ 2020-05-04 16:45 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Dunai
---
drivers/platform/x86/touchscreen_dmi.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
index 93177e6e5..a3ab19ab0 100644
--- a/drivers/platform/x86/touchscreen_dmi.c
+++ b/drivers/platform/x86/touchscreen_dmi.c
@@ -640,6 +640,20 @@ static const struct ts_dmi_data trekstor_surftab_wintron70_data = {
.properties = trekstor_surftab_wintron70_props,
};
+static const struct property_entry vinga_twizzle_j116_props[] = {
+ PROPERTY_ENTRY_U32("touchscreen-size-x", 1920),
+ PROPERTY_ENTRY_U32("touchscreen-size-y", 1280),
+ PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-vinga-twizzle_j116.fw"),
+ PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+ PROPERTY_ENTRY_BOOL("silead,home-button"),
+ { }
+};
+
+static const struct ts_dmi_data vinga_twizzle_j116_data = {
+ .acpi_name = "MSSL1680:00",
+ .properties = vinga_twizzle_j116_props,
+};
+
/* NOTE: Please keep this table sorted alphabetically */
static const struct dmi_system_id touchscreen_dmi_table[] = {
{
@@ -1054,6 +1068,13 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "Y8W81"),
},
},
+ {
+ /* Vinga Twizzle J116 */
+ .driver_data = (void *)&vinga_twizzle_j116_data,
+ .matches = {
+ DMI_MATCH(DMI_PRODUCT_NAME, "VINGA Twizzle J116"),
+ },
+ },
{ },
};
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Add support for Vinga Twizzle J116 Silead touchscreen
2020-05-04 16:45 [PATCH] Add support for Vinga Twizzle J116 Silead touchscreen Andrew Dunai
@ 2020-05-04 18:20 ` Randy Dunlap
2020-05-05 8:38 ` Andy Shevchenko
2020-05-05 9:01 ` Hans de Goede
0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2020-05-04 18:20 UTC (permalink / raw)
To: Andrew Dunai, linux-kernel, Platform Driver; +Cc: linux-input, Hans de Goede
Hi,
Usually you need to send patches to a maintainer who could then
merge/apply them.
On 5/4/20 9:45 AM, Andrew Dunai wrote:
> ---
> drivers/platform/x86/touchscreen_dmi.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index 93177e6e5..a3ab19ab0 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -640,6 +640,20 @@ static const struct ts_dmi_data trekstor_surftab_wintron70_data = {
> .properties = trekstor_surftab_wintron70_props,
> };
>
> +static const struct property_entry vinga_twizzle_j116_props[] = {
> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1920),
> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1280),
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-vinga-twizzle_j116.fw"),
> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
> + PROPERTY_ENTRY_BOOL("silead,home-button"),
> + { }
> +};
> +
> +static const struct ts_dmi_data vinga_twizzle_j116_data = {
> + .acpi_name = "MSSL1680:00",
> + .properties = vinga_twizzle_j116_props,
> +};
> +
> /* NOTE: Please keep this table sorted alphabetically */
> static const struct dmi_system_id touchscreen_dmi_table[] = {
> {
> @@ -1054,6 +1068,13 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "Y8W81"),
> },
> },
> + {
> + /* Vinga Twizzle J116 */
> + .driver_data = (void *)&vinga_twizzle_j116_data,
> + .matches = {
> + DMI_MATCH(DMI_PRODUCT_NAME, "VINGA Twizzle J116"),
> + },
> + },
> { },
> };
>
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add support for Vinga Twizzle J116 Silead touchscreen
2020-05-04 18:20 ` Randy Dunlap
@ 2020-05-05 8:38 ` Andy Shevchenko
2020-05-05 9:01 ` Hans de Goede
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-05 8:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: Andrew Dunai, Linux Kernel Mailing List, Platform Driver,
linux-input, Hans de Goede
On Mon, May 4, 2020 at 9:21 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> Usually you need to send patches to a maintainer who could then
> merge/apply them.
>
Thank you, Randy.
Andrew, indeed, you have to send this to platform-driver-x86@ and its
maintainers along with driver maintainer (You may use
get_maintainer.pl script under scripts/ folder).
Don't be in rush now of resending, we will wait what Hans thinks about
the patch.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add support for Vinga Twizzle J116 Silead touchscreen
2020-05-04 18:20 ` Randy Dunlap
2020-05-05 8:38 ` Andy Shevchenko
@ 2020-05-05 9:01 ` Hans de Goede
2020-05-05 10:55 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Hans de Goede @ 2020-05-05 9:01 UTC (permalink / raw)
To: Randy Dunlap, Andrew Dunai, linux-kernel, Platform Driver; +Cc: linux-input
Hi,
On 5/4/20 8:20 PM, Randy Dunlap wrote:
> Hi,
>
> Usually you need to send patches to a maintainer who could then
> merge/apply them.
From a code point-of-view this looks good to me.
Andrew, if you can resend this to the proper folks (including me)
with a proper Signed-off-by (*), then this should be ready for merging.
Regards,
Hans
*) that might have already been there, but it wasn't present in
the part quoted by Randy
> On 5/4/20 9:45 AM, Andrew Dunai wrote:
>> ---
>> drivers/platform/x86/touchscreen_dmi.c | 21 +++++++++++++++++++++
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
>> index 93177e6e5..a3ab19ab0 100644
>> --- a/drivers/platform/x86/touchscreen_dmi.c
>> +++ b/drivers/platform/x86/touchscreen_dmi.c
>> @@ -640,6 +640,20 @@ static const struct ts_dmi_data trekstor_surftab_wintron70_data = {
>> .properties = trekstor_surftab_wintron70_props,
>> };
>>
>> +static const struct property_entry vinga_twizzle_j116_props[] = {
>> + PROPERTY_ENTRY_U32("touchscreen-size-x", 1920),
>> + PROPERTY_ENTRY_U32("touchscreen-size-y", 1280),
>> + PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-vinga-twizzle_j116.fw"),
>> + PROPERTY_ENTRY_U32("silead,max-fingers", 10),
>> + PROPERTY_ENTRY_BOOL("silead,home-button"),
>> + { }
>> +};
>> +
>> +static const struct ts_dmi_data vinga_twizzle_j116_data = {
>> + .acpi_name = "MSSL1680:00",
>> + .properties = vinga_twizzle_j116_props,
>> +};
>> +
>> /* NOTE: Please keep this table sorted alphabetically */
>> static const struct dmi_system_id touchscreen_dmi_table[] = {
>> {
>> @@ -1054,6 +1068,13 @@ static const struct dmi_system_id touchscreen_dmi_table[] = {
>> DMI_MATCH(DMI_PRODUCT_NAME, "Y8W81"),
>> },
>> },
>> + {
>> + /* Vinga Twizzle J116 */
>> + .driver_data = (void *)&vinga_twizzle_j116_data,
>> + .matches = {
>> + DMI_MATCH(DMI_PRODUCT_NAME, "VINGA Twizzle J116"),
>> + },
>> + },
>> { },
>> };
>>
>>
>
> thanks.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Add support for Vinga Twizzle J116 Silead touchscreen
2020-05-05 9:01 ` Hans de Goede
@ 2020-05-05 10:55 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-05 10:55 UTC (permalink / raw)
To: Hans de Goede
Cc: Randy Dunlap, Andrew Dunai, Linux Kernel Mailing List,
Platform Driver, linux-input
On Tue, May 5, 2020 at 12:02 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 5/4/20 8:20 PM, Randy Dunlap wrote:
> > Usually you need to send patches to a maintainer who could then
> > merge/apply them.
>
> From a code point-of-view this looks good to me.
>
> Andrew, if you can resend this to the proper folks (including me)
> with a proper Signed-off-by (*), then this should be ready for merging.
>
> Regards,
>
> Hans
>
>
> *) that might have already been there, but it wasn't present in
> the part quoted by Randy
Luckily I see the original message. There is neither Sob nor commit
message. They must to be present.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-05 10:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 16:45 [PATCH] Add support for Vinga Twizzle J116 Silead touchscreen Andrew Dunai
2020-05-04 18:20 ` Randy Dunlap
2020-05-05 8:38 ` Andy Shevchenko
2020-05-05 9:01 ` Hans de Goede
2020-05-05 10:55 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.