* [PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c
@ 2020-05-05 7:43 Jason Yan
2020-05-05 18:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-05-05 7:43 UTC (permalink / raw)
To: shshaikh, manishc, GR-Linux-NIC-Dev, davem, netdev, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1585:3-25:
WARNING: Assignment of 0/1 to bool variable
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1588:3-25:
WARNING: Assignment of 0/1 to bool variable
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c
index f7c2f32237cb..7adbb03cb931 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c
@@ -1582,10 +1582,10 @@ void qlcnic_sriov_vf_set_multi(struct net_device *netdev)
if (mode == VPORT_MISS_MODE_ACCEPT_ALL &&
!adapter->fdb_mac_learn) {
qlcnic_alloc_lb_filters_mem(adapter);
- adapter->drv_mac_learn = 1;
+ adapter->drv_mac_learn = true;
adapter->rx_mac_learn = true;
} else {
- adapter->drv_mac_learn = 0;
+ adapter->drv_mac_learn = false;
adapter->rx_mac_learn = false;
}
}
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c
2020-05-05 7:43 [PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c Jason Yan
@ 2020-05-05 18:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-05 18:39 UTC (permalink / raw)
To: yanaijie; +Cc: shshaikh, manishc, GR-Linux-NIC-Dev, netdev, linux-kernel
From: Jason Yan <yanaijie@huawei.com>
Date: Tue, 5 May 2020 15:43:49 +0800
> Fix the following coccicheck warning:
>
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1585:3-25:
> WARNING: Assignment of 0/1 to bool variable
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1588:3-25:
> WARNING: Assignment of 0/1 to bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-05 18:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 7:43 [PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c Jason Yan
2020-05-05 18:39 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.