* [PATCH net-next] net: agere: use true,false for bool variable
@ 2020-05-05 7:45 Jason Yan
2020-05-05 8:18 ` Mark Einon
2020-05-05 18:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-05-05 7:45 UTC (permalink / raw)
To: mark.einon, davem, hkallweit1, netdev, linux-kernel; +Cc: Jason Yan
Fix the following coccicheck warning:
drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
0/1 to bool variable
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/ethernet/agere/et131x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c
index 1b19385ad8a9..865892c1f23f 100644
--- a/drivers/net/ethernet/agere/et131x.c
+++ b/drivers/net/ethernet/agere/et131x.c
@@ -714,11 +714,11 @@ static int et131x_init_eeprom(struct et131x_adapter *adapter)
* gather additional information that normally would
* come from the eeprom, like MAC Address
*/
- adapter->has_eeprom = 0;
+ adapter->has_eeprom = false;
return -EIO;
}
}
- adapter->has_eeprom = 1;
+ adapter->has_eeprom = true;
/* Read the EEPROM for information regarding LED behavior. Refer to
* et131x_xcvr_init() for its use.
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: agere: use true,false for bool variable
2020-05-05 7:45 [PATCH net-next] net: agere: use true,false for bool variable Jason Yan
@ 2020-05-05 8:18 ` Mark Einon
2020-05-05 18:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mark Einon @ 2020-05-05 8:18 UTC (permalink / raw)
To: Jason Yan, davem, hkallweit1, netdev, linux-kernel
On Tue, 2020-05-05 at 15:45 +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
> 0/1 to bool variable
> drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
> 0/1 to bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Acked-by: Mark Einon <mark.einon@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: agere: use true,false for bool variable
2020-05-05 7:45 [PATCH net-next] net: agere: use true,false for bool variable Jason Yan
2020-05-05 8:18 ` Mark Einon
@ 2020-05-05 18:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-05 18:41 UTC (permalink / raw)
To: yanaijie; +Cc: mark.einon, hkallweit1, netdev, linux-kernel
From: Jason Yan <yanaijie@huawei.com>
Date: Tue, 5 May 2020 15:45:56 +0800
> Fix the following coccicheck warning:
>
> drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
> 0/1 to bool variable
> drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
> 0/1 to bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-05 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 7:45 [PATCH net-next] net: agere: use true,false for bool variable Jason Yan
2020-05-05 8:18 ` Mark Einon
2020-05-05 18:41 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.