* Re: [GIT PULL] vhost: fixes
@ 2020-05-06 7:19 ` Michael S. Tsirkin
0 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2020-05-06 7:19 UTC (permalink / raw)
To: Justin He
Cc: stable, kvm, virtualization, netdev, linux-kernel, ldigby, n.b,
stefanha, Linus Torvalds
On Wed, May 06, 2020 at 03:28:47AM +0000, Justin He wrote:
> Hi Michael
>
> > -----Original Message-----
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Monday, May 4, 2020 8:16 PM
> > To: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He
> > <Justin.He@arm.com>; ldigby@redhat.com; mst@redhat.com; n.b@live.com;
> > stefanha@redhat.com
> > Subject: [GIT PULL] vhost: fixes
> >
> > The following changes since commit
> > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c:
> >
> > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700)
> >
> > are available in the Git repository at:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> >
> > for you to fetch changes up to
> > 0b841030625cde5f784dd62aec72d6a766faae70:
> >
> > vhost: vsock: kick send_pkt worker once device is started (2020-05-02
> > 10:28:21 -0400)
> >
> > ----------------------------------------------------------------
> > virtio: fixes
> >
> > A couple of bug fixes.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > ----------------------------------------------------------------
> > Jia He (1):
> > vhost: vsock: kick send_pkt worker once device is started
>
> Should this fix also be CC-ed to stable? Sorry I forgot to cc it to stable.
>
> --
> Cheers,
> Justin (Jia He)
Go ahead, though recently just including Fixes seems to be enough.
>
> >
> > Stefan Hajnoczi (1):
> > virtio-blk: handle block_device_operations callbacks after hot unplug
> >
> > drivers/block/virtio_blk.c | 86
> > +++++++++++++++++++++++++++++++++++++++++-----
> > drivers/vhost/vsock.c | 5 +++
> > 2 files changed, 83 insertions(+), 8 deletions(-)
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] vhost: fixes
2020-05-06 7:19 ` Michael S. Tsirkin
@ 2020-05-06 7:35 ` Greg KH
-1 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2020-05-06 7:35 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Justin He, stable, kvm, virtualization, netdev, linux-kernel,
ldigby, n.b, stefanha, Linus Torvalds
On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> On Wed, May 06, 2020 at 03:28:47AM +0000, Justin He wrote:
> > Hi Michael
> >
> > > -----Original Message-----
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Monday, May 4, 2020 8:16 PM
> > > To: Linus Torvalds <torvalds@linux-foundation.org>
> > > Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He
> > > <Justin.He@arm.com>; ldigby@redhat.com; mst@redhat.com; n.b@live.com;
> > > stefanha@redhat.com
> > > Subject: [GIT PULL] vhost: fixes
> > >
> > > The following changes since commit
> > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c:
> > >
> > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700)
> > >
> > > are available in the Git repository at:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> > >
> > > for you to fetch changes up to
> > > 0b841030625cde5f784dd62aec72d6a766faae70:
> > >
> > > vhost: vsock: kick send_pkt worker once device is started (2020-05-02
> > > 10:28:21 -0400)
> > >
> > > ----------------------------------------------------------------
> > > virtio: fixes
> > >
> > > A couple of bug fixes.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > > Jia He (1):
> > > vhost: vsock: kick send_pkt worker once device is started
> >
> > Should this fix also be CC-ed to stable? Sorry I forgot to cc it to stable.
> >
> > --
> > Cheers,
> > Justin (Jia He)
>
>
> Go ahead, though recently just including Fixes seems to be enough.
You are getting lucky if you only apply a "Fixes:" tag, as that is much
lower down our list of things to look at. We are forced to do that
because of subsystems and maintainers that do not use the cc: stable
tag, as has been documented for the patch 15+ years :(
So please be explicit if you know you want it merged to the stable
trees, otherwise it is not a guarantee at all if you only use "fixes:".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] vhost: fixes
@ 2020-05-06 7:35 ` Greg KH
0 siblings, 0 replies; 13+ messages in thread
From: Greg KH @ 2020-05-06 7:35 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: n.b, Justin He, kvm, netdev, linux-kernel, stable,
virtualization, ldigby, stefanha, Linus Torvalds
On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> On Wed, May 06, 2020 at 03:28:47AM +0000, Justin He wrote:
> > Hi Michael
> >
> > > -----Original Message-----
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Monday, May 4, 2020 8:16 PM
> > > To: Linus Torvalds <torvalds@linux-foundation.org>
> > > Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He
> > > <Justin.He@arm.com>; ldigby@redhat.com; mst@redhat.com; n.b@live.com;
> > > stefanha@redhat.com
> > > Subject: [GIT PULL] vhost: fixes
> > >
> > > The following changes since commit
> > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c:
> > >
> > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700)
> > >
> > > are available in the Git repository at:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> > >
> > > for you to fetch changes up to
> > > 0b841030625cde5f784dd62aec72d6a766faae70:
> > >
> > > vhost: vsock: kick send_pkt worker once device is started (2020-05-02
> > > 10:28:21 -0400)
> > >
> > > ----------------------------------------------------------------
> > > virtio: fixes
> > >
> > > A couple of bug fixes.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > > Jia He (1):
> > > vhost: vsock: kick send_pkt worker once device is started
> >
> > Should this fix also be CC-ed to stable? Sorry I forgot to cc it to stable.
> >
> > --
> > Cheers,
> > Justin (Jia He)
>
>
> Go ahead, though recently just including Fixes seems to be enough.
You are getting lucky if you only apply a "Fixes:" tag, as that is much
lower down our list of things to look at. We are forced to do that
because of subsystems and maintainers that do not use the cc: stable
tag, as has been documented for the patch 15+ years :(
So please be explicit if you know you want it merged to the stable
trees, otherwise it is not a guarantee at all if you only use "fixes:".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] vhost: fixes
2020-05-06 7:19 ` Michael S. Tsirkin
@ 2020-05-06 9:25 ` Stefano Garzarella
-1 siblings, 0 replies; 13+ messages in thread
From: Stefano Garzarella @ 2020-05-06 9:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Greg KH
Cc: Justin He, stable, kvm, virtualization, netdev, linux-kernel,
ldigby, n.b, stefanha, Linus Torvalds
On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> On Wed, May 06, 2020 at 03:28:47AM +0000, Justin He wrote:
> > Hi Michael
> >
> > > -----Original Message-----
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Monday, May 4, 2020 8:16 PM
> > > To: Linus Torvalds <torvalds@linux-foundation.org>
> > > Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He
> > > <Justin.He@arm.com>; ldigby@redhat.com; mst@redhat.com; n.b@live.com;
> > > stefanha@redhat.com
> > > Subject: [GIT PULL] vhost: fixes
> > >
> > > The following changes since commit
> > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c:
> > >
> > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700)
> > >
> > > are available in the Git repository at:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> > >
> > > for you to fetch changes up to
> > > 0b841030625cde5f784dd62aec72d6a766faae70:
> > >
> > > vhost: vsock: kick send_pkt worker once device is started (2020-05-02
> > > 10:28:21 -0400)
> > >
> > > ----------------------------------------------------------------
> > > virtio: fixes
> > >
> > > A couple of bug fixes.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > > Jia He (1):
> > > vhost: vsock: kick send_pkt worker once device is started
> >
> > Should this fix also be CC-ed to stable? Sorry I forgot to cc it to stable.
> >
> > --
> > Cheers,
> > Justin (Jia He)
>
>
> Go ahead, though recently just including Fixes seems to be enough.
>
The following patch Justin refers to does not contain the "Fixes:" tag:
0b841030625c vhost: vsock: kick send_pkt worker once device is started
I think we should merge it on stable branches, so if needed, I can backport
and send it.
Stefano
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] vhost: fixes
@ 2020-05-06 9:25 ` Stefano Garzarella
0 siblings, 0 replies; 13+ messages in thread
From: Stefano Garzarella @ 2020-05-06 9:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Greg KH
Cc: Justin He, stable, kvm, virtualization, netdev, linux-kernel,
ldigby, n.b, stefanha, Linus Torvalds
On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> On Wed, May 06, 2020 at 03:28:47AM +0000, Justin He wrote:
> > Hi Michael
> >
> > > -----Original Message-----
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Monday, May 4, 2020 8:16 PM
> > > To: Linus Torvalds <torvalds@linux-foundation.org>
> > > Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He
> > > <Justin.He@arm.com>; ldigby@redhat.com; mst@redhat.com; n.b@live.com;
> > > stefanha@redhat.com
> > > Subject: [GIT PULL] vhost: fixes
> > >
> > > The following changes since commit
> > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c:
> > >
> > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700)
> > >
> > > are available in the Git repository at:
> > >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> > >
> > > for you to fetch changes up to
> > > 0b841030625cde5f784dd62aec72d6a766faae70:
> > >
> > > vhost: vsock: kick send_pkt worker once device is started (2020-05-02
> > > 10:28:21 -0400)
> > >
> > > ----------------------------------------------------------------
> > > virtio: fixes
> > >
> > > A couple of bug fixes.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >
> > > ----------------------------------------------------------------
> > > Jia He (1):
> > > vhost: vsock: kick send_pkt worker once device is started
> >
> > Should this fix also be CC-ed to stable? Sorry I forgot to cc it to stable.
> >
> > --
> > Cheers,
> > Justin (Jia He)
>
>
> Go ahead, though recently just including Fixes seems to be enough.
>
The following patch Justin refers to does not contain the "Fixes:" tag:
0b841030625c vhost: vsock: kick send_pkt worker once device is started
I think we should merge it on stable branches, so if needed, I can backport
and send it.
Stefano
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] vhost: fixes
2020-05-06 9:25 ` Stefano Garzarella
@ 2020-05-06 9:39 ` Michael S. Tsirkin
-1 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2020-05-06 9:39 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Greg KH, Justin He, stable, kvm, virtualization, netdev,
linux-kernel, ldigby, n.b, stefanha, Linus Torvalds
On Wed, May 06, 2020 at 11:25:46AM +0200, Stefano Garzarella wrote:
> On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> > On Wed, May 06, 2020 at 03:28:47AM +0000, Justin He wrote:
> > > Hi Michael
> > >
> > > > -----Original Message-----
> > > > From: Michael S. Tsirkin <mst@redhat.com>
> > > > Sent: Monday, May 4, 2020 8:16 PM
> > > > To: Linus Torvalds <torvalds@linux-foundation.org>
> > > > Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He
> > > > <Justin.He@arm.com>; ldigby@redhat.com; mst@redhat.com; n.b@live.com;
> > > > stefanha@redhat.com
> > > > Subject: [GIT PULL] vhost: fixes
> > > >
> > > > The following changes since commit
> > > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c:
> > > >
> > > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> > > >
> > > > for you to fetch changes up to
> > > > 0b841030625cde5f784dd62aec72d6a766faae70:
> > > >
> > > > vhost: vsock: kick send_pkt worker once device is started (2020-05-02
> > > > 10:28:21 -0400)
> > > >
> > > > ----------------------------------------------------------------
> > > > virtio: fixes
> > > >
> > > > A couple of bug fixes.
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > >
> > > > ----------------------------------------------------------------
> > > > Jia He (1):
> > > > vhost: vsock: kick send_pkt worker once device is started
> > >
> > > Should this fix also be CC-ed to stable? Sorry I forgot to cc it to stable.
> > >
> > > --
> > > Cheers,
> > > Justin (Jia He)
> >
> >
> > Go ahead, though recently just including Fixes seems to be enough.
> >
>
> The following patch Justin refers to does not contain the "Fixes:" tag:
>
> 0b841030625c vhost: vsock: kick send_pkt worker once device is started
>
>
> I think we should merge it on stable branches, so if needed, I can backport
> and send it.
>
> Stefano
Go ahead.
--
MST
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [GIT PULL] vhost: fixes
@ 2020-05-06 9:39 ` Michael S. Tsirkin
0 siblings, 0 replies; 13+ messages in thread
From: Michael S. Tsirkin @ 2020-05-06 9:39 UTC (permalink / raw)
To: Stefano Garzarella
Cc: Greg KH, Justin He, stable, kvm, virtualization, netdev,
linux-kernel, ldigby, n.b, stefanha, Linus Torvalds
On Wed, May 06, 2020 at 11:25:46AM +0200, Stefano Garzarella wrote:
> On Wed, May 06, 2020 at 03:19:55AM -0400, Michael S. Tsirkin wrote:
> > On Wed, May 06, 2020 at 03:28:47AM +0000, Justin He wrote:
> > > Hi Michael
> > >
> > > > -----Original Message-----
> > > > From: Michael S. Tsirkin <mst@redhat.com>
> > > > Sent: Monday, May 4, 2020 8:16 PM
> > > > To: Linus Torvalds <torvalds@linux-foundation.org>
> > > > Cc: kvm@vger.kernel.org; virtualization@lists.linux-foundation.org;
> > > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He
> > > > <Justin.He@arm.com>; ldigby@redhat.com; mst@redhat.com; n.b@live.com;
> > > > stefanha@redhat.com
> > > > Subject: [GIT PULL] vhost: fixes
> > > >
> > > > The following changes since commit
> > > > 6a8b55ed4056ea5559ebe4f6a4b247f627870d4c:
> > > >
> > > > Linux 5.7-rc3 (2020-04-26 13:51:02 -0700)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
> > > >
> > > > for you to fetch changes up to
> > > > 0b841030625cde5f784dd62aec72d6a766faae70:
> > > >
> > > > vhost: vsock: kick send_pkt worker once device is started (2020-05-02
> > > > 10:28:21 -0400)
> > > >
> > > > ----------------------------------------------------------------
> > > > virtio: fixes
> > > >
> > > > A couple of bug fixes.
> > > >
> > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > >
> > > > ----------------------------------------------------------------
> > > > Jia He (1):
> > > > vhost: vsock: kick send_pkt worker once device is started
> > >
> > > Should this fix also be CC-ed to stable? Sorry I forgot to cc it to stable.
> > >
> > > --
> > > Cheers,
> > > Justin (Jia He)
> >
> >
> > Go ahead, though recently just including Fixes seems to be enough.
> >
>
> The following patch Justin refers to does not contain the "Fixes:" tag:
>
> 0b841030625c vhost: vsock: kick send_pkt worker once device is started
>
>
> I think we should merge it on stable branches, so if needed, I can backport
> and send it.
>
> Stefano
Go ahead.
--
MST
^ permalink raw reply [flat|nested] 13+ messages in thread