From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Vishal Sagar <vishal.sagar@xilinx.com> Cc: Hyun Kwon <hyunk@xilinx.com>, mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, Michal Simek <michals@xilinx.com>, linux-media@vger.kernel.org, devicetree@vger.kernel.org, hans.verkuil@cisco.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dinesh Kumar <dineshk@xilinx.com>, Sandip Kothari <sandipk@xilinx.com>, Joe Perches <joe@perches.com> Subject: Re: [PATCH v2 1/2] media: dt-bindings: media: xilinx: Add Xilinx UHD-SDI Receiver Subsystem Date: Wed, 6 May 2020 16:02:25 +0300 [thread overview] Message-ID: <20200506130225.GD5946@pendragon.ideasonboard.com> (raw) In-Reply-To: <20200429141705.18755-2-vishal.sagar@xilinx.com> Hi Vishal, Thank you for the patch. On Wed, Apr 29, 2020 at 07:47:03PM +0530, Vishal Sagar wrote: > Add bindings documentation for Xilinx UHD-SDI Receiver Subsystem. > > The Xilinx UHD-SDI Receiver Subsystem consists of SMPTE UHD-SDI (RX) IP > core, an SDI RX to Video Bridge IP core to convert SDI video to native > video and a Video In to AXI4-Stream IP core to convert native video to > AXI4-Stream. > > Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com> > --- > v2 > - Removed references to xlnx,video* > - Fixed as per Sakari Ailus and Rob Herring's comments > - Converted to yaml format > > .../bindings/media/xilinx/xlnx,sdirxss.yaml | 132 ++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > > diff --git a/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml b/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > new file mode 100644 > index 000000000000..9133ad19df55 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/xilinx/xlnx,sdirxss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > + > +title: Xilinx SMPTE UHD-SDI Receiver Subsystem > + > +maintainers: > + - Vishal Sagar <vishal.sagar@xilinx.com> > + > +description: | > + The SMPTE UHD-SDI Receiver (RX) Subsystem allows you to quickly create systems > + based on SMPTE SDI protocols. It receives unaligned native SDI streams from > + the SDI GT PHY and outputs an AXI4-Stream video stream, native video, or > + native SDI using Xilinx transceivers as the physical layer. > + > + The subsystem consists of > + 1 - SMPTE UHD-SDI Rx > + 2 - SDI Rx to Native Video Bridge > + 3 - Video In to AXI4-Stream Bridge > + > + The subsystem can capture SDI streams in upto 12G mode 8 data streams and output s/upto/up to/ > + a dual pixel per clock RGB/YUV444,422/420 10/12 bits per component AXI4-Stream. > + > +properties: > + compatible: > + items: > + - enum: > + - xlnx,v-smpte-uhdsdi-rx-ss-2.0 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: List of clock specifiers > + items: > + - description: AXI4-Lite clock > + - description: SMPTE UHD-SDI Rx core clock > + - description: Video clock > + > + clock-names: > + items: > + - const: s_axi_aclk > + - const: sdi_rx_clk > + - const: video_out_clk > + > + xlnx,bpp: > + description: Bits per pixel supported. Can be 10 or 12 bits per pixel only. > + allOf: > + - $ref: "/schemas/types.yaml#/definitions/uint32" > + - enum: [10, 12] I don't see this as a design parameter in the documentation (pg290, v2.0). What does it correspond to ? All the BPC mentions in the documentation always state that 10-bit is the only supported value. > + > + xlnx,line-rate: > + description: | > + The maximum mode supported by the design. Possible values are as below > + 12G_SDI_8DS - 12G mode with 8 data streams > + 6G_SDI - 6G mode > + 3G_SDI - 3G mode > + enum: > + - 12G_SDI_8DS > + - 6G_SDI > + - 3G_SDI How about making this an integer property, with #define in include/dt-bindings/media/xilinx-sdi.h ? As far as I understand, the SDI TX subsystem has the same parameter, so the #define could be shared between the two. > + > + xlnx,include-edh: > + type: boolean > + description: | > + This is present when the Error Detection and Handling processor is > + enabled in design. > + > + ports: > + type: object > + description: | > + Generally the SDI port is connected to a device like SDI Broadcast camera > + which is independently controlled. Hence port@0 is a source port which can be > + connected to downstream IP which can work with AXI4 Stream data. We should still have an input port. It can be connected to a DT node for a physical SDI connector, or any other component in the platform (I expect the former to be the common case). There are DT bindings for connectors in Documentation/devicetree/bindings/display/connector/, we should add one for SDI. > + properties: > + port@0: > + type: object > + description: Source port > + properties: > + reg: > + const: 0 > + endpoint: > + type: object > + properties: > + remote-endpoint: true > + required: > + - remote-endpoint > + additionalProperties: false > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - xlnx,line-rate > + - xlnx,bpp > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + uhdsdirxss: v-smpte-uhdsdi-rxss@80000000 { > + compatible = "xlnx,v-smpte-uhdsdi-rx-ss-2.0"; > + interrupt-parent = <&gic>; > + interrupts = <0 89 4>; > + reg = <0x0 0x80000000 0x0 0x10000>; > + xlnx,include-edh; > + xlnx,line-rate = "12G_SDI_8DS"; > + clocks = <&clk_1>, <&si570_1>, <&clk_2>; > + clock-names = "s_axi_aclk", "sdi_rx_clk", "video_out_clk"; > + xlnx,bpp = <10>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + sdirx_out: endpoint { > + remote-endpoint = <&vcap_sdirx_in>; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Vishal Sagar <vishal.sagar@xilinx.com> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Dinesh Kumar <dineshk@xilinx.com>, Hyun Kwon <hyunk@xilinx.com>, Sandip Kothari <sandipk@xilinx.com>, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Michal Simek <michals@xilinx.com>, Joe Perches <joe@perches.com>, hans.verkuil@cisco.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2 1/2] media: dt-bindings: media: xilinx: Add Xilinx UHD-SDI Receiver Subsystem Date: Wed, 6 May 2020 16:02:25 +0300 [thread overview] Message-ID: <20200506130225.GD5946@pendragon.ideasonboard.com> (raw) In-Reply-To: <20200429141705.18755-2-vishal.sagar@xilinx.com> Hi Vishal, Thank you for the patch. On Wed, Apr 29, 2020 at 07:47:03PM +0530, Vishal Sagar wrote: > Add bindings documentation for Xilinx UHD-SDI Receiver Subsystem. > > The Xilinx UHD-SDI Receiver Subsystem consists of SMPTE UHD-SDI (RX) IP > core, an SDI RX to Video Bridge IP core to convert SDI video to native > video and a Video In to AXI4-Stream IP core to convert native video to > AXI4-Stream. > > Signed-off-by: Vishal Sagar <vishal.sagar@xilinx.com> > --- > v2 > - Removed references to xlnx,video* > - Fixed as per Sakari Ailus and Rob Herring's comments > - Converted to yaml format > > .../bindings/media/xilinx/xlnx,sdirxss.yaml | 132 ++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > > diff --git a/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml b/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > new file mode 100644 > index 000000000000..9133ad19df55 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/xilinx/xlnx,sdirxss.yaml > @@ -0,0 +1,132 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/xilinx/xlnx,sdirxss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > + > +title: Xilinx SMPTE UHD-SDI Receiver Subsystem > + > +maintainers: > + - Vishal Sagar <vishal.sagar@xilinx.com> > + > +description: | > + The SMPTE UHD-SDI Receiver (RX) Subsystem allows you to quickly create systems > + based on SMPTE SDI protocols. It receives unaligned native SDI streams from > + the SDI GT PHY and outputs an AXI4-Stream video stream, native video, or > + native SDI using Xilinx transceivers as the physical layer. > + > + The subsystem consists of > + 1 - SMPTE UHD-SDI Rx > + 2 - SDI Rx to Native Video Bridge > + 3 - Video In to AXI4-Stream Bridge > + > + The subsystem can capture SDI streams in upto 12G mode 8 data streams and output s/upto/up to/ > + a dual pixel per clock RGB/YUV444,422/420 10/12 bits per component AXI4-Stream. > + > +properties: > + compatible: > + items: > + - enum: > + - xlnx,v-smpte-uhdsdi-rx-ss-2.0 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + description: List of clock specifiers > + items: > + - description: AXI4-Lite clock > + - description: SMPTE UHD-SDI Rx core clock > + - description: Video clock > + > + clock-names: > + items: > + - const: s_axi_aclk > + - const: sdi_rx_clk > + - const: video_out_clk > + > + xlnx,bpp: > + description: Bits per pixel supported. Can be 10 or 12 bits per pixel only. > + allOf: > + - $ref: "/schemas/types.yaml#/definitions/uint32" > + - enum: [10, 12] I don't see this as a design parameter in the documentation (pg290, v2.0). What does it correspond to ? All the BPC mentions in the documentation always state that 10-bit is the only supported value. > + > + xlnx,line-rate: > + description: | > + The maximum mode supported by the design. Possible values are as below > + 12G_SDI_8DS - 12G mode with 8 data streams > + 6G_SDI - 6G mode > + 3G_SDI - 3G mode > + enum: > + - 12G_SDI_8DS > + - 6G_SDI > + - 3G_SDI How about making this an integer property, with #define in include/dt-bindings/media/xilinx-sdi.h ? As far as I understand, the SDI TX subsystem has the same parameter, so the #define could be shared between the two. > + > + xlnx,include-edh: > + type: boolean > + description: | > + This is present when the Error Detection and Handling processor is > + enabled in design. > + > + ports: > + type: object > + description: | > + Generally the SDI port is connected to a device like SDI Broadcast camera > + which is independently controlled. Hence port@0 is a source port which can be > + connected to downstream IP which can work with AXI4 Stream data. We should still have an input port. It can be connected to a DT node for a physical SDI connector, or any other component in the platform (I expect the former to be the common case). There are DT bindings for connectors in Documentation/devicetree/bindings/display/connector/, we should add one for SDI. > + properties: > + port@0: > + type: object > + description: Source port > + properties: > + reg: > + const: 0 > + endpoint: > + type: object > + properties: > + remote-endpoint: true > + required: > + - remote-endpoint > + additionalProperties: false > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - xlnx,line-rate > + - xlnx,bpp > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + uhdsdirxss: v-smpte-uhdsdi-rxss@80000000 { > + compatible = "xlnx,v-smpte-uhdsdi-rx-ss-2.0"; > + interrupt-parent = <&gic>; > + interrupts = <0 89 4>; > + reg = <0x0 0x80000000 0x0 0x10000>; > + xlnx,include-edh; > + xlnx,line-rate = "12G_SDI_8DS"; > + clocks = <&clk_1>, <&si570_1>, <&clk_2>; > + clock-names = "s_axi_aclk", "sdi_rx_clk", "video_out_clk"; > + xlnx,bpp = <10>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + sdirx_out: endpoint { > + remote-endpoint = <&vcap_sdirx_in>; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-06 13:02 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-29 14:17 [PATCH v2 0/2] Add support for Xilinx UHD-SDI Receiver subsystem Vishal Sagar 2020-04-29 14:17 ` Vishal Sagar 2020-04-29 14:17 ` [PATCH v2 1/2] media: dt-bindings: media: xilinx: Add Xilinx UHD-SDI Receiver Subsystem Vishal Sagar 2020-04-29 14:17 ` Vishal Sagar 2020-05-06 13:02 ` Laurent Pinchart [this message] 2020-05-06 13:02 ` Laurent Pinchart 2020-06-01 15:14 ` Vishal Sagar 2020-06-01 15:14 ` Vishal Sagar 2020-06-03 1:13 ` Laurent Pinchart 2020-06-03 1:13 ` Laurent Pinchart 2020-04-29 14:17 ` [PATCH v2 2/2] media: v4l: xilinx: Add Xilinx UHD-SDI Rx Subsystem driver Vishal Sagar 2020-04-29 14:17 ` Vishal Sagar 2020-05-06 9:54 ` Hans Verkuil 2020-05-06 9:54 ` Hans Verkuil 2020-06-01 14:41 ` Vishal Sagar 2020-06-01 14:44 ` Vishal Sagar 2020-06-01 14:59 ` Vishal Sagar 2020-06-02 10:44 ` Hans Verkuil 2020-06-02 10:44 ` Hans Verkuil 2020-06-09 15:01 ` Hans Verkuil 2020-06-09 15:01 ` Hans Verkuil 2020-05-06 15:11 ` Laurent Pinchart 2020-05-06 15:11 ` Laurent Pinchart 2020-06-09 18:23 ` Vishal Sagar 2020-06-16 23:13 ` Laurent Pinchart 2020-06-16 23:13 ` Laurent Pinchart 2020-05-06 18:42 ` Hyun Kwon 2020-05-06 18:42 ` Hyun Kwon 2020-06-09 18:23 ` Vishal Sagar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200506130225.GD5946@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=dineshk@xilinx.com \ --cc=hans.verkuil@cisco.com \ --cc=hyunk@xilinx.com \ --cc=joe@perches.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=michals@xilinx.com \ --cc=robh+dt@kernel.org \ --cc=sandipk@xilinx.com \ --cc=vishal.sagar@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.