[PATCH] [arm-autonomy] xenguest-manager: Wait longer for /dev/xvdaX creation

[PATCH] [arm-autonomy] xenguest-manager: Wait longer for /dev/xvdaX creation

[Diego Sueiro]

Implement a wait block of 20s with exit condition for checking
/dev/xvdaX creation.
For example, in cases where the rootfs is mounted via NFS, a longer
time is needed until the xvda device appears in the system.

Change-Id: I44cbcf2a43aeb476eae92d5b6d2cfd683e4bdf21
Issue-Id: SCM-929
Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
 .../recipes-extended/xenguest/files/xenguest-manager      | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
index b25eeb5..4777054 100755
--- a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
+++ b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
@@ -234,10 +234,17 @@ function xenguest_disk_init()
                 exit 1
             fi
 
-            # Sometimes it takes time to see the device
-            if [ ! -b /dev/xvda${part} ]; then
-                sleep 1
-            fi
+
+            # Loop for 20s to wait until /dev/xvdaX appears
+            i=0
+            while [ ! -b /dev/xvda${part} ]; do
+                ((i++))
+                if [[ "$i" == '40' ]]; then
+                    break;
+                fi
+                sleep 0.5
+            done
+
             if [ ! -b /dev/xvda${part} ]; then
                 echo "${PREF} Partition ${part} creation error"
                 xenguest_detach_disk
-- 
2.7.4

Re: [meta-arm] [PATCH] [arm-autonomy] xenguest-manager: Wait longer for /dev/xvdaX creation

[Bertrand Marquis]

> On 30 Apr 2020, at 14:29, Diego Sueiro via lists.yoctoproject.org <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> 
> Implement a wait block of 20s with exit condition for checking
> /dev/xvdaX creation.
> For example, in cases where the rootfs is mounted via NFS, a longer
> time is needed until the xvda device appears in the system.
> 
> Change-Id: I44cbcf2a43aeb476eae92d5b6d2cfd683e4bdf21
> Issue-Id: SCM-929
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>

Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

> ---
> .../recipes-extended/xenguest/files/xenguest-manager      | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
> index b25eeb5..4777054 100755
> --- a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
> +++ b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
> @@ -234,10 +234,17 @@ function xenguest_disk_init()
>                 exit 1
>             fi
> 
> -            # Sometimes it takes time to see the device
> -            if [ ! -b /dev/xvda${part} ]; then
> -                sleep 1
> -            fi
> +
> +            # Loop for 20s to wait until /dev/xvdaX appears
> +            i=0
> +            while [ ! -b /dev/xvda${part} ]; do
> +                ((i++))
> +                if [[ "$i" == '40' ]]; then
> +                    break;
> +                fi
> +                sleep 0.5
> +            done
> +
>             if [ ! -b /dev/xvda${part} ]; then
>                 echo "${PREF} Partition ${part} creation error"
>                 xenguest_detach_disk
> -- 
> 2.7.4
> 
> 

Re: [meta-arm] [PATCH] [arm-autonomy] xenguest-manager: Wait longer for /dev/xvdaX creation

[Jon Mason]

On Thu, Apr 30, 2020 at 02:25:57PM +0000, Bertrand Marquis wrote:
> 
> 
> > On 30 Apr 2020, at 14:29, Diego Sueiro via lists.yoctoproject.org <diego.sueiro=arm.com@lists.yoctoproject.org> wrote:
> > 
> > Implement a wait block of 20s with exit condition for checking
> > /dev/xvdaX creation.
> > For example, in cases where the rootfs is mounted via NFS, a longer
> > time is needed until the xvda device appears in the system.
> > 
> > Change-Id: I44cbcf2a43aeb476eae92d5b6d2cfd683e4bdf21
> > Issue-Id: SCM-929
> > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> 
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Pulled into the master branch.

Thanks,
Jon

> 
> > ---
> > .../recipes-extended/xenguest/files/xenguest-manager      | 15 +++++++++++----
> > 1 file changed, 11 insertions(+), 4 deletions(-)
> > 
> > diff --git a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
> > index b25eeb5..4777054 100755
> > --- a/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
> > +++ b/meta-arm-autonomy/recipes-extended/xenguest/files/xenguest-manager
> > @@ -234,10 +234,17 @@ function xenguest_disk_init()
> >                 exit 1
> >             fi
> > 
> > -            # Sometimes it takes time to see the device
> > -            if [ ! -b /dev/xvda${part} ]; then
> > -                sleep 1
> > -            fi
> > +
> > +            # Loop for 20s to wait until /dev/xvdaX appears
> > +            i=0
> > +            while [ ! -b /dev/xvda${part} ]; do
> > +                ((i++))
> > +                if [[ "$i" == '40' ]]; then
> > +                    break;
> > +                fi
> > +                sleep 0.5
> > +            done
> > +
> >             if [ ! -b /dev/xvda${part} ]; then
> >                 echo "${PREF} Partition ${part} creation error"
> >                 xenguest_detach_disk
> > -- 
> > 2.7.4
> > 
> > 
> 

>