All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [arm-autonomy] arm-autonomy-host-image-minimal: Abort on copy fail
@ 2020-05-07 11:17 Bertrand Marquis
  2020-05-08 13:06 ` [meta-arm] " Jon Mason
  0 siblings, 1 reply; 2+ messages in thread
From: Bertrand Marquis @ 2020-05-07 11:17 UTC (permalink / raw)
  To: meta-arm; +Cc: nd

From: Diego Sueiro <diego.sueiro@arm.com>

If the guest image copy fails we need to abort the do_image execution.

Change-Id: I3785a0828e271ed27eb7f9212804b5b9b39f79ac
Issue-Id: SCM-990
Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
 .../recipes-core/images/arm-autonomy-host-image-minimal.bb     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
index 3859f52..5b20fa0 100644
--- a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
+++ b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
@@ -112,7 +112,8 @@ python add_extern_guests () {
             # Add file extension if not there
             if not dstname.endswith('.xenguest'):
                 dstname += '.xenguest'
-            bb.utils.copyfile(path, guestdir + '/' + dstname)
+            if not bb.utils.copyfile(path, guestdir + '/' + dstname):
+                bb.fatal("Fail to copy Guest file " + path)
 }
 
 IMAGE_PREPROCESS_COMMAND += "add_extern_guests; "
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [meta-arm] [PATCH] [arm-autonomy] arm-autonomy-host-image-minimal: Abort on copy fail
  2020-05-07 11:17 [PATCH] [arm-autonomy] arm-autonomy-host-image-minimal: Abort on copy fail Bertrand Marquis
@ 2020-05-08 13:06 ` Jon Mason
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Mason @ 2020-05-08 13:06 UTC (permalink / raw)
  To: meta-arm

On Thu, May 07, 2020 at 12:17:22PM +0100, Bertrand Marquis wrote:
> From: Diego Sueiro <diego.sueiro@arm.com>
> 
> If the guest image copy fails we need to abort the do_image execution.
> 
> Change-Id: I3785a0828e271ed27eb7f9212804b5b9b39f79ac
> Issue-Id: SCM-990
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>

Pulled into the master branch.

Thanks,
Jon

> ---
>  .../recipes-core/images/arm-autonomy-host-image-minimal.bb     | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> index 3859f52..5b20fa0 100644
> --- a/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> +++ b/meta-arm-autonomy/recipes-core/images/arm-autonomy-host-image-minimal.bb
> @@ -112,7 +112,8 @@ python add_extern_guests () {
>              # Add file extension if not there
>              if not dstname.endswith('.xenguest'):
>                  dstname += '.xenguest'
> -            bb.utils.copyfile(path, guestdir + '/' + dstname)
> +            if not bb.utils.copyfile(path, guestdir + '/' + dstname):
> +                bb.fatal("Fail to copy Guest file " + path)
>  }
>  
>  IMAGE_PREPROCESS_COMMAND += "add_extern_guests; "
> -- 
> 2.17.1
> 

> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-08 13:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 11:17 [PATCH] [arm-autonomy] arm-autonomy-host-image-minimal: Abort on copy fail Bertrand Marquis
2020-05-08 13:06 ` [meta-arm] " Jon Mason

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.