All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/amdgpu: add raven1 part to the gfxoff quirk list
@ 2020-05-07 12:38 Tom St Denis
  2020-05-07 12:52 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Tom St Denis @ 2020-05-07 12:38 UTC (permalink / raw)
  To: amd-gfx; +Cc: Tom St Denis

On my raven1 system (rev c6) with VBIOS 113-RAVEN-114 GFXOFF is
not stable (resulting in large block tiling noise in some applications).

Disabling GFXOFF via the quirk list fixes the problems for me.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index fbd54d347d91..1573ac1f03b2 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -1233,6 +1233,8 @@ static const struct amdgpu_gfxoff_quirk amdgpu_gfxoff_quirk_list[] = {
 	{ 0x1002, 0x15dd, 0x1002, 0x15dd, 0xc8 },
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=207171 */
 	{ 0x1002, 0x15dd, 0x103c, 0x83e7, 0xd3 },
+	/* GFXOFF is unstable on C6 parts with a VBIOS 113-RAVEN-114 */
+	{ 0x1002, 0x15dd, 0x1002, 0x15dd, 0xc6 },
 	{ 0, 0, 0, 0, 0 },
 };
 
-- 
2.26.2

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd/amdgpu: add raven1 part to the gfxoff quirk list
  2020-05-07 12:38 [PATCH] drm/amd/amdgpu: add raven1 part to the gfxoff quirk list Tom St Denis
@ 2020-05-07 12:52 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-05-07 12:52 UTC (permalink / raw)
  To: Tom St Denis; +Cc: amd-gfx list

On Thu, May 7, 2020 at 8:38 AM Tom St Denis <tom.stdenis@amd.com> wrote:
>
> On my raven1 system (rev c6) with VBIOS 113-RAVEN-114 GFXOFF is
> not stable (resulting in large block tiling noise in some applications).
>
> Disabling GFXOFF via the quirk list fixes the problems for me.
>
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index fbd54d347d91..1573ac1f03b2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -1233,6 +1233,8 @@ static const struct amdgpu_gfxoff_quirk amdgpu_gfxoff_quirk_list[] = {
>         { 0x1002, 0x15dd, 0x1002, 0x15dd, 0xc8 },
>         /* https://bugzilla.kernel.org/show_bug.cgi?id=207171 */
>         { 0x1002, 0x15dd, 0x103c, 0x83e7, 0xd3 },
> +       /* GFXOFF is unstable on C6 parts with a VBIOS 113-RAVEN-114 */
> +       { 0x1002, 0x15dd, 0x1002, 0x15dd, 0xc6 },
>         { 0, 0, 0, 0, 0 },
>  };
>
> --
> 2.26.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-07 12:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 12:38 [PATCH] drm/amd/amdgpu: add raven1 part to the gfxoff quirk list Tom St Denis
2020-05-07 12:52 ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.