From: Steven Rostedt <rostedt@goodmis.org> To: Julia Lawall <Julia.Lawall@inria.fr> Cc: kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, Nic Volanschi <eugene.volanschi@inria.fr>, Masami Hiramatsu <mhiramat@kernel.org> Subject: Re: [PATCH] tracing/probe: reverse arguments to list_add Date: Thu, 7 May 2020 16:50:53 -0400 [thread overview] Message-ID: <20200507165053.291ba5ea@gandalf.local.home> (raw) In-Reply-To: <1588879808-24488-1-git-send-email-Julia.Lawall@inria.fr> On Thu, 7 May 2020 21:30:08 +0200 Julia Lawall <Julia.Lawall@inria.fr> wrote: > Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses > a trace_probe_event.probes object as the second argument of > list_for_each_entry, ie as a list head, while the list_for_each_entry > iterates over the list fields of the trace_probe structures, making > them the list elements. So, exchange the arguments on the list_add > call to put the list head in the second argument. > > Since both list_head structures were just initialized, this problem > did not cause any loss of information. > > Fixes: 60d53e2c3b75 ("tracing/probe: Split trace_event related data from trace_probe") > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Masami, Can you give a Reviewed-by to this? -- Steve > > --- > kernel/trace/trace_probe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index ab8b6436d53f..b8a928e925c7 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -1006,7 +1006,7 @@ int trace_probe_init(struct trace_probe *tp, const char *event, > INIT_LIST_HEAD(&tp->event->class.fields); > INIT_LIST_HEAD(&tp->event->probes); > INIT_LIST_HEAD(&tp->list); > - list_add(&tp->event->probes, &tp->list); > + list_add(&tp->list, &tp->event->probes); > > call = trace_probe_event_call(tp); > call->class = &tp->event->class;
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org> To: Julia Lawall <Julia.Lawall@inria.fr> Cc: kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, Nic Volanschi <eugene.volanschi@inria.fr>, Masami Hiramatsu <mhiramat@kernel.org> Subject: Re: [PATCH] tracing/probe: reverse arguments to list_add Date: Thu, 07 May 2020 20:50:53 +0000 [thread overview] Message-ID: <20200507165053.291ba5ea@gandalf.local.home> (raw) In-Reply-To: <1588879808-24488-1-git-send-email-Julia.Lawall@inria.fr> On Thu, 7 May 2020 21:30:08 +0200 Julia Lawall <Julia.Lawall@inria.fr> wrote: > Elsewhere in the file, the function trace_kprobe_has_same_kprobe uses > a trace_probe_event.probes object as the second argument of > list_for_each_entry, ie as a list head, while the list_for_each_entry > iterates over the list fields of the trace_probe structures, making > them the list elements. So, exchange the arguments on the list_add > call to put the list head in the second argument. > > Since both list_head structures were just initialized, this problem > did not cause any loss of information. > > Fixes: 60d53e2c3b75 ("tracing/probe: Split trace_event related data from trace_probe") > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Masami, Can you give a Reviewed-by to this? -- Steve > > --- > kernel/trace/trace_probe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c > index ab8b6436d53f..b8a928e925c7 100644 > --- a/kernel/trace/trace_probe.c > +++ b/kernel/trace/trace_probe.c > @@ -1006,7 +1006,7 @@ int trace_probe_init(struct trace_probe *tp, const char *event, > INIT_LIST_HEAD(&tp->event->class.fields); > INIT_LIST_HEAD(&tp->event->probes); > INIT_LIST_HEAD(&tp->list); > - list_add(&tp->event->probes, &tp->list); > + list_add(&tp->list, &tp->event->probes); > > call = trace_probe_event_call(tp); > call->class = &tp->event->class;
next prev parent reply other threads:[~2020-05-07 20:50 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-07 19:30 [PATCH] tracing/probe: reverse arguments to list_add Julia Lawall 2020-05-07 19:30 ` Julia Lawall 2020-05-07 20:50 ` Steven Rostedt [this message] 2020-05-07 20:50 ` Steven Rostedt 2020-05-07 20:52 ` Steven Rostedt 2020-05-07 20:52 ` Steven Rostedt 2020-05-07 20:53 ` Julia Lawall 2020-05-07 20:53 ` Julia Lawall 2020-05-07 23:57 ` Masami Hiramatsu 2020-05-07 23:57 ` Masami Hiramatsu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200507165053.291ba5ea@gandalf.local.home \ --to=rostedt@goodmis.org \ --cc=Julia.Lawall@inria.fr \ --cc=eugene.volanschi@inria.fr \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mhiramat@kernel.org \ --cc=mingo@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.