From: Daniel Vetter <daniel@ffwll.ch> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch>, ML dri-devel <dri-devel@lists.freedesktop.org>, Sean Paul <sean@poorly.run>, linux-arm-msm <linux-arm-msm@vger.kernel.org> Subject: Re: [PATCH 10/36] drm/gem: add _locked suffix to drm_object_put Date: Fri, 8 May 2020 13:25:19 +0200 [thread overview] Message-ID: <20200508112519.GI1383626@phenom.ffwll.local> (raw) In-Reply-To: <CACvgo53fa1R3gD8hCg+Ch2Tj0ZnDVScNXiZO5FbGfK_VbAP_nQ@mail.gmail.com> On Fri, May 08, 2020 at 12:00:40PM +0100, Emil Velikov wrote: > On Fri, 8 May 2020 at 07:40, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Thu, May 07, 2020 at 04:07:56PM +0100, Emil Velikov wrote: > > > From: Emil Velikov <emil.velikov@collabora.com> > > > > > > Vast majority of DRM (core and drivers) are struct_mutex free. > > > > > > As such we have only a handful of cases where the locked helper should > > > be used. Make that stand out a little bit better. > > > > > > Done via the following script: > > > > > > __from=drm_gem_object_put > > > __to=drm_gem_object_put_locked > > > > > > for __file in $(git grep --name-only --word-regexp $__from); do > > > sed -i "s/\<$__from\>/$__to/g" $__file; > > > done > > > > > > Cc: Rob Clark <robdclark@gmail.com> > > > Cc: Sean Paul <sean@poorly.run> > > > Cc: linux-arm-msm@vger.kernel.org > > > Signed-off-by: Emil Velikov <emil.velikov@collabora.com> > > > > Since > > > > commit 48e7f18392c66f9b69ebac11c54f1a2e033ced54 > > Author: Kristian H. Kristensen <hoegsberg@gmail.com> > > Date: Wed Mar 20 10:09:08 2019 -0700 > > > > drm/msm: Implement .gem_free_object_unlocked > > > > msm doesn't need the struct_mutex in the bo_put anymore, the only reason > > we had to use the _locked version here is historical accidents I think. > > > > I think you could convert these all to the _unlocked variant and then > > entirely drop the _locked version. > > > Did not check the msm driver closely, but it makes sense. Let's keep > that as follow-up series? > We're already at 36 patches, plus mixing mostly mechanical and locking > changes doesn't sound wise. My idea was to simply throw this patch out, and replace it by an msm patch to switch over to the unlocked variant. Well maybe then needs 2nd patch to throw the locked version out. So feels a bit a detour to touch msm twice, which is why I suggested to do the more direct route. But if you feel strongly I guess we can go this way and then follow up with converting msm to unlocked and throwing the _locked variant out for good too. -Daniel > > Once we have that we could move struct_mutex into each driver (at least > > for msm and i915) since it's purely internal, and then wrap it in an > > #ifdef CONFIG_DRM_LEGACY to gloriously sunset it all :-) > > > Indeed, we're nearly there. > > -Emil -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Emil Velikov <emil.l.velikov@gmail.com> Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>, Sean Paul <sean@poorly.run>, ML dri-devel <dri-devel@lists.freedesktop.org> Subject: Re: [PATCH 10/36] drm/gem: add _locked suffix to drm_object_put Date: Fri, 8 May 2020 13:25:19 +0200 [thread overview] Message-ID: <20200508112519.GI1383626@phenom.ffwll.local> (raw) In-Reply-To: <CACvgo53fa1R3gD8hCg+Ch2Tj0ZnDVScNXiZO5FbGfK_VbAP_nQ@mail.gmail.com> On Fri, May 08, 2020 at 12:00:40PM +0100, Emil Velikov wrote: > On Fri, 8 May 2020 at 07:40, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Thu, May 07, 2020 at 04:07:56PM +0100, Emil Velikov wrote: > > > From: Emil Velikov <emil.velikov@collabora.com> > > > > > > Vast majority of DRM (core and drivers) are struct_mutex free. > > > > > > As such we have only a handful of cases where the locked helper should > > > be used. Make that stand out a little bit better. > > > > > > Done via the following script: > > > > > > __from=drm_gem_object_put > > > __to=drm_gem_object_put_locked > > > > > > for __file in $(git grep --name-only --word-regexp $__from); do > > > sed -i "s/\<$__from\>/$__to/g" $__file; > > > done > > > > > > Cc: Rob Clark <robdclark@gmail.com> > > > Cc: Sean Paul <sean@poorly.run> > > > Cc: linux-arm-msm@vger.kernel.org > > > Signed-off-by: Emil Velikov <emil.velikov@collabora.com> > > > > Since > > > > commit 48e7f18392c66f9b69ebac11c54f1a2e033ced54 > > Author: Kristian H. Kristensen <hoegsberg@gmail.com> > > Date: Wed Mar 20 10:09:08 2019 -0700 > > > > drm/msm: Implement .gem_free_object_unlocked > > > > msm doesn't need the struct_mutex in the bo_put anymore, the only reason > > we had to use the _locked version here is historical accidents I think. > > > > I think you could convert these all to the _unlocked variant and then > > entirely drop the _locked version. > > > Did not check the msm driver closely, but it makes sense. Let's keep > that as follow-up series? > We're already at 36 patches, plus mixing mostly mechanical and locking > changes doesn't sound wise. My idea was to simply throw this patch out, and replace it by an msm patch to switch over to the unlocked variant. Well maybe then needs 2nd patch to throw the locked version out. So feels a bit a detour to touch msm twice, which is why I suggested to do the more direct route. But if you feel strongly I guess we can go this way and then follow up with converting msm to unlocked and throwing the _locked variant out for good too. -Daniel > > Once we have that we could move struct_mutex into each driver (at least > > for msm and i915) since it's purely internal, and then wrap it in an > > #ifdef CONFIG_DRM_LEGACY to gloriously sunset it all :-) > > > Indeed, we're nearly there. > > -Emil -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-08 11:25 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-07 15:07 [PATCH 00/36] drm: Fareless gem_free_object Emil Velikov 2020-05-07 15:07 ` [PATCH 01/36] drm: remove unused drm_gem.h include Emil Velikov 2020-05-07 15:30 ` Thomas Zimmermann 2020-05-07 15:07 ` [PATCH 02/36] drm/gem: use _unlocked reference in drm_gem_objects_lookup docs Emil Velikov 2020-05-07 17:58 ` Sam Ravnborg 2020-05-07 15:07 ` [PATCH 03/36] drm/todo: mention i915 in the struct_mutex section Emil Velikov 2020-05-08 6:26 ` Daniel Vetter 2020-05-08 14:45 ` Ruhl, Michael J 2020-05-07 15:07 ` [PATCH 04/36] drm/doc: drop struct_mutex references Emil Velikov 2020-05-07 18:01 ` Sam Ravnborg 2020-05-08 10:01 ` Emil Velikov 2020-05-08 11:08 ` Sam Ravnborg 2020-05-08 6:27 ` Daniel Vetter 2020-05-08 10:07 ` Emil Velikov 2020-05-08 10:45 ` Daniel Vetter 2020-05-07 15:07 ` [PATCH 05/36] drm/doc: drop struct_mutex refernce for drm_gem_object_free Emil Velikov 2020-05-08 6:31 ` Daniel Vetter 2020-05-07 15:07 ` [PATCH 06/36] drm/amdgpu: use the unlocked drm_gem_object_put Emil Velikov 2020-05-07 15:07 ` Emil Velikov 2020-05-07 18:03 ` Sam Ravnborg 2020-05-07 18:03 ` Sam Ravnborg 2020-05-08 8:16 ` Christian König 2020-05-08 8:16 ` Christian König 2020-05-08 9:55 ` Emil Velikov 2020-05-08 9:55 ` Emil Velikov 2020-05-08 11:09 ` Sam Ravnborg 2020-05-08 11:09 ` Sam Ravnborg 2020-05-08 8:13 ` Christian König 2020-05-08 8:13 ` Christian König 2020-05-07 15:07 ` [PATCH 07/36] drm/gma500: Use lockless gem BO free callback Emil Velikov 2020-05-07 17:16 ` Thomas Zimmermann 2020-05-07 15:07 ` [PATCH 08/36] drm: remove drm_driver::gem_free_object Emil Velikov 2020-05-07 17:20 ` Thomas Zimmermann 2020-05-07 15:07 ` [PATCH 09/36] drm/gem: fold drm_gem_object_put_unlocked and __drm_gem_object_put() Emil Velikov 2020-05-08 6:43 ` Daniel Vetter 2020-05-08 10:52 ` Emil Velikov 2020-05-07 15:07 ` [PATCH 10/36] drm/gem: add _locked suffix to drm_object_put Emil Velikov 2020-05-07 15:07 ` Emil Velikov 2020-05-08 6:40 ` Daniel Vetter 2020-05-08 6:40 ` Daniel Vetter 2020-05-08 11:00 ` Emil Velikov 2020-05-08 11:00 ` Emil Velikov 2020-05-08 11:25 ` Daniel Vetter [this message] 2020-05-08 11:25 ` Daniel Vetter 2020-05-07 15:07 ` [PATCH 11/36] drm/gem: add drm_object_put helper Emil Velikov 2020-05-08 6:33 ` Jani Nikula 2020-05-08 10:16 ` Emil Velikov 2020-05-07 15:07 ` [PATCH 12/36] drm/amd: remove _unlocked suffix in drm_object_put_unlocked Emil Velikov 2020-05-08 9:23 ` Christian König 2020-05-08 10:45 ` Emil Velikov 2020-05-07 15:07 ` [PATCH 13/36] drm/arm: " Emil Velikov 2020-05-14 15:23 ` Liviu Dudau 2020-05-07 15:08 ` [PATCH 14/36] drm/armada: " Emil Velikov 2020-05-07 15:08 ` [PATCH 15/36] drm/etnaviv: " Emil Velikov 2020-05-07 15:08 ` [PATCH 16/36] drm/exynos: " Emil Velikov 2020-05-07 15:08 ` [PATCH 17/36] drm/gma500: " Emil Velikov 2020-05-07 15:08 ` [PATCH 18/36] drm/i915: " Emil Velikov 2020-05-07 15:08 ` [PATCH 19/36] drm/lima: " Emil Velikov 2020-05-07 15:08 ` [PATCH 20/36] drm/mediatek: " Emil Velikov 2020-05-09 13:45 ` Chun-Kuang Hu 2020-05-07 15:08 ` [PATCH 21/36] drm/mgag200: " Emil Velikov 2020-05-08 6:30 ` Thomas Zimmermann 2020-05-07 15:08 ` [PATCH 22/36] drm/msm: " Emil Velikov 2020-05-07 15:08 ` [PATCH 23/36] drm/nouveau: " Emil Velikov 2020-05-07 15:08 ` [PATCH 24/36] drm/omapdrm: " Emil Velikov 2020-05-07 15:08 ` [PATCH 25/36] drm/panfrost: " Emil Velikov 2020-05-07 15:08 ` [PATCH 26/36] drm/qxl: " Emil Velikov 2020-05-07 15:08 ` [PATCH 27/36] drm/radeon: " Emil Velikov 2020-05-07 15:08 ` [PATCH 28/36] drm/rockchip: " Emil Velikov 2020-05-07 15:08 ` [PATCH 29/36] drm/tegra: " Emil Velikov 2020-05-07 15:08 ` [PATCH 30/36] drm/v3d: " Emil Velikov 2020-05-07 15:08 ` [PATCH 31/36] drm/vc4: " Emil Velikov 2020-05-07 15:08 ` [PATCH 32/36] drm/vgem: " Emil Velikov 2020-05-07 15:08 ` [PATCH 33/36] drm/virtio: " Emil Velikov 2020-05-07 15:08 ` [PATCH 34/36] drm/vkms: " Emil Velikov 2020-05-07 15:08 ` [PATCH 35/36] drm/xen: " Emil Velikov 2020-05-07 15:08 ` [PATCH 36/36] drm/gem: " Emil Velikov 2020-05-07 18:14 ` Sam Ravnborg 2020-05-08 10:15 ` Emil Velikov 2020-05-08 11:02 ` Sam Ravnborg 2020-05-08 6:38 ` Thomas Zimmermann 2020-05-07 18:17 ` [PATCH 00/36] drm: Fareless gem_free_object Sam Ravnborg 2020-05-08 10:35 ` Emil Velikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200508112519.GI1383626@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.l.velikov@gmail.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.