* [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ @ 2020-05-08 22:05 Ashutosh Dixit 2020-05-08 22:08 ` Chris Wilson ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Ashutosh Dixit @ 2020-05-08 22:05 UTC (permalink / raw) To: igt-dev pwrite_() and pread_() purport to read each page but weren't. v2: Keep subpage iteration (Chris) Reported-by: CQ Tang <cq.tang@intel.com> Fixes: 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress) Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> --- tests/i915/gem_shrink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c index c9964ccc0..10d639423 100644 --- a/tests/i915/gem_shrink.c +++ b/tests/i915/gem_shrink.c @@ -58,7 +58,7 @@ static void pwrite_(int fd, uint64_t alloc) uint32_t tmp; uint32_t handle = gem_create(fd, alloc); for (int page = 0; page < alloc>>12; page++) - gem_write(fd, handle, (page + page % 4095) & ~3, &tmp, 4); + gem_write(fd, handle, ((page << 12) + page % 4095) & ~3, &tmp, 4); gem_madvise(fd, handle, I915_MADV_DONTNEED); } @@ -67,7 +67,7 @@ static void pread_(int fd, uint64_t alloc) uint32_t tmp; uint32_t handle = gem_create(fd, alloc); for (int page = 0; page < alloc>>12; page++) - gem_read(fd, handle, (page + page % 4095) & ~3, &tmp, 4); + gem_read(fd, handle, ((page << 12) + page % 4095) & ~3, &tmp, 4); gem_madvise(fd, handle, I915_MADV_DONTNEED); } -- 2.26.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ 2020-05-08 22:05 [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ Ashutosh Dixit @ 2020-05-08 22:08 ` Chris Wilson 2020-05-08 22:30 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_shrink: touch each page in pwrite_/pread_ (rev3) Patchwork 2020-05-09 0:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 7+ messages in thread From: Chris Wilson @ 2020-05-08 22:08 UTC (permalink / raw) To: Ashutosh Dixit, igt-dev Quoting Ashutosh Dixit (2020-05-08 23:05:41) > pwrite_() and pread_() purport to read each page but weren't. > > v2: Keep subpage iteration (Chris) > > Reported-by: CQ Tang <cq.tang@intel.com> > Fixes: 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress) > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_shrink: touch each page in pwrite_/pread_ (rev3) 2020-05-08 22:05 [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ Ashutosh Dixit 2020-05-08 22:08 ` Chris Wilson @ 2020-05-08 22:30 ` Patchwork 2020-05-09 0:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-05-08 22:30 UTC (permalink / raw) To: Ashutosh Dixit; +Cc: igt-dev == Series Details == Series: igt/gem_shrink: touch each page in pwrite_/pread_ (rev3) URL : https://patchwork.freedesktop.org/series/77085/ State : success == Summary == CI Bug Log - changes from CI_DRM_8455 -> IGTPW_4550 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html Known issues ------------ Here are the changes found in IGTPW_4550 that come from known issues: ### IGT changes ### #### Warnings #### * igt@amdgpu/amd_basic@query-info: - fi-bwr-2160: [SKIP][1] ([fdo#109271]) -> [FAIL][2] ([i915#1125] / [i915#489]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/fi-bwr-2160/igt@amdgpu/amd_basic@query-info.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/fi-bwr-2160/igt@amdgpu/amd_basic@query-info.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1125]: https://gitlab.freedesktop.org/drm/intel/issues/1125 [i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489 Participating hosts (48 -> 42) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5642 -> IGTPW_4550 CI-20190529: 20190529 CI_DRM_8455: 0fa901c0a0e4f6e0ab2821f7b26c417539cecd08 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4550: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html IGT_5642: d1ce4abb01c70f7be6e777b6d45442663c4b830e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for igt/gem_shrink: touch each page in pwrite_/pread_ (rev3) 2020-05-08 22:05 [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ Ashutosh Dixit 2020-05-08 22:08 ` Chris Wilson 2020-05-08 22:30 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_shrink: touch each page in pwrite_/pread_ (rev3) Patchwork @ 2020-05-09 0:40 ` Patchwork 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2020-05-09 0:40 UTC (permalink / raw) To: Ashutosh Dixit; +Cc: igt-dev == Series Details == Series: igt/gem_shrink: touch each page in pwrite_/pread_ (rev3) URL : https://patchwork.freedesktop.org/series/77085/ State : success == Summary == CI Bug Log - changes from CI_DRM_8455_full -> IGTPW_4550_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html Known issues ------------ Here are the changes found in IGTPW_4550_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][1] -> [INCOMPLETE][2] ([i915#155]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl3/igt@gem_workarounds@suspend-resume-fd.html * igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen: - shard-kbl: [PASS][3] -> [FAIL][4] ([i915#54] / [i915#93] / [i915#95]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen.html * igt@kms_frontbuffer_tracking@psr-farfromfence: - shard-tglb: [PASS][5] -> [SKIP][6] ([i915#668]) +8 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-tglb7/igt@kms_frontbuffer_tracking@psr-farfromfence.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-tglb6/igt@kms_frontbuffer_tracking@psr-farfromfence.html * igt@kms_hdmi_inject@inject-audio: - shard-tglb: [PASS][7] -> [SKIP][8] ([i915#433]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-tglb8/igt@kms_hdmi_inject@inject-audio.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html * igt@kms_plane_cursor@pipe-a-overlay-size-256: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#1559] / [i915#93] / [i915#95]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl7/igt@kms_plane_cursor@pipe-a-overlay-size-256.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl2/igt@kms_plane_cursor@pipe-a-overlay-size-256.html - shard-apl: [PASS][11] -> [FAIL][12] ([i915#1559] / [i915#95]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl4/igt@kms_plane_cursor@pipe-a-overlay-size-256.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl4/igt@kms_plane_cursor@pipe-a-overlay-size-256.html * igt@kms_psr@psr2_cursor_render: - shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109441]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-iclb2/igt@kms_psr@psr2_cursor_render.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-iclb4/igt@kms_psr@psr2_cursor_render.html #### Possible fixes #### * igt@i915_suspend@sysfs-reader: - shard-apl: [DMESG-WARN][15] ([i915#180]) -> [PASS][16] +2 similar issues [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl1/igt@i915_suspend@sysfs-reader.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl7/igt@i915_suspend@sysfs-reader.html * igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen: - shard-kbl: [FAIL][17] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen.html * igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge: - shard-glk: [FAIL][19] ([i915#118] / [i915#70] / [i915#95]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-glk8/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-glk9/igt@kms_cursor_edge_walk@pipe-a-256x256-left-edge.html * igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled: - shard-apl: [FAIL][21] ([i915#52] / [i915#54] / [i915#95]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl7/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl8/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html - shard-kbl: [FAIL][23] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl2/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl6/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html * {igt@kms_flip@flip-vs-suspend@a-dp1}: - shard-kbl: [DMESG-WARN][25] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl4/igt@kms_flip@flip-vs-suspend@a-dp1.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl3/igt@kms_flip@flip-vs-suspend@a-dp1.html * {igt@kms_flip@flip-vs-suspend@b-hdmi-a1}: - shard-hsw: [INCOMPLETE][27] ([i915#61]) -> [PASS][28] [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-hsw2/igt@kms_flip@flip-vs-suspend@b-hdmi-a1.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-hsw4/igt@kms_flip@flip-vs-suspend@b-hdmi-a1.html * igt@kms_plane_cursor@pipe-a-overlay-size-128: - shard-kbl: [FAIL][29] ([i915#1559] / [i915#93] / [i915#95]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl6/igt@kms_plane_cursor@pipe-a-overlay-size-128.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl4/igt@kms_plane_cursor@pipe-a-overlay-size-128.html - shard-apl: [FAIL][31] ([i915#1559] / [i915#95]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl1/igt@kms_plane_cursor@pipe-a-overlay-size-128.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl7/igt@kms_plane_cursor@pipe-a-overlay-size-128.html * igt@kms_psr@psr2_primary_mmap_cpu: - shard-iclb: [SKIP][33] ([fdo#109441]) -> [PASS][34] +2 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html * igt@kms_setmode@basic: - shard-hsw: [FAIL][35] ([i915#31]) -> [PASS][36] [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-hsw6/igt@kms_setmode@basic.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-hsw1/igt@kms_setmode@basic.html #### Warnings #### * igt@kms_content_protection@uevent: - shard-kbl: [FAIL][37] ([i915#357]) -> [FAIL][38] ([i915#357] / [i915#93] / [i915#95]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl7/igt@kms_content_protection@uevent.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl1/igt@kms_content_protection@uevent.html - shard-apl: [FAIL][39] ([i915#357]) -> [FAIL][40] ([i915#357] / [i915#95]) [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl7/igt@kms_content_protection@uevent.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl2/igt@kms_content_protection@uevent.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [FAIL][41] ([i915#1525]) -> [FAIL][42] ([i915#1121] / [i915#95]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl8/igt@kms_fbcon_fbt@fbc-suspend.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl4/igt@kms_fbcon_fbt@fbc-suspend.html - shard-kbl: [FAIL][43] ([i915#64]) -> [FAIL][44] ([i915#1121] / [i915#93] / [i915#95]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-kbl4/igt@kms_fbcon_fbt@fbc-suspend.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-apl: [FAIL][45] ([fdo#108145] / [i915#265]) -> [FAIL][46] ([fdo#108145] / [i915#265] / [i915#95]) +1 similar issue [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8455/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [i915#1121]: https://gitlab.freedesktop.org/drm/intel/issues/1121 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1525]: https://gitlab.freedesktop.org/drm/intel/issues/1525 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155 [i915#1559]: https://gitlab.freedesktop.org/drm/intel/issues/1559 [i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#357]: https://gitlab.freedesktop.org/drm/intel/issues/357 [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433 [i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61 [i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64 [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668 [i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (11 -> 8) ------------------------------ Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5642 -> IGTPW_4550 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_8455: 0fa901c0a0e4f6e0ab2821f7b26c417539cecd08 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4550: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html IGT_5642: d1ce4abb01c70f7be6e777b6d45442663c4b830e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4550/index.html _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ @ 2020-05-08 21:34 Ashutosh Dixit 2020-05-08 21:41 ` Chris Wilson 0 siblings, 1 reply; 7+ messages in thread From: Ashutosh Dixit @ 2020-05-08 21:34 UTC (permalink / raw) To: igt-dev pwrite_() and pread_() purport to read each page but weren't. Reported-by: CQ Tang <cq.tang@intel.com> Fixes: 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress) Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> --- tests/i915/gem_shrink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c index c9964ccc0..f6f1144ba 100644 --- a/tests/i915/gem_shrink.c +++ b/tests/i915/gem_shrink.c @@ -58,7 +58,7 @@ static void pwrite_(int fd, uint64_t alloc) uint32_t tmp; uint32_t handle = gem_create(fd, alloc); for (int page = 0; page < alloc>>12; page++) - gem_write(fd, handle, (page + page % 4095) & ~3, &tmp, 4); + gem_write(fd, handle, page << 12, &tmp, 4); gem_madvise(fd, handle, I915_MADV_DONTNEED); } @@ -67,7 +67,7 @@ static void pread_(int fd, uint64_t alloc) uint32_t tmp; uint32_t handle = gem_create(fd, alloc); for (int page = 0; page < alloc>>12; page++) - gem_read(fd, handle, (page + page % 4095) & ~3, &tmp, 4); + gem_read(fd, handle, page << 12, &tmp, 4); gem_madvise(fd, handle, I915_MADV_DONTNEED); } -- 2.26.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ 2020-05-08 21:34 [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ Ashutosh Dixit @ 2020-05-08 21:41 ` Chris Wilson 0 siblings, 0 replies; 7+ messages in thread From: Chris Wilson @ 2020-05-08 21:41 UTC (permalink / raw) To: Ashutosh Dixit, igt-dev Quoting Ashutosh Dixit (2020-05-08 22:34:47) > pwrite_() and pread_() purport to read each page but weren't. > > Reported-by: CQ Tang <cq.tang@intel.com> > Fixes: 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress) > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Keep the subpage iteration for the variation. -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 7+ messages in thread
* [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ @ 2020-05-08 21:29 Ashutosh Dixit 0 siblings, 0 replies; 7+ messages in thread From: Ashutosh Dixit @ 2020-05-08 21:29 UTC (permalink / raw) To: igt-dev pwrite_() and pread_() purport to read each page but weren't. Reported-by: CQ Tang <cq.tang@intel.com> Fixes 88bfe6ac41 ("igt/gem_shrink: Add pread/pwrite stress) Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com> --- tests/i915/gem_shrink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c index c9964ccc0..f6f1144ba 100644 --- a/tests/i915/gem_shrink.c +++ b/tests/i915/gem_shrink.c @@ -58,7 +58,7 @@ static void pwrite_(int fd, uint64_t alloc) uint32_t tmp; uint32_t handle = gem_create(fd, alloc); for (int page = 0; page < alloc>>12; page++) - gem_write(fd, handle, (page + page % 4095) & ~3, &tmp, 4); + gem_write(fd, handle, page << 12, &tmp, 4); gem_madvise(fd, handle, I915_MADV_DONTNEED); } @@ -67,7 +67,7 @@ static void pread_(int fd, uint64_t alloc) uint32_t tmp; uint32_t handle = gem_create(fd, alloc); for (int page = 0; page < alloc>>12; page++) - gem_read(fd, handle, (page + page % 4095) & ~3, &tmp, 4); + gem_read(fd, handle, page << 12, &tmp, 4); gem_madvise(fd, handle, I915_MADV_DONTNEED); } -- 2.26.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-09 0:40 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-08 22:05 [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ Ashutosh Dixit 2020-05-08 22:08 ` Chris Wilson 2020-05-08 22:30 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_shrink: touch each page in pwrite_/pread_ (rev3) Patchwork 2020-05-09 0:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork -- strict thread matches above, loose matches on Subject: below -- 2020-05-08 21:34 [igt-dev] [PATCH i-g-t] igt/gem_shrink: touch each page in pwrite_/pread_ Ashutosh Dixit 2020-05-08 21:41 ` Chris Wilson 2020-05-08 21:29 Ashutosh Dixit
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.