* [PATCH -next] powerpc/powernv: add NULL check after kzalloc
@ 2020-05-09 2:08 ` Chen Zhou
0 siblings, 0 replies; 3+ messages in thread
From: Chen Zhou @ 2020-05-09 2:08 UTC (permalink / raw)
To: mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel, chenzhou10
Fixes coccicheck warning:
./arch/powerpc/platforms/powernv/opal.c:813:1-5:
alloc with no test, possible model on line 814
Add NULL check after kzalloc.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
arch/powerpc/platforms/powernv/opal.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 2b3dfd0b6cdd..d95954ad4c0a 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -811,6 +811,10 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name,
goto out;
attr = kzalloc(sizeof(*attr), GFP_KERNEL);
+ if (!attr) {
+ rc = -ENOMEM;
+ goto out;
+ }
name = kstrdup(export_name, GFP_KERNEL);
if (!name) {
rc = -ENOMEM;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] powerpc/powernv: add NULL check after kzalloc
@ 2020-05-09 2:08 ` Chen Zhou
0 siblings, 0 replies; 3+ messages in thread
From: Chen Zhou @ 2020-05-09 2:08 UTC (permalink / raw)
To: mpe, benh, paulus; +Cc: chenzhou10, linuxppc-dev, linux-kernel
Fixes coccicheck warning:
./arch/powerpc/platforms/powernv/opal.c:813:1-5:
alloc with no test, possible model on line 814
Add NULL check after kzalloc.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
arch/powerpc/platforms/powernv/opal.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
index 2b3dfd0b6cdd..d95954ad4c0a 100644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/arch/powerpc/platforms/powernv/opal.c
@@ -811,6 +811,10 @@ static int opal_add_one_export(struct kobject *parent, const char *export_name,
goto out;
attr = kzalloc(sizeof(*attr), GFP_KERNEL);
+ if (!attr) {
+ rc = -ENOMEM;
+ goto out;
+ }
name = kstrdup(export_name, GFP_KERNEL);
if (!name) {
rc = -ENOMEM;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] powerpc/powernv: add NULL check after kzalloc
2020-05-09 2:08 ` Chen Zhou
(?)
@ 2020-06-09 5:28 ` Michael Ellerman
-1 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-06-09 5:28 UTC (permalink / raw)
To: mpe, benh, Chen Zhou, paulus; +Cc: linuxppc-dev, linux-kernel
On Sat, 9 May 2020 10:08:38 +0800, Chen Zhou wrote:
> Fixes coccicheck warning:
>
> ./arch/powerpc/platforms/powernv/opal.c:813:1-5:
> alloc with no test, possible model on line 814
>
> Add NULL check after kzalloc.
Applied to powerpc/next.
[1/1] powerpc/powernv: add NULL check after kzalloc
https://git.kernel.org/powerpc/c/ceffa63acce7165c442395b7d64a11ab8b5c5dca
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-09 5:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 2:08 [PATCH -next] powerpc/powernv: add NULL check after kzalloc Chen Zhou
2020-05-09 2:08 ` Chen Zhou
2020-06-09 5:28 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.