* [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map()
@ 2020-05-09 3:02 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2020-05-09 2:58 UTC (permalink / raw)
To: jglisse, Ralph Campbell
Cc: Wei Yongjun, linux-mm, linux-kernel, kernel-janitors, Hulk Robot
Add the missing unlock before return from function
dmirror_migrate_finalize_and_map() in the error
handling case.
Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
lib/test_hmm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/test_hmm.c b/lib/test_hmm.c
index 00bca6116f93..30462193c4ff 100644
--- a/lib/test_hmm.c
+++ b/lib/test_hmm.c
@@ -647,8 +647,10 @@ static int dmirror_migrate_finalize_and_map(struct migrate_vma *args,
if (*dst & MIGRATE_PFN_WRITE)
entry = xa_tag_pointer(entry, DPT_XA_TAG_WRITE);
entry = xa_store(&dmirror->pt, pfn, entry, GFP_ATOMIC);
- if (xa_is_err(entry))
+ if (xa_is_err(entry)) {
+ mutex_unlock(&dmirror->mutex);
return xa_err(entry);
+ }
}
mutex_unlock(&dmirror->mutex);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map()
@ 2020-05-09 3:02 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2020-05-09 3:02 UTC (permalink / raw)
To: jglisse, Ralph Campbell
Cc: Wei Yongjun, linux-mm, linux-kernel, kernel-janitors, Hulk Robot
Add the missing unlock before return from function
dmirror_migrate_finalize_and_map() in the error
handling case.
Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
lib/test_hmm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/test_hmm.c b/lib/test_hmm.c
index 00bca6116f93..30462193c4ff 100644
--- a/lib/test_hmm.c
+++ b/lib/test_hmm.c
@@ -647,8 +647,10 @@ static int dmirror_migrate_finalize_and_map(struct migrate_vma *args,
if (*dst & MIGRATE_PFN_WRITE)
entry = xa_tag_pointer(entry, DPT_XA_TAG_WRITE);
entry = xa_store(&dmirror->pt, pfn, entry, GFP_ATOMIC);
- if (xa_is_err(entry))
+ if (xa_is_err(entry)) {
+ mutex_unlock(&dmirror->mutex);
return xa_err(entry);
+ }
}
mutex_unlock(&dmirror->mutex);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map()
2020-05-09 3:02 ` Wei Yongjun
@ 2020-05-11 17:22 ` Ralph Campbell
-1 siblings, 0 replies; 6+ messages in thread
From: Ralph Campbell @ 2020-05-11 17:22 UTC (permalink / raw)
To: Wei Yongjun, jglisse; +Cc: linux-mm, linux-kernel, kernel-janitors, Hulk Robot
On 5/8/20 8:02 PM, Wei Yongjun wrote:
> Add the missing unlock before return from function
> dmirror_migrate_finalize_and_map() in the error
> handling case.
>
> Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Looks good, thanks!
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> ---
> lib/test_hmm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/test_hmm.c b/lib/test_hmm.c
> index 00bca6116f93..30462193c4ff 100644
> --- a/lib/test_hmm.c
> +++ b/lib/test_hmm.c
> @@ -647,8 +647,10 @@ static int dmirror_migrate_finalize_and_map(struct migrate_vma *args,
> if (*dst & MIGRATE_PFN_WRITE)
> entry = xa_tag_pointer(entry, DPT_XA_TAG_WRITE);
> entry = xa_store(&dmirror->pt, pfn, entry, GFP_ATOMIC);
> - if (xa_is_err(entry))
> + if (xa_is_err(entry)) {
> + mutex_unlock(&dmirror->mutex);
> return xa_err(entry);
> + }
> }
>
> mutex_unlock(&dmirror->mutex);
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map()
@ 2020-05-11 17:22 ` Ralph Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ralph Campbell @ 2020-05-11 17:22 UTC (permalink / raw)
To: Wei Yongjun, jglisse; +Cc: linux-mm, linux-kernel, kernel-janitors, Hulk Robot
On 5/8/20 8:02 PM, Wei Yongjun wrote:
> Add the missing unlock before return from function
> dmirror_migrate_finalize_and_map() in the error
> handling case.
>
> Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Looks good, thanks!
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> ---
> lib/test_hmm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/test_hmm.c b/lib/test_hmm.c
> index 00bca6116f93..30462193c4ff 100644
> --- a/lib/test_hmm.c
> +++ b/lib/test_hmm.c
> @@ -647,8 +647,10 @@ static int dmirror_migrate_finalize_and_map(struct migrate_vma *args,
> if (*dst & MIGRATE_PFN_WRITE)
> entry = xa_tag_pointer(entry, DPT_XA_TAG_WRITE);
> entry = xa_store(&dmirror->pt, pfn, entry, GFP_ATOMIC);
> - if (xa_is_err(entry))
> + if (xa_is_err(entry)) {
> + mutex_unlock(&dmirror->mutex);
> return xa_err(entry);
> + }
> }
>
> mutex_unlock(&dmirror->mutex);
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map()
2020-05-09 3:02 ` Wei Yongjun
@ 2020-05-12 19:59 ` Jason Gunthorpe
-1 siblings, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2020-05-12 19:59 UTC (permalink / raw)
To: Wei Yongjun
Cc: jglisse, Ralph Campbell, linux-mm, linux-kernel, kernel-janitors,
Hulk Robot
On Sat, May 09, 2020 at 03:02:25AM +0000, Wei Yongjun wrote:
> Add the missing unlock before return from function
> dmirror_migrate_finalize_and_map() in the error
> handling case.
>
> Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> lib/test_hmm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thank you, I squashed this into the original commit
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map()
@ 2020-05-12 19:59 ` Jason Gunthorpe
0 siblings, 0 replies; 6+ messages in thread
From: Jason Gunthorpe @ 2020-05-12 19:59 UTC (permalink / raw)
To: Wei Yongjun
Cc: jglisse, Ralph Campbell, linux-mm, linux-kernel, kernel-janitors,
Hulk Robot
On Sat, May 09, 2020 at 03:02:25AM +0000, Wei Yongjun wrote:
> Add the missing unlock before return from function
> dmirror_migrate_finalize_and_map() in the error
> handling case.
>
> Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> lib/test_hmm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thank you, I squashed this into the original commit
Jason
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-12 19:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 2:58 [PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map() Wei Yongjun
2020-05-09 3:02 ` Wei Yongjun
2020-05-11 17:22 ` Ralph Campbell
2020-05-11 17:22 ` Ralph Campbell
2020-05-12 19:59 ` Jason Gunthorpe
2020-05-12 19:59 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.