From: Kees Cook <keescook@chromium.org>
To: WeiXiong Liao <liaoweixiong@allwinnertech.com>
Cc: Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-doc@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device
Date: Sat, 9 May 2020 12:10:46 -0700 [thread overview]
Message-ID: <202005091209.406DB4C@keescook> (raw)
In-Reply-To: <c1583001-bf03-d198-ad57-3d2a0baf93ca@allwinnertech.com>
On Sat, May 09, 2020 at 06:32:28PM +0800, WeiXiong Liao wrote:
> The following diff is to fix "rmmod" bug.
>
> @@ -1273,8 +1273,8 @@ static void psz_free_zones(struct pstore_zone
> ***pszones, unsigned int *cnt)
> return;
>
> while (*cnt > 0) {
> - psz_free_zone(&zones[*cnt]);
> (*cnt)--;
> + psz_free_zone(&zones[*cnt]);
> }
> kfree(zones);
> *pszones = NULL;
Ah-ha! Thanks; I'd almost found that. I got confused because I wasn't
see NULL free()s, and I finally noticed that the zones had left over
ERR_PTRs:
if (IS_ERR(cxt->fpszs)) {
err = PTR_ERR(cxt->fpszs);
+ cxt->fpszs = NULL;
goto free_out;
}
I'll fix those and your v5 and my lastest tree merged.
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: WeiXiong Liao <liaoweixiong@allwinnertech.com>
Cc: Petr Mladek <pmladek@suse.com>, Tony Luck <tony.luck@intel.com>,
linux-doc@vger.kernel.org, Anton Vorontsov <anton@enomsg.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-mtd@lists.infradead.org, Colin Cross <ccross@android.com>
Subject: Re: [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device
Date: Sat, 9 May 2020 12:10:46 -0700 [thread overview]
Message-ID: <202005091209.406DB4C@keescook> (raw)
In-Reply-To: <c1583001-bf03-d198-ad57-3d2a0baf93ca@allwinnertech.com>
On Sat, May 09, 2020 at 06:32:28PM +0800, WeiXiong Liao wrote:
> The following diff is to fix "rmmod" bug.
>
> @@ -1273,8 +1273,8 @@ static void psz_free_zones(struct pstore_zone
> ***pszones, unsigned int *cnt)
> return;
>
> while (*cnt > 0) {
> - psz_free_zone(&zones[*cnt]);
> (*cnt)--;
> + psz_free_zone(&zones[*cnt]);
> }
> kfree(zones);
> *pszones = NULL;
Ah-ha! Thanks; I'd almost found that. I got confused because I wasn't
see NULL free()s, and I finally noticed that the zones had left over
ERR_PTRs:
if (IS_ERR(cxt->fpszs)) {
err = PTR_ERR(cxt->fpszs);
+ cxt->fpszs = NULL;
goto free_out;
}
I'll fix those and your v5 and my lastest tree merged.
--
Kees Cook
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-09 19:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:39 [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-08 6:39 ` [PATCH v4 01/12] printk: Introduce kmsg_dump_reason_str() Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-08 6:39 ` [PATCH v4 02/12] pstore/zone: Introduce common layer to manage storage zones Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-09 3:09 ` WeiXiong Liao
2020-05-09 3:09 ` WeiXiong Liao
2020-05-08 6:39 ` [PATCH v4 03/12] pstore/blk: Introduce backend for block devices Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-09 3:48 ` WeiXiong Liao
2020-05-09 3:48 ` WeiXiong Liao
2020-05-08 6:39 ` [PATCH v4 04/12] pstore/blk: Provide way to choose pstore frontend support Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-08 6:39 ` [PATCH v4 05/12] pstore/blk: Add support for pmsg frontend Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-09 4:38 ` WeiXiong Liao
2020-05-09 4:38 ` WeiXiong Liao
2020-05-08 6:39 ` [PATCH v4 06/12] pstore/blk: Add console frontend support Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-09 4:53 ` WeiXiong Liao
2020-05-09 4:53 ` WeiXiong Liao
2020-05-08 6:39 ` [PATCH v4 07/12] pstore/blk: Add ftrace " Kees Cook
2020-05-08 6:39 ` Kees Cook
2020-05-08 6:40 ` [PATCH v4 08/12] Documentation: Add details for pstore/blk Kees Cook
2020-05-08 6:40 ` Kees Cook
2020-05-08 6:40 ` [PATCH v4 09/12] pstore/zone: Provide way to skip "broken" zone for MTD devices Kees Cook
2020-05-08 6:40 ` Kees Cook
2020-05-08 6:40 ` [PATCH v4 10/12] pstore/blk: Provide way to query pstore configuration Kees Cook
2020-05-08 6:40 ` Kees Cook
2020-05-08 6:40 ` [PATCH v4 11/12] pstore/blk: Support non-block storage devices Kees Cook
2020-05-08 6:40 ` Kees Cook
2020-05-08 6:40 ` [PATCH v4 12/12] mtd: Support kmsg dumper based on pstore/blk Kees Cook
2020-05-08 6:40 ` Kees Cook
2020-05-09 5:14 ` WeiXiong Liao
2020-05-09 5:14 ` WeiXiong Liao
2020-05-08 7:27 ` [PATCH v4 00/12] pstore: mtd: support crash log to block and mtd device Kees Cook
2020-05-08 7:27 ` Kees Cook
2020-05-09 10:32 ` WeiXiong Liao
2020-05-09 10:32 ` WeiXiong Liao
2020-05-09 19:10 ` Kees Cook [this message]
2020-05-09 19:10 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005091209.406DB4C@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.