* [Buildroot] [PATCH 1/1] package/brltty: add host-gawk dependency
@ 2020-05-08 16:28 Fabrice Fontaine
2020-05-08 20:26 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2020-05-08 16:28 UTC (permalink / raw)
To: buildroot
host-gawk is used by brltty to build brlapi_constants.h, the build will
fail if mawk is used instead of gawk
Fixes:
- http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/brltty/brltty.mk | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/package/brltty/brltty.mk b/package/brltty/brltty.mk
index e34b9b2b76..4f40e65fc6 100644
--- a/package/brltty/brltty.mk
+++ b/package/brltty/brltty.mk
@@ -12,7 +12,11 @@ BRLTTY_INSTALL_TARGET_OPTS = INSTALL_ROOT=$(TARGET_DIR) install
BRLTTY_LICENSE = LGPL-2.1+
BRLTTY_LICENSE_FILES = LICENSE-LGPL README
-BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-autoconf host-pkgconf \
+BRLTTY_DEPENDENCIES = \
+ $(TARGET_NLS_DEPENDENCIES) \
+ host-autoconf \
+ host-gawk \
+ host-pkgconf \
$(if $(BR2_PACKAGE_AT_SPI2_CORE),at-spi2-core)
BRLTTY_CONF_ENV = \
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/brltty: add host-gawk dependency
2020-05-08 16:28 [Buildroot] [PATCH 1/1] package/brltty: add host-gawk dependency Fabrice Fontaine
@ 2020-05-08 20:26 ` Yann E. MORIN
[not found] ` <87d07cx660.fsf@blind.guru>
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2020-05-08 20:26 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2020-05-08 18:28 +0200, Fabrice Fontaine spake thusly:
> host-gawk is used by brltty to build brlapi_constants.h, the build will
> fail if mawk is used instead of gawk
>
> Fixes:
> - http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
It seemed like a simple patch, but I can't reproduce the error with mawk
on my machine:
$ update-alternatives --get-selections |grep awk
awk manual /usr/bin/mawk
$ awk --version
awk: not an option: --version
$ wget -O .config http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743/config
$ make olddefconfig
$ make brltty
Success...
So, there is something else lurking in the darkness... :-/
Regards,
Yann E. MORIN.
> ---
> package/brltty/brltty.mk | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/package/brltty/brltty.mk b/package/brltty/brltty.mk
> index e34b9b2b76..4f40e65fc6 100644
> --- a/package/brltty/brltty.mk
> +++ b/package/brltty/brltty.mk
> @@ -12,7 +12,11 @@ BRLTTY_INSTALL_TARGET_OPTS = INSTALL_ROOT=$(TARGET_DIR) install
> BRLTTY_LICENSE = LGPL-2.1+
> BRLTTY_LICENSE_FILES = LICENSE-LGPL README
>
> -BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-autoconf host-pkgconf \
> +BRLTTY_DEPENDENCIES = \
> + $(TARGET_NLS_DEPENDENCIES) \
> + host-autoconf \
> + host-gawk \
> + host-pkgconf \
> $(if $(BR2_PACKAGE_AT_SPI2_CORE),at-spi2-core)
>
> BRLTTY_CONF_ENV = \
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/brltty: add host-gawk dependency
[not found] ` <87d07cx660.fsf@blind.guru>
@ 2020-05-09 20:32 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-05-09 20:32 UTC (permalink / raw)
To: buildroot
Mario, Fabrice, All,
On 2020-05-09 21:24 +0200, Mario Lang spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> writes:
> > On 2020-05-08 18:28 +0200, Fabrice Fontaine spake thusly:
> >> host-gawk is used by brltty to build brlapi_constants.h, the build will
> >> fail if mawk is used instead of gawk
> >>
> >> Fixes:
> >> -
> >> http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743
> >>
> >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> >
> > It seemed like a simple patch, but I can't reproduce the error with mawk
> > on my machine:
> >
> > $ update-alternatives --get-selections |grep awk
> > awk manual /usr/bin/mawk
> > $ awk --version
> > awk: not an option: --version
> > $ wget -O .config
> > http://autobuild.buildroot.org/results/4c77f03cbc7ab9e5ae9f24fe6eead1d76c50c743/config
> > $ make olddefconfig
> > $ make brltty
> >
> > Success...
> >
> > So, there is something else lurking in the darkness... :-/
>
> Maybe... However, upstream indeed requires gawk (more or less by accident).
> This came up just recently while debugging a problem a user had.
So I did further research, and indeed it fails if awk is mawk, and gawk
is not installed on the system. Indeed, AC_PROG_AWK will actually search
for gawk, then mawk, then awk.
So my test above was flawed, as I stil did get gawk installed. I retried
on a system without gawk, and I could reproduce the error.
Patch applied to master, thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-09 20:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 16:28 [Buildroot] [PATCH 1/1] package/brltty: add host-gawk dependency Fabrice Fontaine
2020-05-08 20:26 ` Yann E. MORIN
[not found] ` <87d07cx660.fsf@blind.guru>
2020-05-09 20:32 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.