* [PATCH net] net: dsa: loop: Add module soft dependency
@ 2020-05-09 23:45 Florian Fainelli
2020-05-10 18:40 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2020-05-09 23:45 UTC (permalink / raw)
To: netdev
Cc: kuba, Florian Fainelli, Andrew Lunn, Vivien Didelot,
David S. Miller, open list
There is a soft dependency against dsa_loop_bdinfo.ko which sets up the
MDIO device registration, since there are no symbols referenced by
dsa_loop.ko, there is no automatic loading of dsa_loop_bdinfo.ko which
is needed.
Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/dsa/dsa_loop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index fdcb70b9f0e4..400207c5c7de 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -360,6 +360,7 @@ static void __exit dsa_loop_exit(void)
}
module_exit(dsa_loop_exit);
+MODULE_SOFTDEP("pre: dsa_loop_bdinfo");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Florian Fainelli");
MODULE_DESCRIPTION("DSA loopback driver");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: dsa: loop: Add module soft dependency
2020-05-09 23:45 [PATCH net] net: dsa: loop: Add module soft dependency Florian Fainelli
@ 2020-05-10 18:40 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-05-10 18:40 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Andrew Lunn, Vivien Didelot, David S. Miller, open list
On Sat, 9 May 2020 16:45:44 -0700 Florian Fainelli wrote:
> There is a soft dependency against dsa_loop_bdinfo.ko which sets up the
> MDIO device registration, since there are no symbols referenced by
> dsa_loop.ko, there is no automatic loading of dsa_loop_bdinfo.ko which
> is needed.
>
> Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-10 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 23:45 [PATCH net] net: dsa: loop: Add module soft dependency Florian Fainelli
2020-05-10 18:40 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.