All of lore.kernel.org
 help / color / mirror / Atom feed
* [omap:serdev-ngsm-pending-v5.7 20/29] drivers/gnss/motmdm.c:71:5: sparse: sparse: symbol 'motmdm_gnss_send_command' was not declared. Should it be static?
@ 2020-05-10 15:36 ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-10 15:36 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: kbuild-all, linux-omap, Pavel Machek

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git serdev-ngsm-pending-v5.7
head:   4eda51fea6be98ca5a4023a988b102bf3629b295
commit: ae348e86a0abccb615c8875a95d63f10268f1c4f [20/29] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-191-gc51a0382-dirty
        git checkout ae348e86a0abccb615c8875a95d63f10268f1c4f
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/gnss/motmdm.c:71:5: sparse: sparse: symbol 'motmdm_gnss_send_command' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [omap:serdev-ngsm-pending-v5.7 20/29] drivers/gnss/motmdm.c:71:5: sparse: sparse: symbol 'motmdm_gnss_send_command' was not declared. Should it be static?
@ 2020-05-10 15:36 ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-10 15:36 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git serdev-ngsm-pending-v5.7
head:   4eda51fea6be98ca5a4023a988b102bf3629b295
commit: ae348e86a0abccb615c8875a95d63f10268f1c4f [20/29] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-191-gc51a0382-dirty
        git checkout ae348e86a0abccb615c8875a95d63f10268f1c4f
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/gnss/motmdm.c:71:5: sparse: sparse: symbol 'motmdm_gnss_send_command' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [RFC PATCH omap] gnss: motmdm: motmdm_gnss_send_command() can be static
  2020-05-10 15:36 ` kbuild test robot
@ 2020-05-10 15:36   ` kbuild test robot
  -1 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-10 15:36 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: kbuild-all, linux-omap, Pavel Machek


Fixes: ae348e86a0ab ("gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 motmdm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gnss/motmdm.c b/drivers/gnss/motmdm.c
index da1d44bed899d..49d4580ae3eae 100644
--- a/drivers/gnss/motmdm.c
+++ b/drivers/gnss/motmdm.c
@@ -68,8 +68,8 @@ MODULE_PARM_DESC(rate_ms, "GNSS refresh rate between 1000 and 16000 ms (default
  * sort out the ID conflicts with the modem's unsolicited message ID
  * numbering.
  */
-int motmdm_gnss_send_command(struct motmdm_gnss_data *ddata,
-			     const u8 *buf, int len)
+static int motmdm_gnss_send_command(struct motmdm_gnss_data *ddata,
+				    const u8 *buf, int len)
 {
 	struct gnss_device *gdev = ddata->gdev;
 	const int timeout_ms = 1000;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [RFC PATCH omap] gnss: motmdm: motmdm_gnss_send_command() can be static
@ 2020-05-10 15:36   ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2020-05-10 15:36 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]


Fixes: ae348e86a0ab ("gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 motmdm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gnss/motmdm.c b/drivers/gnss/motmdm.c
index da1d44bed899d..49d4580ae3eae 100644
--- a/drivers/gnss/motmdm.c
+++ b/drivers/gnss/motmdm.c
@@ -68,8 +68,8 @@ MODULE_PARM_DESC(rate_ms, "GNSS refresh rate between 1000 and 16000 ms (default
  * sort out the ID conflicts with the modem's unsolicited message ID
  * numbering.
  */
-int motmdm_gnss_send_command(struct motmdm_gnss_data *ddata,
-			     const u8 *buf, int len)
+static int motmdm_gnss_send_command(struct motmdm_gnss_data *ddata,
+				    const u8 *buf, int len)
 {
 	struct gnss_device *gdev = ddata->gdev;
 	const int timeout_ms = 1000;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-10 15:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10 15:36 [omap:serdev-ngsm-pending-v5.7 20/29] drivers/gnss/motmdm.c:71:5: sparse: sparse: symbol 'motmdm_gnss_send_command' was not declared. Should it be static? kbuild test robot
2020-05-10 15:36 ` kbuild test robot
2020-05-10 15:36 ` [RFC PATCH omap] gnss: motmdm: motmdm_gnss_send_command() can be static kbuild test robot
2020-05-10 15:36   ` kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.