All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Richard Hughes <hughsient@gmail.com>
Cc: Mario Limonciello <Mario.Limonciello@dell.com>,
	Platform Driver <platform-driver-x86@vger.kernel.org>,
	linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: Export LPC attributes for the system SPI chip
Date: Mon, 11 May 2020 13:45:04 +0300	[thread overview]
Message-ID: <20200511104504.GK487496@lahna.fi.intel.com> (raw)
In-Reply-To: <CAD2FfiG2c4iXmTjUpQAUqRVBVyH0Hm4VfO5PBTXf03VXHR22ng@mail.gmail.com>

On Fri, May 08, 2020 at 05:15:07PM +0100, Richard Hughes wrote:
> On Fri, 8 May 2020 at 09:20, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > Thanks for the information. I actually prefer that this would be in a
> > separate driver because I do not want distros to enable intel-spi just
> > for this. It is really only meant for special setups where firmware
> > upgrade/access flow has been thoroughly tested.
> 
> Do you think the driver should be part of mtd (e.g. something like
> drivers/mtd/spi-nor/controllers/intel-spi-pci-lpc.c) or be something
> like I proposed in drivers/platform/x86? Ideas very welcome, thanks.

I think you may want to look at drivers/mfd/lpc_ich.c and see if some of
this can be placed there. It is the "LPC" driver that binds to the
LPC/eSPI PCI device so it already has at least some of these PCI IDs.

  reply	other threads:[~2020-05-11 10:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 15:52 [PATCH] platform/x86: Export LPC attributes for the system SPI chip Richard Hughes
2020-05-06 16:29 ` Andy Shevchenko
2020-05-06 16:39   ` Richard Hughes
2020-05-07 17:05 ` Javier Martinez Canillas
2020-05-07 17:22   ` Andy Shevchenko
2020-05-07 17:28     ` Javier Martinez Canillas
2020-05-07 17:45 ` Mario.Limonciello
2020-05-07 17:45   ` Mario.Limonciello
2020-05-07 18:47   ` Richard Hughes
2020-05-07 19:22     ` Mario.Limonciello
2020-05-07 19:22       ` Mario.Limonciello
2020-05-07 19:49       ` Richard Hughes
2020-05-07 20:03         ` Mario.Limonciello
2020-05-07 20:03           ` Mario.Limonciello
2020-05-08  8:20           ` Mika Westerberg
2020-05-08 16:15             ` Richard Hughes
2020-05-11 10:45               ` Mika Westerberg [this message]
2020-05-11 15:40                 ` Richard Hughes
2020-05-11 16:28                   ` Mika Westerberg
2020-05-11 20:08                     ` Richard Hughes
2020-05-12  6:44                       ` Mika Westerberg
2020-05-12 20:37                         ` Richard Hughes
2020-05-08 17:27             ` Mario.Limonciello
2020-05-08 17:27               ` Mario.Limonciello
2020-05-11 10:41               ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511104504.GK487496@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=hughsient@gmail.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.