All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node
@ 2020-04-07  6:42 Biwen Li
  2020-04-07  6:42 ` [RESEND 2/4] arm64: dts: ls1028a: Add " Biwen Li
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Biwen Li @ 2020-04-07  6:42 UTC (permalink / raw)
  To: shawnguo, ran.wang_1, robh+dt, mark.rutland
  Cc: devicetree, linux-kernel, jiafei.pan, Biwen Li

From: Biwen Li <biwen.li@nxp.com>

The patch adds ftm_alarm0 DT node for Soc LX2160A
FlexTimer1 module is used to wakeup the system in deep sleep

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index e5ee5591e52b..e0d8d68ce070 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -16,6 +16,10 @@
 	#address-cells = <2>;
 	#size-cells = <2>;
 
+	aliases {
+		rtc1 = &ftm_alarm0;
+	};
+
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
@@ -768,6 +772,20 @@
 			timeout-sec = <30>;
 		};
 
+		rcpm: rcpm@1e34040 {
+			compatible = "fsl,lx2160a-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1e34040 0x0 0x1c>;
+			#fsl,rcpm-wakeup-cells = <7>;
+			little-endian;
+		};
+
+		ftm_alarm0: timer@2800000 {
+			compatible = "fsl,lx2160a-ftm-alarm";
+			reg = <0x0 0x2800000 0x0 0x10000>;
+			fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0 0x0>;
+			interrupts = <0 44 4>;
+		};
+
 		usb0: usb@3100000 {
 			compatible = "snps,dwc3";
 			reg = <0x0 0x3100000 0x0 0x10000>;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [RESEND 2/4] arm64: dts: ls1028a: Add ftm_alarm0 DT node
  2020-04-07  6:42 [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
@ 2020-04-07  6:42 ` Biwen Li
  2020-04-07  6:42 ` [RESEND 3/4] arm64: dts: ls1012a/ls1043a/ls1046a/ls1088a/ls208xa: add ftm_alarm0 node Biwen Li
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Biwen Li @ 2020-04-07  6:42 UTC (permalink / raw)
  To: shawnguo, ran.wang_1, robh+dt, mark.rutland
  Cc: devicetree, linux-kernel, jiafei.pan, Biwen Li

From: Biwen Li <biwen.li@nxp.com>

The patch adds ftm_alarm0 DT node for LS1028ARDB board
FlexTimer1 module is used to wakeup the system

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 0bf375ec959b..98233fe61037 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -17,6 +17,10 @@
 	#address-cells = <2>;
 	#size-cells = <2>;
 
+	aliases {
+		rtc1 = &ftm_alarm0;
+	};
+
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
@@ -724,6 +728,19 @@
 				little-endian;
 			};
 		};
+
+		rcpm: rcpm@1e34040 {
+			compatible = "fsl,ls1028a-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1e34040 0x0 0x1c>;
+			#fsl,rcpm-wakeup-cells = <7>;
+		};
+
+		ftm_alarm0: timer@2800000 {
+			compatible = "fsl,ls1028a-ftm-alarm";
+			reg = <0x0 0x2800000 0x0 0x10000>;
+			fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0 0x0>;
+			interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+		};
 	};
 
 	malidp0: display@f080000 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [RESEND 3/4] arm64: dts: ls1012a/ls1043a/ls1046a/ls1088a/ls208xa: add ftm_alarm0 node
  2020-04-07  6:42 [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
  2020-04-07  6:42 ` [RESEND 2/4] arm64: dts: ls1028a: Add " Biwen Li
@ 2020-04-07  6:42 ` Biwen Li
  2020-04-07  6:42 ` [RESEND 4/4] arm: dts: ls1021a: add ftm_alarm0 DT node Biwen Li
  2020-04-26 13:17 ` [RESEND 1/4] arm64: dts: lx2160a: " Shawn Guo
  3 siblings, 0 replies; 8+ messages in thread
From: Biwen Li @ 2020-04-07  6:42 UTC (permalink / raw)
  To: shawnguo, ran.wang_1, robh+dt, mark.rutland
  Cc: devicetree, linux-kernel, jiafei.pan, Biwen Li

From: Biwen Li <biwen.li@nxp.com>

The patch adds ftm_alarm0 DT node
	- add new rcpm node
	- add ftm_alarm0 node
	- aliases ftm_alarm0 as rtc1

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15 +++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 15 +++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 14 ++++++++++++++
 arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 14 ++++++++++++++
 5 files changed, 72 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index 337919366dc8..ab8b19f4d750 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -22,6 +22,7 @@
 		rtic-c = &rtic_c;
 		rtic-d = &rtic_d;
 		sec-mon = &sec_mon;
+		rtc1 = &ftm_alarm0;
 	};
 
 	cpus {
@@ -499,6 +500,20 @@
 					<0000 0 0 4 &gic 0 113 IRQ_TYPE_LEVEL_HIGH>;
 			status = "disabled";
 		};
+
+		rcpm: rcpm@1ee2140 {
+			compatible = "fsl,ls1012a-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1ee2140 0x0 0x4>;
+			#fsl,rcpm-wakeup-cells = <1>;
+		};
+
+		ftm_alarm0: timer@29d0000 {
+			compatible = "fsl,ls1012a-ftm-alarm";
+			reg = <0x0 0x29d0000 0x0 0x10000>;
+			fsl,rcpm-wakeup = <&rcpm 0x20000>;
+			interrupts = <0 86 0x4>;
+			big-endian;
+		};
 	};
 
 	firmware {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index c084c7a4b6a6..9dbcec8058de 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -27,6 +27,7 @@
 		ethernet4 = &enet4;
 		ethernet5 = &enet5;
 		ethernet6 = &enet6;
+		rtc1 = &ftm_alarm0;
 	};
 
 	cpus {
@@ -764,6 +765,19 @@
 			big-endian;
 		};
 
+		rcpm: rcpm@1ee208c {
+			compatible = "fsl,ls1043a-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1ee208c 0x0 0x4>;
+			#fsl,rcpm-wakeup-cells = <1>;
+		};
+
+		ftm_alarm0: timer@29d0000 {
+			compatible = "fsl,ls1043a-ftm-alarm";
+			reg = <0x0 0x29d0000 0x0 0x10000>;
+			fsl,rcpm-wakeup = <&rcpm 0x20000>;
+			interrupts = <0 86 0x4>;
+			big-endian;
+		};
 	};
 
 	firmware {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index d4c1da3d4bde..acd6125fb7d3 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -28,6 +28,7 @@
 		ethernet5 = &enet5;
 		ethernet6 = &enet6;
 		ethernet7 = &enet7;
+		rtc1 = &ftm_alarm0;
 	};
 
 	cpus {
@@ -765,6 +766,20 @@
 			queue-sizes = <64 64>;
 			big-endian;
 		};
+
+		rcpm: rcpm@1ee208c {
+			compatible = "fsl,ls1046a-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1ee208c 0x0 0x4>;
+			#fsl,rcpm-wakeup-cells = <1>;
+		};
+
+		ftm_alarm0: timer@29d0000 {
+			compatible = "fsl,ls1046a-ftm-alarm";
+			reg = <0x0 0x29d0000 0x0 0x10000>;
+			fsl,rcpm-wakeup = <&rcpm 0x20000>;
+			interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+			big-endian;
+		};
 	};
 
 	reserved-memory {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 594566265e3d..bd8528f224b3 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -18,6 +18,7 @@
 
 	aliases {
 		crypto = &crypto;
+		rtc1 = &ftm_alarm0;
 	};
 
 	cpus {
@@ -777,6 +778,19 @@
 				};
 			};
 		};
+
+		rcpm: rcpm@1e34040 {
+			compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1e34040 0x0 0x18>;
+			#fsl,rcpm-wakeup-cells = <6>;
+		};
+
+		ftm_alarm0: timer@2800000 {
+			compatible = "fsl,ls1088a-ftm-alarm";
+			reg = <0x0 0x2800000 0x0 0x10000>;
+			fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0>;
+			interrupts = <0 44 4>;
+		};
 	};
 
 	firmware {
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index f96d06da96be..0e06b0e12cd3 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -24,6 +24,7 @@
 		serial1 = &serial1;
 		serial2 = &serial2;
 		serial3 = &serial3;
+		rtc1 = &ftm_alarm0;
 	};
 
 	cpu: cpus {
@@ -759,6 +760,19 @@
 			reg = <0x0 0x04000000 0x0 0x01000000>;
 			interrupts = <0 12 4>;
 		};
+
+		rcpm: rcpm@1e34040 {
+			compatible = "fsl,ls208xa-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1e34040 0x0 0x18>;
+			#fsl,rcpm-wakeup-cells = <6>;
+		};
+
+		ftm_alarm0: timer@2800000 {
+			compatible = "fsl,ls208xa-ftm-alarm";
+			reg = <0x0 0x2800000 0x0 0x10000>;
+			fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0>;
+			interrupts = <0 44 4>;
+		};
 	};
 
 	ddr1: memory-controller@1080000 {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [RESEND 4/4] arm: dts: ls1021a: add ftm_alarm0 DT node
  2020-04-07  6:42 [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
  2020-04-07  6:42 ` [RESEND 2/4] arm64: dts: ls1028a: Add " Biwen Li
  2020-04-07  6:42 ` [RESEND 3/4] arm64: dts: ls1012a/ls1043a/ls1046a/ls1088a/ls208xa: add ftm_alarm0 node Biwen Li
@ 2020-04-07  6:42 ` Biwen Li
  2020-04-26 13:17 ` [RESEND 1/4] arm64: dts: lx2160a: " Shawn Guo
  3 siblings, 0 replies; 8+ messages in thread
From: Biwen Li @ 2020-04-07  6:42 UTC (permalink / raw)
  To: shawnguo, ran.wang_1, robh+dt, mark.rutland
  Cc: devicetree, linux-kernel, jiafei.pan, Biwen Li

From: Biwen Li <biwen.li@nxp.com>

The patch add ftm_alarm0 DT node
	- add rcpm node
	- add ftm_alarm0 node
	- aliases ftm_alarm0 as rtc1

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 0855b1fe98e0..7bb7bb130b41 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -66,6 +66,7 @@
 		serial4 = &lpuart4;
 		serial5 = &lpuart5;
 		sysclk = &sysclk;
+		rtc1 = &ftm_alarm0;
 	};
 
 	cpus {
@@ -1002,5 +1003,19 @@
 			big-endian;
 		};
 
+		rcpm: rcpm@1ee2140 {
+			compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1+";
+			reg = <0x0 0x1ee2140 0x0 0x8>;
+			#fsl,rcpm-wakeup-cells = <2>;
+		};
+
+		ftm_alarm0: timer0@29d0000 {
+			compatible = "fsl,ls1021a-ftm-alarm";
+			reg = <0x0 0x29d0000 0x0 0x10000>;
+			reg-names = "ftm";
+			fsl,rcpm-wakeup = <&rcpm 0x20000 0x0>;
+			interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
+			big-endian;
+		};
 	};
 };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node
  2020-04-07  6:42 [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
                   ` (2 preceding siblings ...)
  2020-04-07  6:42 ` [RESEND 4/4] arm: dts: ls1021a: add ftm_alarm0 DT node Biwen Li
@ 2020-04-26 13:17 ` Shawn Guo
  2020-05-08  9:35   ` Biwen Li (OSS)
  3 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2020-04-26 13:17 UTC (permalink / raw)
  To: Biwen Li
  Cc: ran.wang_1, robh+dt, mark.rutland, devicetree, linux-kernel,
	jiafei.pan, Biwen Li

On Tue, Apr 07, 2020 at 02:42:48PM +0800, Biwen Li wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> The patch adds ftm_alarm0 DT node for Soc LX2160A
> FlexTimer1 module is used to wakeup the system in deep sleep
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index e5ee5591e52b..e0d8d68ce070 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -16,6 +16,10 @@
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>  
> +	aliases {
> +		rtc1 = &ftm_alarm0;
> +	};
> +
>  	cpus {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> @@ -768,6 +772,20 @@
>  			timeout-sec = <30>;
>  		};
>  
> +		rcpm: rcpm@1e34040 {

Keep the node sort in unit-address.  Also, try to use a generic node
name.

Shawn

> +			compatible = "fsl,lx2160a-rcpm", "fsl,qoriq-rcpm-2.1+";
> +			reg = <0x0 0x1e34040 0x0 0x1c>;
> +			#fsl,rcpm-wakeup-cells = <7>;
> +			little-endian;
> +		};
> +
> +		ftm_alarm0: timer@2800000 {
> +			compatible = "fsl,lx2160a-ftm-alarm";
> +			reg = <0x0 0x2800000 0x0 0x10000>;
> +			fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0 0x0>;
> +			interrupts = <0 44 4>;

IRQ_TYPE_LEVEL_HIGH

Shawn

> +		};
> +
>  		usb0: usb@3100000 {
>  			compatible = "snps,dwc3";
>  			reg = <0x0 0x3100000 0x0 0x10000>;
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node
  2020-04-26 13:17 ` [RESEND 1/4] arm64: dts: lx2160a: " Shawn Guo
@ 2020-05-08  9:35   ` Biwen Li (OSS)
  2020-05-11 14:16     ` Shawn Guo
  0 siblings, 1 reply; 8+ messages in thread
From: Biwen Li (OSS) @ 2020-05-08  9:35 UTC (permalink / raw)
  To: Shawn Guo, Biwen Li (OSS)
  Cc: Ran Wang, robh+dt, mark.rutland, devicetree, linux-kernel, Jiafei Pan

> 
> On Tue, Apr 07, 2020 at 02:42:48PM +0800, Biwen Li wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> >
> > The patch adds ftm_alarm0 DT node for Soc LX2160A
> > FlexTimer1 module is used to wakeup the system in deep sleep
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 18
> > ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > index e5ee5591e52b..e0d8d68ce070 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > @@ -16,6 +16,10 @@
> >  	#address-cells = <2>;
> >  	#size-cells = <2>;
> >
> > +	aliases {
> > +		rtc1 = &ftm_alarm0;
> > +	};
> > +
> >  	cpus {
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> > @@ -768,6 +772,20 @@
> >  			timeout-sec = <30>;
> >  		};
> >
> > +		rcpm: rcpm@1e34040 {
> 
> Keep the node sort in unit-address.  Also, try to use a generic node name.
Hi Shawn,
Sorry for late reply.
The node sort will be updated in v2.
rcpm is called as Run Control and Power Management. Don't
Have a generic node name, any suggestions?

> 
> Shawn
> 
> > +			compatible = "fsl,lx2160a-rcpm", "fsl,qoriq-rcpm-2.1+";
> > +			reg = <0x0 0x1e34040 0x0 0x1c>;
> > +			#fsl,rcpm-wakeup-cells = <7>;
> > +			little-endian;
> > +		};
> > +
> > +		ftm_alarm0: timer@2800000 {
> > +			compatible = "fsl,lx2160a-ftm-alarm";
> > +			reg = <0x0 0x2800000 0x0 0x10000>;
> > +			fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0 0x0>;
> > +			interrupts = <0 44 4>;
> 
> IRQ_TYPE_LEVEL_HIGH
Got it, thanks. Will replace it in v2.
> 
> Shawn
> 
> > +		};
> > +
> >  		usb0: usb@3100000 {
> >  			compatible = "snps,dwc3";
> >  			reg = <0x0 0x3100000 0x0 0x10000>;
> > --
> > 2.17.1
> >

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node
  2020-05-08  9:35   ` Biwen Li (OSS)
@ 2020-05-11 14:16     ` Shawn Guo
  2020-05-20  8:27       ` Biwen Li (OSS)
  0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2020-05-11 14:16 UTC (permalink / raw)
  To: Biwen Li (OSS)
  Cc: Ran Wang, robh+dt, mark.rutland, devicetree, linux-kernel, Jiafei Pan

On Fri, May 08, 2020 at 09:35:47AM +0000, Biwen Li (OSS) wrote:
> > 
> > On Tue, Apr 07, 2020 at 02:42:48PM +0800, Biwen Li wrote:
> > > From: Biwen Li <biwen.li@nxp.com>
> > >
> > > The patch adds ftm_alarm0 DT node for Soc LX2160A
> > > FlexTimer1 module is used to wakeup the system in deep sleep
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 18
> > > ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > index e5ee5591e52b..e0d8d68ce070 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > @@ -16,6 +16,10 @@
> > >  	#address-cells = <2>;
> > >  	#size-cells = <2>;
> > >
> > > +	aliases {
> > > +		rtc1 = &ftm_alarm0;
> > > +	};
> > > +
> > >  	cpus {
> > >  		#address-cells = <1>;
> > >  		#size-cells = <0>;
> > > @@ -768,6 +772,20 @@
> > >  			timeout-sec = <30>;
> > >  		};
> > >
> > > +		rcpm: rcpm@1e34040 {
> > 
> > Keep the node sort in unit-address.  Also, try to use a generic node name.
> Hi Shawn,
> Sorry for late reply.
> The node sort will be updated in v2.
> rcpm is called as Run Control and Power Management. Don't
> Have a generic node name, any suggestions?

It sounds like some sort of power controller, so maybe 'power-controller'?

Shawn

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node
  2020-05-11 14:16     ` Shawn Guo
@ 2020-05-20  8:27       ` Biwen Li (OSS)
  0 siblings, 0 replies; 8+ messages in thread
From: Biwen Li (OSS) @ 2020-05-20  8:27 UTC (permalink / raw)
  To: Shawn Guo, Biwen Li (OSS)
  Cc: Ran Wang, robh+dt, mark.rutland, devicetree, linux-kernel, Jiafei Pan



> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > index e5ee5591e52b..e0d8d68ce070 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > @@ -16,6 +16,10 @@
> > > >  	#address-cells = <2>;
> > > >  	#size-cells = <2>;
> > > >
> > > > +	aliases {
> > > > +		rtc1 = &ftm_alarm0;
> > > > +	};
> > > > +
> > > >  	cpus {
> > > >  		#address-cells = <1>;
> > > >  		#size-cells = <0>;
> > > > @@ -768,6 +772,20 @@
> > > >  			timeout-sec = <30>;
> > > >  		};
> > > >
> > > > +		rcpm: rcpm@1e34040 {
> > >
> > > Keep the node sort in unit-address.  Also, try to use a generic node name.
> > Hi Shawn,
> > Sorry for late reply.
> > The node sort will be updated in v2.
> > rcpm is called as Run Control and Power Management. Don't Have a
> > generic node name, any suggestions?
> 
> It sounds like some sort of power controller, so maybe 'power-controller'?
Okay, How about replace it with "rcpm: power-controller@1e34040 {"?
> 
> Shawn

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-05-20  8:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07  6:42 [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
2020-04-07  6:42 ` [RESEND 2/4] arm64: dts: ls1028a: Add " Biwen Li
2020-04-07  6:42 ` [RESEND 3/4] arm64: dts: ls1012a/ls1043a/ls1046a/ls1088a/ls208xa: add ftm_alarm0 node Biwen Li
2020-04-07  6:42 ` [RESEND 4/4] arm: dts: ls1021a: add ftm_alarm0 DT node Biwen Li
2020-04-26 13:17 ` [RESEND 1/4] arm64: dts: lx2160a: " Shawn Guo
2020-05-08  9:35   ` Biwen Li (OSS)
2020-05-11 14:16     ` Shawn Guo
2020-05-20  8:27       ` Biwen Li (OSS)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.