All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-pm@vger.kernel.org, robh@kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	"Pali Rohár" <pali@kernel.org>, "Andrew F . Davis" <afd@ti.com>
Subject: Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml
Date: Mon, 11 May 2020 16:32:41 +0200	[thread overview]
Message-ID: <20200511143241.nmkti7meahvj2swt@earth.universe> (raw)
In-Reply-To: <fb9b240e-9bfe-1295-6fc4-700d886ea7c9@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]

Hi,

On Mon, May 11, 2020 at 07:25:06AM -0500, Dan Murphy wrote:
> On 5/10/20 11:17 AM, Sebastian Reichel wrote:
> > This needs is missing the power-supplies property. The N900 DT
> > contains a bq27200 referencing the charger, so it should fail the DT
> > check without the property being listed here.
> 
> Hmm.  I ran the dt checker specifically on the binding and it did not fail. 
> Unless I need to build some other DTs as well.
> Either I will have the power-supplies property

I just tried it myself. The problem is the way you are specifying
the compatible strings. This is the parsing result:

enum: ['ti,bq27200 - BQ27200', 'ti,bq27210 - BQ27210', 'ti,bq27500 - deprecated,
      use revision specific property below', ...

You can see this in Documentation/devicetree/bindings/processed-schema.yaml, which
is generated by running the check. The compatible comments need a # as separation
character like this to generate proper bindings:

properties:    
  compatible:    
    enum:    
      - ti,bq27200 # BQ27200    
      - ti,bq27210 # BQ27210    
      - ti,bq27500 # deprecated, use revision specific property below

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-05-11 14:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 18:30 [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml Dan Murphy
2020-05-10 16:17 ` Sebastian Reichel
2020-05-11 12:25   ` Dan Murphy
2020-05-11 14:32     ` Sebastian Reichel [this message]
2020-05-11 14:29       ` Dan Murphy
2020-05-11 14:57         ` Sebastian Reichel
2020-05-11 14:55           ` Dan Murphy
2020-05-11 15:30             ` Sebastian Reichel
2020-05-11 19:06               ` Dan Murphy
2020-05-11 15:22 ` Andrew F. Davis
2020-05-11 15:23   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511143241.nmkti7meahvj2swt@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.