From: Dan Murphy <dmurphy@ti.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: linux-pm@vger.kernel.org, robh@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>, "Andrew F . Davis" <afd@ti.com>
Subject: Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml
Date: Mon, 11 May 2020 09:29:59 -0500 [thread overview]
Message-ID: <8674289c-038d-d811-4786-322d66072527@ti.com> (raw)
In-Reply-To: <20200511143241.nmkti7meahvj2swt@earth.universe>
Sebastian
On 5/11/20 9:32 AM, Sebastian Reichel wrote:
> Hi,
>
> On Mon, May 11, 2020 at 07:25:06AM -0500, Dan Murphy wrote:
>> On 5/10/20 11:17 AM, Sebastian Reichel wrote:
>>> This needs is missing the power-supplies property. The N900 DT
>>> contains a bq27200 referencing the charger, so it should fail the DT
>>> check without the property being listed here.
>> Hmm. I ran the dt checker specifically on the binding and it did not fail.
>> Unless I need to build some other DTs as well.
>> Either I will have the power-supplies property
> I just tried it myself. The problem is the way you are specifying
> the compatible strings. This is the parsing result:
>
> enum: ['ti,bq27200 - BQ27200', 'ti,bq27210 - BQ27210', 'ti,bq27500 - deprecated,
> use revision specific property below', ...
>
> You can see this in Documentation/devicetree/bindings/processed-schema.yaml, which
> is generated by running the check. The compatible comments need a # as separation
> character like this to generate proper bindings:
>
> properties:
> compatible:
> enum:
> - ti,bq27200 # BQ27200
> - ti,bq27210 # BQ27210
> - ti,bq27500 # deprecated, use revision specific property below
Well honestly not sure why we need the comment either. These are
pretty self explanatory maybe we should just remove the additional comments
Any consideration on just removing the deprecated values?
Dan
>
> -- Sebastian
next prev parent reply other threads:[~2020-05-11 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 18:30 [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml Dan Murphy
2020-05-10 16:17 ` Sebastian Reichel
2020-05-11 12:25 ` Dan Murphy
2020-05-11 14:32 ` Sebastian Reichel
2020-05-11 14:29 ` Dan Murphy [this message]
2020-05-11 14:57 ` Sebastian Reichel
2020-05-11 14:55 ` Dan Murphy
2020-05-11 15:30 ` Sebastian Reichel
2020-05-11 19:06 ` Dan Murphy
2020-05-11 15:22 ` Andrew F. Davis
2020-05-11 15:23 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8674289c-038d-d811-4786-322d66072527@ti.com \
--to=dmurphy@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.