From: David Miller <davem at davemloft.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net] mptcp: Initialize map_seq upon subflow establishment
Date: Tue, 12 May 2020 12:09:11 -0700 [thread overview]
Message-ID: <20200512.120911.2258216308785425487.davem@davemloft.net> (raw)
In-Reply-To: 6b0594845f7787b9bc82c845321e23b6bc3bca38.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
From: Paolo Abeni <pabeni(a)redhat.com>
Date: Mon, 11 May 2020 19:35:21 +0200
> On Mon, 2020-05-11 at 09:24 -0700, Christoph Paasch wrote:
>> When the other MPTCP-peer uses 32-bit data-sequence numbers, we rely on
>> map_seq to indicate how to expand to a 64-bit data-sequence number in
>> expand_seq() when receiving data.
>>
>> For new subflows, this field is not initialized, thus results in an
>> "invalid" mapping being discarded.
>>
>> Fix this by initializing map_seq upon subflow establishment time.
>>
>> Fixes: f296234c98a8 ("mptcp: Add handling of incoming MP_JOIN requests")
>> Signed-off-by: Christoph Paasch <cpaasch(a)apple.com>
...
> Reviewed-by: Paolo Abeni <pabeni(a)redhat.com>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: cpaasch@apple.com, kuba@kernel.org, netdev@vger.kernel.org,
mptcp@lists.01.org
Subject: Re: [MPTCP] [PATCH net] mptcp: Initialize map_seq upon subflow establishment
Date: Tue, 12 May 2020 12:09:11 -0700 (PDT) [thread overview]
Message-ID: <20200512.120911.2258216308785425487.davem@davemloft.net> (raw)
In-Reply-To: <6b0594845f7787b9bc82c845321e23b6bc3bca38.camel@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Mon, 11 May 2020 19:35:21 +0200
> On Mon, 2020-05-11 at 09:24 -0700, Christoph Paasch wrote:
>> When the other MPTCP-peer uses 32-bit data-sequence numbers, we rely on
>> map_seq to indicate how to expand to a 64-bit data-sequence number in
>> expand_seq() when receiving data.
>>
>> For new subflows, this field is not initialized, thus results in an
>> "invalid" mapping being discarded.
>>
>> Fix this by initializing map_seq upon subflow establishment time.
>>
>> Fixes: f296234c98a8 ("mptcp: Add handling of incoming MP_JOIN requests")
>> Signed-off-by: Christoph Paasch <cpaasch@apple.com>
...
> Reviewed-by: Paolo Abeni <pabeni@redhat.com>
Applied, thanks.
next reply other threads:[~2020-05-12 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 19:09 David Miller [this message]
2020-05-12 19:09 ` [MPTCP] [PATCH net] mptcp: Initialize map_seq upon subflow establishment David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-05-11 17:35 [MPTCP] " Paolo Abeni
2020-05-11 17:35 ` [MPTCP] " Paolo Abeni
2020-05-11 16:24 Christoph Paasch
2020-05-11 16:24 ` Christoph Paasch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512.120911.2258216308785425487.davem@davemloft.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.