All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ting Xu <ting.xu@intel.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com,
	bernard.iremonger@intel.com, xiaolong.ye@intel.com,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix DCB set failure
Date: Tue, 12 May 2020 10:13:56 +0000	[thread overview]
Message-ID: <20200512101356.23729-1-ting.xu@intel.com> (raw)
In-Reply-To: <20200511102504.23936-1-ting.xu@intel.com>

When set DCB in testpmd, there is a segmentation fault. It is
because the local variable rss_conf in get_eth_dcb_conf()
is not cleared, so that the pointer member variable rss_key has
a random address, which leads to an error in the following
processing. This patch initialized the local variable rss_conf
to avoid this situation.

Fixes: ac7c491c3fec ("app/testpmd: fix DCB config")
Cc: stable@dpdk.org

Signed-off-by: Ting Xu <ting.xu@intel.com>

---
v1->v2: modify commit log, move memset to else leg
---
 app/test-pmd/testpmd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a2d0be56b..9ad34421c 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3448,6 +3448,8 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf *eth_conf,
 		struct rte_eth_dcb_tx_conf *tx_conf =
 				&eth_conf->tx_adv_conf.dcb_tx_conf;
 
+		memset(&rss_conf, 0, sizeof(struct rte_eth_rss_conf));
+
 		rc = rte_eth_dev_rss_hash_conf_get(pid, &rss_conf);
 		if (rc != 0)
 			return rc;
-- 
2.17.1


  parent reply	other threads:[~2020-05-12  2:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 10:25 [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang Ting Xu
2020-05-11  5:12 ` Xing, Beilei
2020-05-11  7:50 ` Huang, ZhiminX
2020-05-11 16:29 ` Ferruh Yigit
2020-05-12  2:17   ` Xu, Ting
2020-05-12 11:42     ` Iremonger, Bernard
2020-05-12 10:13 ` Ting Xu [this message]
2020-05-18 17:06   ` [dpdk-dev] [PATCH v2] app/testpmd: fix DCB set failure Ferruh Yigit
2020-05-13  9:50 ` [dpdk-dev] [PATCH v3] " Ting Xu
2020-05-13 10:07 ` [dpdk-dev] [PATCH v4] " Ting Xu
2020-05-13  8:54   ` Iremonger, Bernard
2020-05-13 12:58     ` Thomas Monjalon
2020-05-13 17:16 ` [dpdk-dev] [PATCH v5] ethdev: " Ting Xu
2020-05-13 13:28   ` Ferruh Yigit
2020-05-18 16:24     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-13 15:54   ` [dpdk-dev] " Iremonger, Bernard
2020-05-18 13:32   ` Andrew Rybchenko
2020-05-18 14:57     ` Matan Azrad
2020-05-18 16:21       ` Ferruh Yigit
2020-05-18 16:20     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200512101356.23729-1-ting.xu@intel.com \
    --to=ting.xu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.