Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang

["Xing, Beilei" <beilei.xing@intel.com>]

> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Monday, May 11, 2020 6:25 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang
> 
> When set DCB in testpmd by clang, there is a segmentation fault.
> It is because the local variable rss_conf in get_eth_dcb_conf() is not cleared,
> so that the pointer member variable rss_key has a random address, which
> leads to an error in the following processing. This patch initialized the local
> variable rss_conf to avoid random address.
> 
> Fixes: b57b66a97ebf ("app/testpmd: support mbuf dynamic flag")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ting Xu <ting.xu@intel.com>
> ---
>  app/test-pmd/testpmd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 99bacddbf..1276476ca 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3408,6 +3408,7 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf
> *eth_conf,
>  	int32_t rc;
>  	struct rte_eth_rss_conf rss_conf;
> 
> +	memset(&rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>  	/*
>  	 * Builds up the correct configuration for dcb+vt based on the vlan
> tags array
>  	 * given above, and the number of traffic classes available for use.
> --
> 2.17.1

Acked-by: Beilei Xing <beilei.xing@intel.com>