* [OE-core][PATCH] llvm: Remove -fcommon
@ 2020-05-12 14:14 Adrian Bunk
2020-05-12 15:17 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2020-05-12 14:14 UTC (permalink / raw)
To: openembedded-core
I cannot reproduce the problem.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
meta/recipes-devtools/llvm/llvm_git.bb | 2 --
1 file changed, 2 deletions(-)
diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb
index a8607f5008..d24ed761bf 100644
--- a/meta/recipes-devtools/llvm/llvm_git.bb
+++ b/meta/recipes-devtools/llvm/llvm_git.bb
@@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_class-nativesdk = "\
-DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \
"
-CFLAGS += "-fcommon"
-
do_configure_prepend() {
# Fix paths in llvm-config
sed -i "s|sys::path::parent_path(CurrentPath))\.str()|sys::path::parent_path(sys::path::parent_path(CurrentPath))).str()|g" ${S}/tools/llvm-config/llvm-config.cpp
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core][PATCH] llvm: Remove -fcommon
2020-05-12 14:14 [OE-core][PATCH] llvm: Remove -fcommon Adrian Bunk
@ 2020-05-12 15:17 ` Khem Raj
2020-05-12 15:33 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2020-05-12 15:17 UTC (permalink / raw)
To: Adrian Bunk, openembedded-core
On 5/12/20 7:14 AM, Adrian Bunk wrote:
> I cannot reproduce the problem.
>
have you built the target recipe with gcc10 with -fno-common default ?
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> ---
> meta/recipes-devtools/llvm/llvm_git.bb | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb
> index a8607f5008..d24ed761bf 100644
> --- a/meta/recipes-devtools/llvm/llvm_git.bb
> +++ b/meta/recipes-devtools/llvm/llvm_git.bb
> @@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_class-nativesdk = "\
> -DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \
> "
>
> -CFLAGS += "-fcommon"
> -
> do_configure_prepend() {
> # Fix paths in llvm-config
> sed -i "s|sys::path::parent_path(CurrentPath))\.str()|sys::path::parent_path(sys::path::parent_path(CurrentPath))).str()|g" ${S}/tools/llvm-config/llvm-config.cpp
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core][PATCH] llvm: Remove -fcommon
2020-05-12 15:17 ` Khem Raj
@ 2020-05-12 15:33 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2020-05-12 15:33 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On Tue, May 12, 2020 at 08:17:15AM -0700, Khem Raj wrote:
> On 5/12/20 7:14 AM, Adrian Bunk wrote:
> > I cannot reproduce the problem.
>
> have you built the target recipe with gcc10 with -fno-common default ?
Yes.
For menu-cache and matchbox-wm I got failures without the patches,
but not for llvm.
cu
Adrian
^ permalink raw reply [flat|nested] 4+ messages in thread
* [OE-core][PATCH] llvm: Remove -fcommon
@ 2020-05-12 13:55 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2020-05-12 13:55 UTC (permalink / raw)
To: openembedded-devel
I cannot reproduce the problem.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
meta/recipes-devtools/llvm/llvm_git.bb | 2 --
1 file changed, 2 deletions(-)
diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb
index a8607f5008..d24ed761bf 100644
--- a/meta/recipes-devtools/llvm/llvm_git.bb
+++ b/meta/recipes-devtools/llvm/llvm_git.bb
@@ -92,8 +92,6 @@ EXTRA_OECMAKE_append_class-nativesdk = "\
-DLLVM_CONFIG_PATH=${STAGING_BINDIR_NATIVE}/llvm-config${PV} \
"
-CFLAGS += "-fcommon"
-
do_configure_prepend() {
# Fix paths in llvm-config
sed -i "s|sys::path::parent_path(CurrentPath))\.str()|sys::path::parent_path(sys::path::parent_path(CurrentPath))).str()|g" ${S}/tools/llvm-config/llvm-config.cpp
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-12 15:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 14:14 [OE-core][PATCH] llvm: Remove -fcommon Adrian Bunk
2020-05-12 15:17 ` Khem Raj
2020-05-12 15:33 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2020-05-12 13:55 Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.