From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: linux-net-drivers@solarflare.com, ecree@solarflare.com,
mhabets@solarflare.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] sfc: fix dereference of table before it is null checked
Date: Wed, 13 May 2020 15:20:28 -0700 (PDT) [thread overview]
Message-ID: <20200513.152028.653894441720284438.davem@davemloft.net> (raw)
In-Reply-To: <20200512171355.221810-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 May 2020 18:13:55 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently pointer table is being dereferenced on a null check of
> table->must_restore_filters before it is being null checked, leading
> to a potential null pointer dereference issue. Fix this by null
> checking table before dereferencing it when checking for a null
> table->must_restore_filters.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: linux-net-drivers@solarflare.com, ecree@solarflare.com,
mhabets@solarflare.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] sfc: fix dereference of table before it is null checked
Date: Wed, 13 May 2020 22:20:28 +0000 [thread overview]
Message-ID: <20200513.152028.653894441720284438.davem@davemloft.net> (raw)
In-Reply-To: <20200512171355.221810-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 12 May 2020 18:13:55 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently pointer table is being dereferenced on a null check of
> table->must_restore_filters before it is being null checked, leading
> to a potential null pointer dereference issue. Fix this by null
> checking table before dereferencing it when checking for a null
> table->must_restore_filters.
>
> Addresses-Coverity: ("Dereference before null check")
> Fixes: e4fe938cff04 ("sfc: move 'must restore' flags out of ef10-specific nic_data")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
next prev parent reply other threads:[~2020-05-13 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 17:13 [PATCH][next] sfc: fix dereference of table before it is null checked Colin King
2020-05-12 17:13 ` Colin King
2020-05-13 9:39 ` Edward Cree
2020-05-13 9:39 ` Edward Cree
2020-05-13 22:20 ` David Miller [this message]
2020-05-13 22:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513.152028.653894441720284438.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=ecree@solarflare.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.