All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: mvneta: speed down the PHY, if WoL used, to save energy
@ 2020-05-12 17:59 Daniel González Cabanelas
  2020-05-13 22:21 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel González Cabanelas @ 2020-05-12 17:59 UTC (permalink / raw)
  To: netdev; +Cc: davem, thomas.petazzoni

Some PHYs connected to this ethernet hardware support the WoL feature.
But when WoL is enabled and the machine is powered off, the PHY remains
waiting for a magic packet at max speed (i.e. 1Gbps), which is a waste of
energy.

Slow down the PHY speed before stopping the ethernet if WoL is enabled,
and save some energy while the machine is powered off or sleeping.

Tested using an Armada 370 based board (LS421DE) equipped with a Marvell
88E1518 PHY.

Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>
---
 drivers/net/ethernet/marvell/mvneta.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 5188977095..e0e9e56830 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3561,6 +3561,10 @@ static void mvneta_start_dev(struct mvneta_port *pp)
 		    MVNETA_CAUSE_LINK_CHANGE);
 
 	phylink_start(pp->phylink);
+
+	/* We may have called phy_speed_down before */
+	phy_speed_up(pp->dev->phydev);
+
 	netif_tx_start_all_queues(pp->dev);
 }
 
@@ -3568,6 +3572,9 @@ static void mvneta_stop_dev(struct mvneta_port *pp)
 {
 	unsigned int cpu;
 
+	if (device_may_wakeup(&pp->dev->dev))
+		phy_speed_down(pp->dev->phydev, false);
+
 	phylink_stop(pp->phylink);
 
 	if (!pp->neta_armada3700) {
@@ -4040,6 +4047,10 @@ static int mvneta_mdio_probe(struct mvneta_port *pp)
 	phylink_ethtool_get_wol(pp->phylink, &wol);
 	device_set_wakeup_capable(&pp->dev->dev, !!wol.supported);
 
+	/* PHY WoL may be enabled but device wakeup disabled */
+	if (wol.supported)
+		device_set_wakeup_enable(&pp->dev->dev, !!wol.wolopts);
+
 	return err;
 }
 
-- 
2.26.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: mvneta: speed down the PHY, if WoL used, to save energy
  2020-05-12 17:59 [PATCH] net: mvneta: speed down the PHY, if WoL used, to save energy Daniel González Cabanelas
@ 2020-05-13 22:21 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-13 22:21 UTC (permalink / raw)
  To: dgcbueu; +Cc: netdev, thomas.petazzoni

From: Daniel González Cabanelas <dgcbueu@gmail.com>
Date: Tue, 12 May 2020 19:59:48 +0200

> Some PHYs connected to this ethernet hardware support the WoL feature.
> But when WoL is enabled and the machine is powered off, the PHY remains
> waiting for a magic packet at max speed (i.e. 1Gbps), which is a waste of
> energy.
> 
> Slow down the PHY speed before stopping the ethernet if WoL is enabled,
> and save some energy while the machine is powered off or sleeping.
> 
> Tested using an Armada 370 based board (LS421DE) equipped with a Marvell
> 88E1518 PHY.
> 
> Signed-off-by: Daniel González Cabanelas <dgcbueu@gmail.com>

Applied to net-next, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-13 22:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 17:59 [PATCH] net: mvneta: speed down the PHY, if WoL used, to save energy Daniel González Cabanelas
2020-05-13 22:21 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.