All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robin Gong <yibin.gong@nxp.com>
Cc: vkoul@kernel.org, shawnguo@kernel.org,
	u.kleine-koenig@pengutronix.de, robh+dt@kernel.org,
	festevam@gmail.com, dan.j.williams@intel.com,
	mark.rutland@arm.com, catalin.marinas@arm.com,
	will.deacon@arm.com, l.stach@pengutronix.de,
	martin.fuzzey@flowbird.group, kernel@pengutronix.de,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-imx@nxp.com,
	dmaengine@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v7 RESEND 00/13] add ecspi ERR009165 for i.mx6/7 soc family
Date: Wed, 13 May 2020 09:20:13 +0200	[thread overview]
Message-ID: <20200513072012.GB15934@pengutronix.de> (raw)
In-Reply-To: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com>

On Tue, May 12, 2020 at 01:32:23AM +0800, Robin Gong wrote:
> There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> transfer to be send twice in DMA mode. Please get more information from:
> https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding
> new sdma ram script which works in XCH  mode as PIO inside sdma instead
> of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. The issue should be
> exist on all legacy i.mx6/7 soc family before i.mx6ul.
> NXP fix this design issue from i.mx6ul, so newer chips including i.mx6ul/
> 6ull/6sll do not need this workaroud anymore. All other i.mx6/7/8 chips
> still need this workaroud. This patch set add new 'fsl,imx6ul-ecspi'
> for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need errata
> or not.
> The first two reverted patches should be the same issue, though, it
> seems 'fixed' by changing to other shp script. Hope Sean or Sascha could
> have the chance to test this patch set if could fix their issues.
> Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> on i.mx8mm because the event id is zero.

It's not nice to break SPI support when the new firmware is not present
and I think we can do better. Wouldn't it be possible to fall back to PIO
in this case?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Robin Gong <yibin.gong@nxp.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	catalin.marinas@arm.com, kernel@pengutronix.de,
	shawnguo@kernel.org, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	vkoul@kernel.org, robh+dt@kernel.org, linux-imx@nxp.com,
	martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de,
	dmaengine@vger.kernel.org, dan.j.williams@intel.com,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org,
	l.stach@pengutronix.de
Subject: Re: [PATCH v7 RESEND 00/13] add ecspi ERR009165 for i.mx6/7 soc family
Date: Wed, 13 May 2020 09:20:13 +0200	[thread overview]
Message-ID: <20200513072012.GB15934@pengutronix.de> (raw)
In-Reply-To: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com>

On Tue, May 12, 2020 at 01:32:23AM +0800, Robin Gong wrote:
> There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> transfer to be send twice in DMA mode. Please get more information from:
> https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding
> new sdma ram script which works in XCH  mode as PIO inside sdma instead
> of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. The issue should be
> exist on all legacy i.mx6/7 soc family before i.mx6ul.
> NXP fix this design issue from i.mx6ul, so newer chips including i.mx6ul/
> 6ull/6sll do not need this workaroud anymore. All other i.mx6/7/8 chips
> still need this workaroud. This patch set add new 'fsl,imx6ul-ecspi'
> for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need errata
> or not.
> The first two reverted patches should be the same issue, though, it
> seems 'fixed' by changing to other shp script. Hope Sean or Sascha could
> have the chance to test this patch set if could fix their issues.
> Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> on i.mx8mm because the event id is zero.

It's not nice to break SPI support when the new firmware is not present
and I think we can do better. Wouldn't it be possible to fall back to PIO
in this case?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-05-13  7:20 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 17:32 [PATCH v7 RESEND 00/13] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2020-05-11 17:32 ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 01/13] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 02/13] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache" Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-13  6:05   ` Sascha Hauer
2020-05-13  6:05     ` Sascha Hauer
2020-05-13  7:12     ` Fuzzey, Martin
2020-05-13  7:12       ` Fuzzey, Martin
2020-05-13  8:06       ` Robin Gong
2020-05-13  8:06         ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 04/13] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 05/13] dmaengine: imx-sdma: remove dupilicated sdma_load_context Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-13  6:05   ` Sascha Hauer
2020-05-13  6:05     ` Sascha Hauer
2020-05-13  8:04     ` Robin Gong
2020-05-13  8:04       ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 06/13] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165 Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-13  7:21   ` Sascha Hauer
2020-05-13  7:21     ` Sascha Hauer
2020-05-13  8:38     ` Robin Gong
2020-05-13  8:38       ` Robin Gong
2020-05-13  8:48       ` Sascha Hauer
2020-05-13  8:48         ` Sascha Hauer
2020-05-13  8:52         ` Robin Gong
2020-05-13  8:52           ` Robin Gong
2020-05-13  9:20           ` Sascha Hauer
2020-05-13  9:20             ` Sascha Hauer
2020-05-13 15:48             ` Robin Gong
2020-05-13 15:48               ` Robin Gong
2020-05-13  7:33   ` Sascha Hauer
2020-05-13  7:33     ` Sascha Hauer
2020-05-13  9:05     ` Robin Gong
2020-05-13  9:05       ` Robin Gong
2020-05-13  9:20       ` Sascha Hauer
2020-05-13  9:20         ` Sascha Hauer
2020-05-13  9:36         ` Robin Gong
2020-05-13  9:36           ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 08/13] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 09/13] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 10/13] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 11/13] dma: imx-sdma: add i.mx6ul compatible name Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 12/13] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-11 17:32 ` [PATCH v7 RESEND 13/13] dmaengine: imx-sdma: add uart rom script Robin Gong
2020-05-11 17:32   ` Robin Gong
2020-05-13 21:06   ` Fabio Estevam
2020-05-13 21:06     ` Fabio Estevam
2020-05-14  1:45     ` Robin Gong
2020-05-14  1:45       ` Robin Gong
2020-05-13  7:20 ` Sascha Hauer [this message]
2020-05-13  7:20   ` [PATCH v7 RESEND 00/13] add ecspi ERR009165 for i.mx6/7 soc family Sascha Hauer
2020-05-13  8:20   ` Robin Gong
2020-05-13  8:20     ` Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513072012.GB15934@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.fuzzey@flowbird.group \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vkoul@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.