All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: Fix query_srq_cmd() function
Date: Wed, 13 May 2020 13:14:21 +0300	[thread overview]
Message-ID: <20200513101421.GU4814@unreal> (raw)
In-Reply-To: <20200513100031.GT4814@unreal>

On Wed, May 13, 2020 at 01:00:31PM +0300, Leon Romanovsky wrote:
> On Wed, May 13, 2020 at 12:37:41PM +0300, Dan Carpenter wrote:
> > The "srq_out" pointer is never freed so that causes a memory leak.  It's
> > never used and can be deleted.  Freeing "out" will lead to a double in
> > mlx5_ib_query_srq().
> >
> > Fixes: 31578defe4eb ("RDMA/mlx5: Update mlx5_ib to use new cmd interface")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  drivers/infiniband/hw/mlx5/srq_cmd.c | 11 ++---------
> >  1 file changed, 2 insertions(+), 9 deletions(-)
> >
>
> Thanks for the report, the change should be slightly different.
>
> I'm sending fix right now.

https://lore.kernel.org/linux-rdma/20200513100809.246315-1-leon@kernel.org

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: Fix query_srq_cmd() function
Date: Wed, 13 May 2020 10:14:21 +0000	[thread overview]
Message-ID: <20200513101421.GU4814@unreal> (raw)
In-Reply-To: <20200513100031.GT4814@unreal>

On Wed, May 13, 2020 at 01:00:31PM +0300, Leon Romanovsky wrote:
> On Wed, May 13, 2020 at 12:37:41PM +0300, Dan Carpenter wrote:
> > The "srq_out" pointer is never freed so that causes a memory leak.  It's
> > never used and can be deleted.  Freeing "out" will lead to a double in
> > mlx5_ib_query_srq().
> >
> > Fixes: 31578defe4eb ("RDMA/mlx5: Update mlx5_ib to use new cmd interface")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  drivers/infiniband/hw/mlx5/srq_cmd.c | 11 ++---------
> >  1 file changed, 2 insertions(+), 9 deletions(-)
> >
>
> Thanks for the report, the change should be slightly different.
>
> I'm sending fix right now.

https://lore.kernel.org/linux-rdma/20200513100809.246315-1-leon@kernel.org

  reply	other threads:[~2020-05-13 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13  9:37 [PATCH] RDMA/mlx5: Fix query_srq_cmd() function Dan Carpenter
2020-05-13  9:37 ` Dan Carpenter
2020-05-13 10:00 ` Leon Romanovsky
2020-05-13 10:00   ` Leon Romanovsky
2020-05-13 10:14   ` Leon Romanovsky [this message]
2020-05-13 10:14     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513101421.GU4814@unreal \
    --to=leon@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.