* [PATCH] cpuidle: Delete unused define_one_ro/rw macros
@ 2020-05-13 10:17 Pascal Terjan
2020-05-14 11:47 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Pascal Terjan @ 2020-05-13 10:17 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, linux-pm; +Cc: Pascal Terjan
They were already unused when cpuidle was introduced.
Signed-off-by: Pascal Terjan <pterjan@google.com>
---
drivers/cpuidle/sysfs.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
index cdeedbf02646..7729cf622d1e 100644
--- a/drivers/cpuidle/sysfs.c
+++ b/drivers/cpuidle/sysfs.c
@@ -167,11 +167,6 @@ struct cpuidle_attr {
ssize_t (*store)(struct cpuidle_device *, const char *, size_t count);
};
-#define define_one_ro(_name, show) \
- static struct cpuidle_attr attr_##_name = __ATTR(_name, 0444, show, NULL)
-#define define_one_rw(_name, show, store) \
- static struct cpuidle_attr attr_##_name = __ATTR(_name, 0644, show, store)
-
#define attr_to_cpuidleattr(a) container_of(a, struct cpuidle_attr, attr)
struct cpuidle_device_kobj {
--
2.26.2.645.ge9eca65c58-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpuidle: Delete unused define_one_ro/rw macros
2020-05-13 10:17 [PATCH] cpuidle: Delete unused define_one_ro/rw macros Pascal Terjan
@ 2020-05-14 11:47 ` Rafael J. Wysocki
2020-05-14 18:07 ` Pascal Terjan
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2020-05-14 11:47 UTC (permalink / raw)
To: Pascal Terjan; +Cc: Rafael J. Wysocki, Daniel Lezcano, Linux PM
On Wed, May 13, 2020 at 12:18 PM Pascal Terjan <pterjan@google.com> wrote:
>
> They were already unused when cpuidle was introduced.
>
> Signed-off-by: Pascal Terjan <pterjan@google.com>
> ---
> drivers/cpuidle/sysfs.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index cdeedbf02646..7729cf622d1e 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -167,11 +167,6 @@ struct cpuidle_attr {
> ssize_t (*store)(struct cpuidle_device *, const char *, size_t count);
> };
>
> -#define define_one_ro(_name, show) \
> - static struct cpuidle_attr attr_##_name = __ATTR(_name, 0444, show, NULL)
> -#define define_one_rw(_name, show, store) \
> - static struct cpuidle_attr attr_##_name = __ATTR(_name, 0644, show, store)
> -
> #define attr_to_cpuidleattr(a) container_of(a, struct cpuidle_attr, attr)
>
> struct cpuidle_device_kobj {
> --
This patch doesn't apply on top of the cpuidle material for 5.8
present in linux-next, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpuidle: Delete unused define_one_ro/rw macros
2020-05-14 11:47 ` Rafael J. Wysocki
@ 2020-05-14 18:07 ` Pascal Terjan
2020-05-15 6:38 ` Hanjun Guo
0 siblings, 1 reply; 4+ messages in thread
From: Pascal Terjan @ 2020-05-14 18:07 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Rafael J. Wysocki, Daniel Lezcano, Linux PM
On Thu, 14 May 2020 at 12:47, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, May 13, 2020 at 12:18 PM Pascal Terjan <pterjan@google.com> wrote:
> >
> > They were already unused when cpuidle was introduced.
> >
> > Signed-off-by: Pascal Terjan <pterjan@google.com>
> > ---
> > drivers/cpuidle/sysfs.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> > index cdeedbf02646..7729cf622d1e 100644
> > --- a/drivers/cpuidle/sysfs.c
> > +++ b/drivers/cpuidle/sysfs.c
> > @@ -167,11 +167,6 @@ struct cpuidle_attr {
> > ssize_t (*store)(struct cpuidle_device *, const char *, size_t count);
> > };
> >
> > -#define define_one_ro(_name, show) \
> > - static struct cpuidle_attr attr_##_name = __ATTR(_name, 0444, show, NULL)
> > -#define define_one_rw(_name, show, store) \
> > - static struct cpuidle_attr attr_##_name = __ATTR(_name, 0644, show, store)
> > -
> > #define attr_to_cpuidleattr(a) container_of(a, struct cpuidle_attr, attr)
> >
> > struct cpuidle_device_kobj {
> > --
>
> This patch doesn't apply on top of the cpuidle material for 5.8
> present in linux-next, thanks!
Funny timing, it was actually already done a few weeks ago after all
those years :)
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=2f516e7cbe88f05023b6cc458d3a22b7dc56af99
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpuidle: Delete unused define_one_ro/rw macros
2020-05-14 18:07 ` Pascal Terjan
@ 2020-05-15 6:38 ` Hanjun Guo
0 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2020-05-15 6:38 UTC (permalink / raw)
To: Pascal Terjan, Rafael J. Wysocki
Cc: Rafael J. Wysocki, Daniel Lezcano, Linux PM
On 2020/5/15 2:07, Pascal Terjan wrote:
> On Thu, 14 May 2020 at 12:47, Rafael J. Wysocki <rafael@kernel.org> wrote:
>>
>> On Wed, May 13, 2020 at 12:18 PM Pascal Terjan <pterjan@google.com> wrote:
>>>
>>> They were already unused when cpuidle was introduced.
>>>
>>> Signed-off-by: Pascal Terjan <pterjan@google.com>
>>> ---
>>> drivers/cpuidle/sysfs.c | 5 -----
>>> 1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
>>> index cdeedbf02646..7729cf622d1e 100644
>>> --- a/drivers/cpuidle/sysfs.c
>>> +++ b/drivers/cpuidle/sysfs.c
>>> @@ -167,11 +167,6 @@ struct cpuidle_attr {
>>> ssize_t (*store)(struct cpuidle_device *, const char *, size_t count);
>>> };
>>>
>>> -#define define_one_ro(_name, show) \
>>> - static struct cpuidle_attr attr_##_name = __ATTR(_name, 0444, show, NULL)
>>> -#define define_one_rw(_name, show, store) \
>>> - static struct cpuidle_attr attr_##_name = __ATTR(_name, 0644, show, store)
>>> -
>>> #define attr_to_cpuidleattr(a) container_of(a, struct cpuidle_attr, attr)
>>>
>>> struct cpuidle_device_kobj {
>>> --
>>
>> This patch doesn't apply on top of the cpuidle material for 5.8
>> present in linux-next, thanks!
>
> Funny timing, it was actually already done a few weeks ago after all
> those years :)
> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=2f516e7cbe88f05023b6cc458d3a22b7dc56af99
It is :)
I spotted it when trying to make cpudile governor switchable to
be the default behaviour [0].
[0]: https://patchwork.kernel.org/cover/11519511/
Thanks
Hanjun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-15 6:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 10:17 [PATCH] cpuidle: Delete unused define_one_ro/rw macros Pascal Terjan
2020-05-14 11:47 ` Rafael J. Wysocki
2020-05-14 18:07 ` Pascal Terjan
2020-05-15 6:38 ` Hanjun Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.