From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matej Dujava <mdujava@kocurkovo.cz>
Cc: Forest Bond <forest@alittletooquiet.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
Date: Wed, 13 May 2020 13:56:00 +0200 [thread overview]
Message-ID: <20200513115600.GB953616@kroah.com> (raw)
In-Reply-To: <1589105615-22271-3-git-send-email-mdujava@kocurkovo.cz>
On Sun, May 10, 2020 at 12:13:35PM +0200, Matej Dujava wrote:
> This patch will add indentation to multiline variable and put obj-$(CONFIG_X)
> at the begining of the file.
Why change the order? What does that fix? Why do this? You say what
you do here, but not why. And without that, I can't see the reason to
accept this patch :(
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Matej Dujava <mdujava@kocurkovo.cz>
Cc: devel@driverdev.osuosl.org,
Forest Bond <forest@alittletooquiet.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions
Date: Wed, 13 May 2020 13:56:00 +0200 [thread overview]
Message-ID: <20200513115600.GB953616@kroah.com> (raw)
In-Reply-To: <1589105615-22271-3-git-send-email-mdujava@kocurkovo.cz>
On Sun, May 10, 2020 at 12:13:35PM +0200, Matej Dujava wrote:
> This patch will add indentation to multiline variable and put obj-$(CONFIG_X)
> at the begining of the file.
Why change the order? What does that fix? Why do this? You say what
you do here, but not why. And without that, I can't see the reason to
accept this patch :(
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-13 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 10:13 [PATCH v2 0/2] staging: vt6656: vt6655: cleaning Makefile Matej Dujava
2020-05-10 10:13 ` Matej Dujava
2020-05-10 10:13 ` [PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles Matej Dujava
2020-05-10 10:13 ` Matej Dujava
2020-05-13 11:55 ` Greg Kroah-Hartman
2020-05-13 11:55 ` Greg Kroah-Hartman
2020-05-10 10:13 ` [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions Matej Dujava
2020-05-10 10:13 ` Matej Dujava
2020-05-13 11:56 ` Greg Kroah-Hartman [this message]
2020-05-13 11:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513115600.GB953616@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mdujava@kocurkovo.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.