All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel/reproducibility: use specified environment settings
@ 2020-05-13 14:36 Bruce Ashfield
  2020-05-13 15:02 ` ✗ patchtest: failure for " Patchwork
  0 siblings, 1 reply; 2+ messages in thread
From: Bruce Ashfield @ 2020-05-13 14:36 UTC (permalink / raw)
  To: richard.purdie; +Cc: openembedded-core, steve

From: Bruce Ashfield <bruce.ashfield@gmail.com>

The routine to get the timestamp of the kernel commits should
specify LC_ALL to ensure consistent behaviour. We were making
a copy of the env, adding the setting .. and then not using it
on the call.

We specifiy the env in the subprocess call to ensure the
variable is available.

Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
---

This is the incremental patch to my previous series. Squash as required!

Bruce

 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index f31084948f..3ac91fbd4f 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -164,7 +164,7 @@ def get_kernel_source_date_epoch(d):
 
     env = os.environ.copy()
     env['LC_ALL'] = 'C'
-    ts = subprocess.check_output(['date', '-d @%s' % s_d_e]).decode('utf-8')
+    ts = subprocess.check_output(['date', '-d @%s' % s_d_e], env=env).decode('utf-8')
 
     return ts
 
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-13 15:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 14:36 [PATCH] kernel/reproducibility: use specified environment settings Bruce Ashfield
2020-05-13 15:02 ` ✗ patchtest: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.