* [PATCH V2 0/6 linux-next] fs/notify: cleanup
@ 2020-05-12 18:16 Fabian Frederick
2020-05-12 18:32 ` Amir Goldstein
0 siblings, 1 reply; 5+ messages in thread
From: Fabian Frederick @ 2020-05-12 18:16 UTC (permalink / raw)
To: jack, amir73il; +Cc: linux-fsdevel, Fabian Frederick
This small patchset does some cleanup in fs/notify branch
especially in fanotify.
V2:
Apply Amir Goldstein suggestions:
-Remove patch 2, 7 and 9
-Patch "fanotify: don't write with zero size" ->
"fanotify: don't write with size under sizeof(response)"
Fabian Frederick (6):
fanotify: prefix should_merge()
notify: explicit shutdown initialization
notify: add mutex destroy
fanotify: remove reference to fill_event_metadata()
fsnotify/fdinfo: remove proc_fs.h inclusion
fanotify: don't write with size under sizeof(response)
fs/notify/fanotify/fanotify.c | 4 ++--
fs/notify/fanotify/fanotify_user.c | 8 +++++---
fs/notify/fdinfo.c | 1 -
fs/notify/group.c | 2 ++
4 files changed, 9 insertions(+), 6 deletions(-)
--
2.26.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup
2020-05-12 18:16 [PATCH V2 0/6 linux-next] fs/notify: cleanup Fabian Frederick
@ 2020-05-12 18:32 ` Amir Goldstein
2020-05-13 11:08 ` Jan Kara
0 siblings, 1 reply; 5+ messages in thread
From: Amir Goldstein @ 2020-05-12 18:32 UTC (permalink / raw)
To: Fabian Frederick; +Cc: Jan Kara, linux-fsdevel
On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
>
> This small patchset does some cleanup in fs/notify branch
> especially in fanotify.
Patches look fine to me.
I would just change the subject of patches from notify: to fsnotify:.
The patch "explicit shutdown initialization" is border line unneeded
and its subject is not very descriptive.
Let's wait and see what Jan has to say before you post another round.
Thanks,
Amir.
>
> V2:
> Apply Amir Goldstein suggestions:
> -Remove patch 2, 7 and 9
> -Patch "fanotify: don't write with zero size" ->
> "fanotify: don't write with size under sizeof(response)"
>
> Fabian Frederick (6):
> fanotify: prefix should_merge()
> notify: explicit shutdown initialization
> notify: add mutex destroy
> fanotify: remove reference to fill_event_metadata()
> fsnotify/fdinfo: remove proc_fs.h inclusion
> fanotify: don't write with size under sizeof(response)
>
> fs/notify/fanotify/fanotify.c | 4 ++--
> fs/notify/fanotify/fanotify_user.c | 8 +++++---
> fs/notify/fdinfo.c | 1 -
> fs/notify/group.c | 2 ++
> 4 files changed, 9 insertions(+), 6 deletions(-)
>
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup
2020-05-12 18:32 ` Amir Goldstein
@ 2020-05-13 11:08 ` Jan Kara
2020-05-13 11:10 ` Amir Goldstein
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kara @ 2020-05-13 11:08 UTC (permalink / raw)
To: Amir Goldstein; +Cc: Fabian Frederick, Jan Kara, linux-fsdevel
On Tue 12-05-20 21:32:10, Amir Goldstein wrote:
> On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
> >
> > This small patchset does some cleanup in fs/notify branch
> > especially in fanotify.
>
> Patches look fine to me.
> I would just change the subject of patches from notify: to fsnotify:.
> The patch "explicit shutdown initialization" is border line unneeded
> and its subject is not very descriptive.
> Let's wait and see what Jan has to say before you post another round.
Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add
your Reviewed-by Amir when merging them?
Honza
> > V2:
> > Apply Amir Goldstein suggestions:
> > -Remove patch 2, 7 and 9
> > -Patch "fanotify: don't write with zero size" ->
> > "fanotify: don't write with size under sizeof(response)"
> >
> > Fabian Frederick (6):
> > fanotify: prefix should_merge()
> > notify: explicit shutdown initialization
> > notify: add mutex destroy
> > fanotify: remove reference to fill_event_metadata()
> > fsnotify/fdinfo: remove proc_fs.h inclusion
> > fanotify: don't write with size under sizeof(response)
> >
> > fs/notify/fanotify/fanotify.c | 4 ++--
> > fs/notify/fanotify/fanotify_user.c | 8 +++++---
> > fs/notify/fdinfo.c | 1 -
> > fs/notify/group.c | 2 ++
> > 4 files changed, 9 insertions(+), 6 deletions(-)
> >
> > --
> > 2.26.2
> >
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup
2020-05-13 11:08 ` Jan Kara
@ 2020-05-13 11:10 ` Amir Goldstein
2020-05-13 15:35 ` Jan Kara
0 siblings, 1 reply; 5+ messages in thread
From: Amir Goldstein @ 2020-05-13 11:10 UTC (permalink / raw)
To: Jan Kara; +Cc: Fabian Frederick, linux-fsdevel
On Wed, May 13, 2020 at 2:08 PM Jan Kara <jack@suse.cz> wrote:
>
> On Tue 12-05-20 21:32:10, Amir Goldstein wrote:
> > On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
> > >
> > > This small patchset does some cleanup in fs/notify branch
> > > especially in fanotify.
> >
> > Patches look fine to me.
> > I would just change the subject of patches from notify: to fsnotify:.
> > The patch "explicit shutdown initialization" is border line unneeded
> > and its subject is not very descriptive.
> > Let's wait and see what Jan has to say before you post another round.
>
> Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add
> your Reviewed-by Amir when merging them?
Yes.
Thanks,
Amir.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup
2020-05-13 11:10 ` Amir Goldstein
@ 2020-05-13 15:35 ` Jan Kara
0 siblings, 0 replies; 5+ messages in thread
From: Jan Kara @ 2020-05-13 15:35 UTC (permalink / raw)
To: Amir Goldstein; +Cc: Jan Kara, Fabian Frederick, linux-fsdevel
On Wed 13-05-20 14:10:54, Amir Goldstein wrote:
> On Wed, May 13, 2020 at 2:08 PM Jan Kara <jack@suse.cz> wrote:
> >
> > On Tue 12-05-20 21:32:10, Amir Goldstein wrote:
> > > On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
> > > >
> > > > This small patchset does some cleanup in fs/notify branch
> > > > especially in fanotify.
> > >
> > > Patches look fine to me.
> > > I would just change the subject of patches from notify: to fsnotify:.
> > > The patch "explicit shutdown initialization" is border line unneeded
> > > and its subject is not very descriptive.
> > > Let's wait and see what Jan has to say before you post another round.
> >
> > Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add
> > your Reviewed-by Amir when merging them?
>
> Yes.
Thanks. Fabian, I've merged the cleanups to my tree.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-13 15:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 18:16 [PATCH V2 0/6 linux-next] fs/notify: cleanup Fabian Frederick
2020-05-12 18:32 ` Amir Goldstein
2020-05-13 11:08 ` Jan Kara
2020-05-13 11:10 ` Amir Goldstein
2020-05-13 15:35 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.