All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs: fix comment drop reference to volume_mutex
@ 2020-05-13 17:42 Anand Jain
  2020-05-15 17:48 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Anand Jain @ 2020-05-13 17:42 UTC (permalink / raw)
  To: linux-btrfs

No functional changes.
commit dccdb07bc996 (btrfs: kill btrfs_fs_info::volume_mutex)
killed the volume_mutex. Drop all references to volumes_mutex
including the comment sections.

Fixes: dccdb07bc996 (btrfs: kill btrfs_fs_info::volume_mutex)
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 fs/btrfs/volumes.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index be1e047a489e..60ab41c12e50 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -280,7 +280,6 @@ static int __btrfs_map_block(struct btrfs_fs_info *fs_info,
  * ============
  *
  * uuid_mutex
- *   volume_mutex
  *     device_list_mutex
  *       chunk_mutex
  *     balance_mutex
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs: fix comment drop reference to volume_mutex
  2020-05-13 17:42 [PATCH] btrfs: fix comment drop reference to volume_mutex Anand Jain
@ 2020-05-15 17:48 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2020-05-15 17:48 UTC (permalink / raw)
  To: Anand Jain; +Cc: linux-btrfs

On Thu, May 14, 2020 at 01:42:45AM +0800, Anand Jain wrote:
> No functional changes.
> commit dccdb07bc996 (btrfs: kill btrfs_fs_info::volume_mutex)
> killed the volume_mutex. Drop all references to volumes_mutex
> including the comment sections.
> 
> Fixes: dccdb07bc996 (btrfs: kill btrfs_fs_info::volume_mutex)

The right format is

Fixes: hash ("subject")

but fixing a comment does not really need that tag and be backported to
stable kernels.

> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
>  fs/btrfs/volumes.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index be1e047a489e..60ab41c12e50 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -280,7 +280,6 @@ static int __btrfs_map_block(struct btrfs_fs_info *fs_info,
>   * ============
>   *
>   * uuid_mutex
> - *   volume_mutex
>   *     device_list_mutex
>   *       chunk_mutex
>   *     balance_mutex

As this removes one level, the other locks should be un-indented. I'll
fix that, no need to resend.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-15 17:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 17:42 [PATCH] btrfs: fix comment drop reference to volume_mutex Anand Jain
2020-05-15 17:48 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.