All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency
@ 2020-05-10  8:52 Fabrice Fontaine
  2020-05-10  8:52 ` [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency Fabrice Fontaine
  2020-05-13 20:37 ` [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency Yann E. MORIN
  0 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2020-05-10  8:52 UTC (permalink / raw)
  To: buildroot

Remove tinyxml2 dependency as tinyxml2 is not a part of version 0.8.7.

Indeed, tinyxml2 has been added in September 2016 with
https://github.com/cegui/cegui/commit/49b3fd9d6f0d7555198379514b155bcd61daef67
whereas version 0.8.7 has been released in April 2016

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/cegui/cegui.mk | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
index 9640a15116..6158ef129c 100644
--- a/package/cegui/cegui.mk
+++ b/package/cegui/cegui.mk
@@ -83,13 +83,6 @@ else
 CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_TINYXML=OFF
 endif
 
-ifeq ($(BR2_PACKAGE_TINYXML2),y)
-CEGUI_DEPENDENCIES += tinyxml2
-CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_TINYXML2=ON
-else
-CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_TINYXML2=OFF
-endif
-
 ifeq ($(BR2_PACKAGE_LIBFREEIMAGE),y)
 CEGUI_DEPENDENCIES += libfreeimage
 CEGUI_CONF_OPTS += -DCEGUI_BUILD_IMAGECODEC_FREEIMAGE=ON
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency
  2020-05-10  8:52 [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency Fabrice Fontaine
@ 2020-05-10  8:52 ` Fabrice Fontaine
  2021-05-05 19:02   ` Bartosz Bilas
  2021-05-07 20:13   ` Yann E. MORIN
  2020-05-13 20:37 ` [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency Yann E. MORIN
  1 sibling, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2020-05-10  8:52 UTC (permalink / raw)
  To: buildroot

libfribidi is an optional dependency (enabled by default) since version
0.8.0 and
https://github.com/cegui/cegui/commit/17974582e6b6a7d8f5853b0272433f130f82e52a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/cegui/cegui.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
index 6158ef129c..73d0c22ce5 100644
--- a/package/cegui/cegui.mk
+++ b/package/cegui/cegui.mk
@@ -62,6 +62,13 @@ else
 CEGUI_CONF_OPTS += -DCEGUI_HAS_FREETYPE=OFF
 endif
 
+ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
+CEGUI_DEPENDENCIES += libfribidi
+CEGUI_CONF_OPTS += -DCEGUI_USE_FRIBIDI=ON
+else
+CEGUI_CONF_OPTS += -DCEGUI_USE_FRIBIDI=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_LIBXML2),y)
 CEGUI_DEPENDENCIES += libxml2
 CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_LIBXML2=ON
-- 
2.26.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency
  2020-05-10  8:52 [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency Fabrice Fontaine
  2020-05-10  8:52 ` [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency Fabrice Fontaine
@ 2020-05-13 20:37 ` Yann E. MORIN
  1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-05-13 20:37 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

On 2020-05-10 10:52 +0200, Fabrice Fontaine spake thusly:
> Remove tinyxml2 dependency as tinyxml2 is not a part of version 0.8.7.
> 
> Indeed, tinyxml2 has been added in September 2016 with
> https://github.com/cegui/cegui/commit/49b3fd9d6f0d7555198379514b155bcd61daef67
> whereas version 0.8.7 has been released in April 2016
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/cegui/cegui.mk | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
> index 9640a15116..6158ef129c 100644
> --- a/package/cegui/cegui.mk
> +++ b/package/cegui/cegui.mk
> @@ -83,13 +83,6 @@ else
>  CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_TINYXML=OFF
>  endif
>  
> -ifeq ($(BR2_PACKAGE_TINYXML2),y)
> -CEGUI_DEPENDENCIES += tinyxml2
> -CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_TINYXML2=ON
> -else
> -CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_TINYXML2=OFF
> -endif
> -
>  ifeq ($(BR2_PACKAGE_LIBFREEIMAGE),y)
>  CEGUI_DEPENDENCIES += libfreeimage
>  CEGUI_CONF_OPTS += -DCEGUI_BUILD_IMAGECODEC_FREEIMAGE=ON
> -- 
> 2.26.2
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency
  2020-05-10  8:52 ` [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency Fabrice Fontaine
@ 2021-05-05 19:02   ` Bartosz Bilas
  2021-05-07 20:13   ` Yann E. MORIN
  1 sibling, 0 replies; 6+ messages in thread
From: Bartosz Bilas @ 2021-05-05 19:02 UTC (permalink / raw)
  To: buildroot

Hello Fabrice,

On 10.05.2020 10:52, Fabrice Fontaine wrote:
> libfribidi is an optional dependency (enabled by default) since version
> 0.8.0 and
> https://github.com/cegui/cegui/commit/17974582e6b6a7d8f5853b0272433f130f82e52a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>   package/cegui/cegui.mk | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
> index 6158ef129c..73d0c22ce5 100644
> --- a/package/cegui/cegui.mk
> +++ b/package/cegui/cegui.mk
> @@ -62,6 +62,13 @@ else
>   CEGUI_CONF_OPTS += -DCEGUI_HAS_FREETYPE=OFF
>   endif
>   
> +ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
> +CEGUI_DEPENDENCIES += libfribidi
> +CEGUI_CONF_OPTS += -DCEGUI_USE_FRIBIDI=ON
> +else
> +CEGUI_CONF_OPTS += -DCEGUI_USE_FRIBIDI=OFF
> +endif
> +
>   ifeq ($(BR2_PACKAGE_LIBXML2),y)
>   CEGUI_DEPENDENCIES += libxml2
>   CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_LIBXML2=ON

Tested-by: Bartosz Bilas<b.bilas@grinn-global.com>
Reviewed-by: Bartosz Bilas<b.bilas@grinn-global.com>

Best
Bartek

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency
  2020-05-10  8:52 ` [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency Fabrice Fontaine
  2021-05-05 19:02   ` Bartosz Bilas
@ 2021-05-07 20:13   ` Yann E. MORIN
  2021-05-08 14:38     ` Peter Korsgaard
  1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2021-05-07 20:13 UTC (permalink / raw)
  To: buildroot

Fabrice, All,

On 2020-05-10 10:52 +0200, Fabrice Fontaine spake thusly:
> libfribidi is an optional dependency (enabled by default) since version
> 0.8.0 and
> https://github.com/cegui/cegui/commit/17974582e6b6a7d8f5853b0272433f130f82e52a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/cegui/cegui.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
> index 6158ef129c..73d0c22ce5 100644
> --- a/package/cegui/cegui.mk
> +++ b/package/cegui/cegui.mk
> @@ -62,6 +62,13 @@ else
>  CEGUI_CONF_OPTS += -DCEGUI_HAS_FREETYPE=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
> +CEGUI_DEPENDENCIES += libfribidi
> +CEGUI_CONF_OPTS += -DCEGUI_USE_FRIBIDI=ON
> +else
> +CEGUI_CONF_OPTS += -DCEGUI_USE_FRIBIDI=OFF
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBXML2),y)
>  CEGUI_DEPENDENCIES += libxml2
>  CEGUI_CONF_OPTS += -DCEGUI_BUILD_XMLPARSER_LIBXML2=ON
> -- 
> 2.26.2
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency
  2021-05-07 20:13   ` Yann E. MORIN
@ 2021-05-08 14:38     ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-05-08 14:38 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Fabrice, All,
 > On 2020-05-10 10:52 +0200, Fabrice Fontaine spake thusly:
 >> libfribidi is an optional dependency (enabled by default) since version
 >> 0.8.0 and
 >> https://github.com/cegui/cegui/commit/17974582e6b6a7d8f5853b0272433f130f82e52a
 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 > Applied to master, thanks.

Committed to 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-05-08 14:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10  8:52 [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency Fabrice Fontaine
2020-05-10  8:52 ` [Buildroot] [PATCH 2/2] package/cegui: add libfribidi optional dependency Fabrice Fontaine
2021-05-05 19:02   ` Bartosz Bilas
2021-05-07 20:13   ` Yann E. MORIN
2021-05-08 14:38     ` Peter Korsgaard
2020-05-13 20:37 ` [Buildroot] [PATCH 1/2] package/cegui: remove tinyxml2 dependency Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.