All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Cc: kuba@kernel.org, Amol Grover <frextrite@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Joel Fernandes <joel@joelfernandes.org>,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro
Date: Wed, 13 May 2020 21:54:41 +1000	[thread overview]
Message-ID: <20200513215441.22653800@canb.auug.org.au> (raw)
In-Reply-To: <20200512051705.GB9585@madhuparna-HP-Notebook>

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi all,

On Tue, 12 May 2020 10:47:05 +0530 Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> wrote:
> > 
> > I think what is happening is this:
> > 
> > ipmr_net_init() -> ipmr_rules_init() -> ipmr_new_table()
> > 
> > ipmr_new_table() returns an existing table if there is one, but
> > obviously none can exist at init.  So a better fix would be:
> > 
> > #define ipmr_for_each_table(mrt, net)					\
> > 	list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list,	\
> > 				lockdep_rtnl_is_held() ||		\
> > 				list_empty(&net->ipv4.mr_tables))
> >  
> (adding Stephen)

I have changed the patch in my fixes tree to this.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	Joel Fernandes <joel@joelfernandes.org>,
	kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro
Date: Wed, 13 May 2020 21:54:41 +1000	[thread overview]
Message-ID: <20200513215441.22653800@canb.auug.org.au> (raw)
In-Reply-To: <20200512051705.GB9585@madhuparna-HP-Notebook>


[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]

Hi all,

On Tue, 12 May 2020 10:47:05 +0530 Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> wrote:
> > 
> > I think what is happening is this:
> > 
> > ipmr_net_init() -> ipmr_rules_init() -> ipmr_new_table()
> > 
> > ipmr_new_table() returns an existing table if there is one, but
> > obviously none can exist at init.  So a better fix would be:
> > 
> > #define ipmr_for_each_table(mrt, net)					\
> > 	list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list,	\
> > 				lockdep_rtnl_is_held() ||		\
> > 				list_empty(&net->ipv4.mr_tables))
> >  
> (adding Stephen)

I have changed the patch in my fixes tree to this.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2020-05-13 11:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  7:22 [PATCH net 1/2 RESEND] ipmr: Fix RCU list debugging warning Amol Grover
2020-05-09  7:22 ` [Linux-kernel-mentees] " Amol Grover
2020-05-09  7:22 ` [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro Amol Grover
2020-05-09  7:22   ` [Linux-kernel-mentees] " Amol Grover
2020-05-09 21:19   ` Jakub Kicinski
2020-05-09 21:19     ` [Linux-kernel-mentees] " Jakub Kicinski
2020-05-12  5:17     ` Madhuparna Bhowmik
2020-05-12  5:17       ` [Linux-kernel-mentees] " Madhuparna Bhowmik
2020-05-12 16:32       ` Jakub Kicinski
2020-05-12 16:32         ` [Linux-kernel-mentees] " Jakub Kicinski
2020-05-13  5:34         ` Madhuparna Bhowmik
2020-05-13  5:34           ` [Linux-kernel-mentees] " Madhuparna Bhowmik
2020-05-12 17:17       ` Amol Grover
2020-05-12 17:17         ` [Linux-kernel-mentees] " Amol Grover
2020-05-12 21:59         ` Jakub Kicinski
2020-05-12 21:59           ` [Linux-kernel-mentees] " Jakub Kicinski
2020-05-13 11:54       ` Stephen Rothwell [this message]
2020-05-13 11:54         ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200513215441.22653800@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=davem@davemloft.net \
    --cc=frextrite@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=kuba@kernel.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madhuparnabhowmik10@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.