* [PATCH net] drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c
@ 2020-05-14 14:11 ` madhuparnabhowmik10
0 siblings, 0 replies; 4+ messages in thread
From: madhuparnabhowmik10 @ 2020-05-14 14:11 UTC (permalink / raw)
To: davem, allison, tglx, ap420073
Cc: netdev, linux-kernel, linux-kernel-mentees, paulmck, cai, joel,
frextrite, Madhuparna Bhowmik
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
This patch fixes the following warning:
=============================
WARNING: suspicious RCU usage
5.7.0-rc5-next-20200514-syzkaller #0 Not tainted
-----------------------------
drivers/net/hamradio/bpqether.c:149 RCU-list traversed in non-reader section!!
Since rtnl lock is held, pass this cond in list_for_each_entry_rcu().
Reported-by: syzbot+bb82cafc737c002d11ca@syzkaller.appspotmail.com
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
drivers/net/hamradio/bpqether.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index fbea6f232819..e2ad3c2e8df5 100644
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -127,7 +127,8 @@ static inline struct net_device *bpq_get_ax25_dev(struct net_device *dev)
{
struct bpqdev *bpq;
- list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list) {
+ list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list,
+ lockdep_rtnl_is_held()) {
if (bpq->ethdev == dev)
return bpq->axdev;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Linux-kernel-mentees] [PATCH net] drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c
@ 2020-05-14 14:11 ` madhuparnabhowmik10
0 siblings, 0 replies; 4+ messages in thread
From: madhuparnabhowmik10 @ 2020-05-14 14:11 UTC (permalink / raw)
To: davem, allison, tglx, ap420073
Cc: paulmck, netdev, linux-kernel, Madhuparna Bhowmik, cai, joel,
linux-kernel-mentees
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
This patch fixes the following warning:
=============================
WARNING: suspicious RCU usage
5.7.0-rc5-next-20200514-syzkaller #0 Not tainted
-----------------------------
drivers/net/hamradio/bpqether.c:149 RCU-list traversed in non-reader section!!
Since rtnl lock is held, pass this cond in list_for_each_entry_rcu().
Reported-by: syzbot+bb82cafc737c002d11ca@syzkaller.appspotmail.com
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
drivers/net/hamradio/bpqether.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c
index fbea6f232819..e2ad3c2e8df5 100644
--- a/drivers/net/hamradio/bpqether.c
+++ b/drivers/net/hamradio/bpqether.c
@@ -127,7 +127,8 @@ static inline struct net_device *bpq_get_ax25_dev(struct net_device *dev)
{
struct bpqdev *bpq;
- list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list) {
+ list_for_each_entry_rcu(bpq, &bpq_devices, bpq_list,
+ lockdep_rtnl_is_held()) {
if (bpq->ethdev == dev)
return bpq->axdev;
}
--
2.17.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c
2020-05-14 14:11 ` [Linux-kernel-mentees] " madhuparnabhowmik10
@ 2020-05-15 0:44 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-05-15 0:44 UTC (permalink / raw)
To: madhuparnabhowmik10
Cc: allison, tglx, ap420073, netdev, linux-kernel,
linux-kernel-mentees, paulmck, cai, joel, frextrite
From: madhuparnabhowmik10@gmail.com
Date: Thu, 14 May 2020 19:41:15 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> This patch fixes the following warning:
> =============================
> WARNING: suspicious RCU usage
> 5.7.0-rc5-next-20200514-syzkaller #0 Not tainted
> -----------------------------
> drivers/net/hamradio/bpqether.c:149 RCU-list traversed in non-reader section!!
>
> Since rtnl lock is held, pass this cond in list_for_each_entry_rcu().
>
> Reported-by: syzbot+bb82cafc737c002d11ca@syzkaller.appspotmail.com
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH net] drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c
@ 2020-05-15 0:44 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-05-15 0:44 UTC (permalink / raw)
To: madhuparnabhowmik10
Cc: paulmck, netdev, linux-kernel, cai, allison, joel, tglx,
linux-kernel-mentees, ap420073
From: madhuparnabhowmik10@gmail.com
Date: Thu, 14 May 2020 19:41:15 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> This patch fixes the following warning:
> =============================
> WARNING: suspicious RCU usage
> 5.7.0-rc5-next-20200514-syzkaller #0 Not tainted
> -----------------------------
> drivers/net/hamradio/bpqether.c:149 RCU-list traversed in non-reader section!!
>
> Since rtnl lock is held, pass this cond in list_for_each_entry_rcu().
>
> Reported-by: syzbot+bb82cafc737c002d11ca@syzkaller.appspotmail.com
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Applied, thanks.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-15 0:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 14:11 [PATCH net] drivers: net: hamradio: Fix suspicious RCU usage warning in bpqether.c madhuparnabhowmik10
2020-05-14 14:11 ` [Linux-kernel-mentees] " madhuparnabhowmik10
2020-05-15 0:44 ` David Miller
2020-05-15 0:44 ` [Linux-kernel-mentees] " David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.