Re: [PATCH v6 2/2] s390/kvm: diagnose 318 handling

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3175 bytes --]

Hi Collin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvms390/next]
[also build test WARNING on s390/features v5.7-rc5]
[cannot apply to kvm/linux-next next-20200512]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Collin-Walling/Use-DIAG318-to-set-Control-Program-Name-Version-Codes/20200514-061856
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

In file included from arch/s390/include/asm/kvm_host.h:22,
from include/linux/kvm_host.h:36,
from arch/s390/kvm/kvm-s390.c:23:
arch/s390/kvm/kvm-s390.c: In function 'kvm_s390_set_diag318_info':
>> arch/s390/kvm/kvm-s390.c:1253:19: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'long unsigned int:56' [-Wformat=]
1253 |  VM_EVENT(kvm, 3, "SET: CPNC: 0x%x CPVC: 0x%llx",
|                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1254 |    kvm->arch.diag318_info.cpnc, kvm->arch.diag318_info.cpvc);
|                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
|                                                       |
|                                                       long unsigned int:56
arch/s390/include/asm/debug.h:247:12: note: in definition of macro 'debug_sprintf_event'
247 |            _fmt, ## __VA_ARGS__);          |            ^~~~
>> arch/s390/kvm/kvm-s390.c:1253:2: note: in expansion of macro 'VM_EVENT'
1253 |  VM_EVENT(kvm, 3, "SET: CPNC: 0x%x CPVC: 0x%llx",
|  ^~~~~~~~
arch/s390/kvm/kvm-s390.c:1253:47: note: format string is defined here
1253 |  VM_EVENT(kvm, 3, "SET: CPNC: 0x%x CPVC: 0x%llx",
|                                            ~~~^
|                                               |
|                                               long long unsigned int

vim +1253 arch/s390/kvm/kvm-s390.c

  1245	
  1246	void kvm_s390_set_diag318_info(struct kvm *kvm, u64 info)
  1247	{
  1248		struct kvm_vcpu *vcpu;
  1249		int i;
  1250	
  1251		kvm->arch.diag318_info.val = info;
  1252	
> 1253		VM_EVENT(kvm, 3, "SET: CPNC: 0x%x CPVC: 0x%llx",
  1254			 kvm->arch.diag318_info.cpnc, kvm->arch.diag318_info.cpvc);
  1255	
  1256		if (sclp.has_diag318) {
  1257			kvm_for_each_vcpu(i, vcpu, kvm) {
  1258				vcpu->arch.sie_block->cpnc = kvm->arch.diag318_info.cpnc;
  1259			}
  1260		}
  1261	}
  1262	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 59249 bytes --]