From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> To: mpe@ellerman.id.au, mikey@neuling.org Cc: apopple@linux.ibm.com, paulus@samba.org, npiggin@gmail.com, christophe.leroy@c-s.fr, naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org, jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, ravi.bangoria@linux.ibm.com Subject: [PATCH v6 00/16] powerpc/watchpoint: Preparation for more than one watchpoint Date: Thu, 14 May 2020 16:47:25 +0530 [thread overview] Message-ID: <20200514111741.97993-1-ravi.bangoria@linux.ibm.com> (raw) So far, powerpc Book3S code has been written with an assumption of only one watchpoint. But Power10[1] is introducing second watchpoint register (DAWR). Even though this patchset does not enable 2nd DAWR, it makes the infrastructure ready so that enabling 2nd DAWR should just be a matter of changing count. Existing functionality works fine with the patchset. I've tested it with perf, ptrace(gdb), xmon. All hw-breakpoint selftests are passing as well. And I've build tested for 8xx and 'AMCC 44x, 46x or 47x'. Note: kvm or PowerVM guest is not enabled yet. v5: https://lore.kernel.org/linuxppc-dev/20200511025911.212827-1-ravi.bangoria@linux.ibm.com v5->v6: - Rebased to powerpc/next-test which has prefix-instruction support - Adopt 'struct ppc_inst' in hw-breakpoint code as well [1]: https://www-355.ibm.com/systems/power/openpower/ Ravi Bangoria (16): powerpc/watchpoint: Rename current DAWR macros powerpc/watchpoint: Add SPRN macros for second DAWR powerpc/watchpoint: Introduce function to get nr watchpoints dynamically powerpc/watchpoint/ptrace: Return actual num of available watchpoints powerpc/watchpoint: Provide DAWR number to set_dawr powerpc/watchpoint: Provide DAWR number to __set_breakpoint powerpc/watchpoint: Get watchpoint count dynamically while disabling them powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable powerpc/watchpoint: Convert thread_struct->hw_brk to an array powerpc/watchpoint: Use loop for thread_struct->ptrace_bps powerpc/watchpoint: Introduce is_ptrace_bp() function powerpc/watchpoint: Use builtin ALIGN*() macros powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint powerpc/watchpoint: Don't allow concurrent perf and ptrace events powerpc/watchpoint/xmon: Don't allow breakpoint overwriting powerpc/watchpoint/xmon: Support 2nd DAWR arch/powerpc/include/asm/cputable.h | 6 +- arch/powerpc/include/asm/debug.h | 2 +- arch/powerpc/include/asm/hw_breakpoint.h | 32 +- arch/powerpc/include/asm/processor.h | 6 +- arch/powerpc/include/asm/reg.h | 6 +- arch/powerpc/include/asm/sstep.h | 2 + arch/powerpc/kernel/dawr.c | 23 +- arch/powerpc/kernel/hw_breakpoint.c | 642 ++++++++++++++++++---- arch/powerpc/kernel/process.c | 85 +-- arch/powerpc/kernel/ptrace/ptrace-noadv.c | 72 ++- arch/powerpc/kernel/ptrace/ptrace32.c | 4 +- arch/powerpc/kernel/signal.c | 13 +- arch/powerpc/kvm/book3s_hv.c | 12 +- arch/powerpc/kvm/book3s_hv_rmhandlers.S | 18 +- arch/powerpc/xmon/xmon.c | 99 +++- kernel/events/hw_breakpoint.c | 16 + 16 files changed, 811 insertions(+), 227 deletions(-) -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Ravi Bangoria <ravi.bangoria@linux.ibm.com> To: mpe@ellerman.id.au, mikey@neuling.org Cc: christophe.leroy@c-s.fr, apopple@linux.ibm.com, ravi.bangoria@linux.ibm.com, peterz@infradead.org, fweisbec@gmail.com, oleg@redhat.com, npiggin@gmail.com, linux-kernel@vger.kernel.org, paulus@samba.org, jolsa@kernel.org, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org Subject: [PATCH v6 00/16] powerpc/watchpoint: Preparation for more than one watchpoint Date: Thu, 14 May 2020 16:47:25 +0530 [thread overview] Message-ID: <20200514111741.97993-1-ravi.bangoria@linux.ibm.com> (raw) So far, powerpc Book3S code has been written with an assumption of only one watchpoint. But Power10[1] is introducing second watchpoint register (DAWR). Even though this patchset does not enable 2nd DAWR, it makes the infrastructure ready so that enabling 2nd DAWR should just be a matter of changing count. Existing functionality works fine with the patchset. I've tested it with perf, ptrace(gdb), xmon. All hw-breakpoint selftests are passing as well. And I've build tested for 8xx and 'AMCC 44x, 46x or 47x'. Note: kvm or PowerVM guest is not enabled yet. v5: https://lore.kernel.org/linuxppc-dev/20200511025911.212827-1-ravi.bangoria@linux.ibm.com v5->v6: - Rebased to powerpc/next-test which has prefix-instruction support - Adopt 'struct ppc_inst' in hw-breakpoint code as well [1]: https://www-355.ibm.com/systems/power/openpower/ Ravi Bangoria (16): powerpc/watchpoint: Rename current DAWR macros powerpc/watchpoint: Add SPRN macros for second DAWR powerpc/watchpoint: Introduce function to get nr watchpoints dynamically powerpc/watchpoint/ptrace: Return actual num of available watchpoints powerpc/watchpoint: Provide DAWR number to set_dawr powerpc/watchpoint: Provide DAWR number to __set_breakpoint powerpc/watchpoint: Get watchpoint count dynamically while disabling them powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable powerpc/watchpoint: Convert thread_struct->hw_brk to an array powerpc/watchpoint: Use loop for thread_struct->ptrace_bps powerpc/watchpoint: Introduce is_ptrace_bp() function powerpc/watchpoint: Use builtin ALIGN*() macros powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint powerpc/watchpoint: Don't allow concurrent perf and ptrace events powerpc/watchpoint/xmon: Don't allow breakpoint overwriting powerpc/watchpoint/xmon: Support 2nd DAWR arch/powerpc/include/asm/cputable.h | 6 +- arch/powerpc/include/asm/debug.h | 2 +- arch/powerpc/include/asm/hw_breakpoint.h | 32 +- arch/powerpc/include/asm/processor.h | 6 +- arch/powerpc/include/asm/reg.h | 6 +- arch/powerpc/include/asm/sstep.h | 2 + arch/powerpc/kernel/dawr.c | 23 +- arch/powerpc/kernel/hw_breakpoint.c | 642 ++++++++++++++++++---- arch/powerpc/kernel/process.c | 85 +-- arch/powerpc/kernel/ptrace/ptrace-noadv.c | 72 ++- arch/powerpc/kernel/ptrace/ptrace32.c | 4 +- arch/powerpc/kernel/signal.c | 13 +- arch/powerpc/kvm/book3s_hv.c | 12 +- arch/powerpc/kvm/book3s_hv_rmhandlers.S | 18 +- arch/powerpc/xmon/xmon.c | 99 +++- kernel/events/hw_breakpoint.c | 16 + 16 files changed, 811 insertions(+), 227 deletions(-) -- 2.26.2
next reply other threads:[~2020-05-14 11:18 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-14 11:17 Ravi Bangoria [this message] 2020-05-14 11:17 ` [PATCH v6 00/16] powerpc/watchpoint: Preparation for more than one watchpoint Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 01/16] powerpc/watchpoint: Rename current DAWR macros Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 02/16] powerpc/watchpoint: Add SPRN macros for second DAWR Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 03/16] powerpc/watchpoint: Introduce function to get nr watchpoints dynamically Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 04/16] powerpc/watchpoint/ptrace: Return actual num of available watchpoints Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 05/16] powerpc/watchpoint: Provide DAWR number to set_dawr Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 07/16] powerpc/watchpoint: Get watchpoint count dynamically while disabling them Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 09/16] powerpc/watchpoint: Convert thread_struct->hw_brk to an array Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 10/16] powerpc/watchpoint: Use loop for thread_struct->ptrace_bps Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 11/16] powerpc/watchpoint: Introduce is_ptrace_bp() function Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 12/16] powerpc/watchpoint: Use builtin ALIGN*() macros Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 13/16] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 14/16] powerpc/watchpoint: Don't allow concurrent perf and ptrace events Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-14 11:17 ` [PATCH v6 16/16] powerpc/watchpoint/xmon: Support 2nd DAWR Ravi Bangoria 2020-05-14 11:17 ` Ravi Bangoria 2020-05-20 11:00 ` [PATCH v6 00/16] powerpc/watchpoint: Preparation for more than one watchpoint Michael Ellerman 2020-05-20 11:00 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200514111741.97993-1-ravi.bangoria@linux.ibm.com \ --to=ravi.bangoria@linux.ibm.com \ --cc=apopple@linux.ibm.com \ --cc=christophe.leroy@c-s.fr \ --cc=fweisbec@gmail.com \ --cc=jolsa@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mikey@neuling.org \ --cc=mingo@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=npiggin@gmail.com \ --cc=oleg@redhat.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.