From: Andrew Lunn <andrew@lunn.ch>
To: Christian Herber <christian.herber@nxp.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>, Marek Vasut <marex@denx.de>,
Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
David Jander <david@protonic.nl>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [EXT] Re: [PATCH net-next v1] net: phy: tja11xx: add cable-test support
Date: Thu, 14 May 2020 18:01:52 +0200 [thread overview]
Message-ID: <20200514160152.GU499265@lunn.ch> (raw)
In-Reply-To: <AM0PR04MB704193C938ECC28DE9A1B28E86BC0@AM0PR04MB7041.eurprd04.prod.outlook.com>
On Thu, May 14, 2020 at 03:47:16PM +0000, Christian Herber wrote:
> Hi Andrew,
>
> > On Wed, May 13, 2020 at 03:39:00PM +0200, Andrew Lunn wrote:
> >> On Thu, May 14, 2020 at 02:09:59PM +0200, Oleksij Rempel wrote:
> >> ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER - the link partner is active.
> >>
> >> The TJA1102 is able to detect it if partner link is master.
> >>
> > master is not a cable diagnostics issue. This is a configuration
> > issue.
>
> Master is very relevant for cable diagnostics, as a cable
> measurement should not be done with an active link partner on the
> other end (i.e. a PHY in master mode trying to train the link).
> So if the measurement detects an active link partner disturbing the
> measurement, it is important to report this to the user.
So with 'normal' PHYs, we use autoneg to make the link go quiet. But
you don't have autoneg.
If there is no way to force the link quiet, then
ETHTOOL_A_CABLE_RESULT_CODE_ACTIVE_PARTNER makes sense. But we need to
keep the meaning generic. I don't want it to mean a T1 PHY with an
active master peer. It should be usable for any reason the link cannot
be made to go quiet.
Andrew
next prev parent reply other threads:[~2020-05-14 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 12:34 [PATCH net-next v1] net: phy: tja11xx: add cable-test support Oleksij Rempel
2020-05-13 13:39 ` Andrew Lunn
2020-05-13 17:40 ` Oleksij Rempel
2020-05-13 18:01 ` Andrew Lunn
2020-05-14 12:09 ` Oleksij Rempel
2020-05-14 13:38 ` Andrew Lunn
2020-05-14 15:47 ` [EXT] " Christian Herber
2020-05-14 16:01 ` Andrew Lunn [this message]
2020-05-14 17:27 ` Oleksij Rempel
2020-05-13 19:30 ` Andrew Lunn
2020-05-13 19:34 ` Florian Fainelli
2020-05-13 19:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514160152.GU499265@lunn.ch \
--to=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.